From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7560145D9B; Sun, 24 Nov 2024 19:13:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1330402B4; Sun, 24 Nov 2024 19:13:01 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 80B04402AF for ; Sun, 24 Nov 2024 19:12:59 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2124ccf03edso35028955ad.2 for ; Sun, 24 Nov 2024 10:12:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732471979; x=1733076779; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oL0rd5yQepDiVnsIu2px4dgFouXEHCG29IlbNUZHRRA=; b=BrDyBLWIw/17IKcdW1kojsrvd8NAy3FdJJ6ePQDE0xBCc24ygA56GfkoH/wdddEw5u +HRsYmCwkgkzseZZGguxccOZ2iO9H7KIiFEDrAPQwg1MSAdtFVx0bVfrRKlPwcA1JMFT U/pHWK5NOce0tTA+RoMPiD3yLn+ELD2/36HsZQz0aHewbIJVPB3aFi2TFuLyZsWxrGZ5 BZh0YfDWCtxaaCWF7dFzhpkuiVk41/Bl6REHeuUR+u2u8pzzJozE9x7WQdZ9OIpTYmhA 6dqkazzRpq1dwg94oxkG95T0YAaKLUV4Uej4q2EeQQPyAqyP5pR3YFSgKAjJ6wazxyqE UPCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732471979; x=1733076779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oL0rd5yQepDiVnsIu2px4dgFouXEHCG29IlbNUZHRRA=; b=t0ykwoIK9MyX+v/eAFz49XDSugVFFc8ykQklHyiKcWCfP7O9wcjciyWbM7j8duonJq NmQHWldqznM94XxEJL0haNBX+zbYYdvtiDUaSWuWEhtGz6UYwgMKir/f3JTvb/CksY4X +V6e3ITjhTtqMNScK1bnA1K8ZjSZ1peWbT9vbA+Q2PjT4O/Inzqy4f8g8ZUfiV6s5y1N yhSEwm+Awb1j/iboPaA9V8rcdTcZwPhLEwxVuw4a9LuaBDd1xYzZAtQsS1+owcPK+12q XnW3cUYgzv3OXRSvjmbQ/SihtKk0SH1jeA9yO1zzxc+YxeIcYvMPGlJds9dlCjhSz6Ie Y4ZA== X-Forwarded-Encrypted: i=1; AJvYcCXn1q1OHeQc/wCsA97O+/oqyKpkitn5ApBiCqdVOCB/nCqaf/PbxC0FzhtOQMOYcbvOhxc=@dpdk.org X-Gm-Message-State: AOJu0Yza7Wyml6ySikAJ0qKlLL0zKmElBJK9t5X+zpW2w92ygvzQeOQ5 ofbvqK0NoJiAxh/Wz7/D1GoNIZNT7SCIX5BAQHF6stxQ61c+GGerVuh8jmyZ15Y= X-Gm-Gg: ASbGncvYa+kTkO7Uq7ykXOjTKKeWnvpMsMMF+OUUCy4rTWUFiz+gEUdaJmLaX7ezJ/U qZb2PPU5Ch95KEpB+6erRCeyNXf9FMnhaU31gIPnR+DKmwdChkfgZICojoBlwc6vNOBPf5mbHCl /Rnpr3uGVO70WeIfROadwVhEkpCBcKo2zLfVEYS/J39Tv+vl+zq4NBAL7U/mjBVffR6Umf1sCdo Wi4kEuvDvK07rriFy+qMk5IvIxH+XFmpX6xXnDdRo57xDFIKKey8WDHcTCvPHxL1cGj9prSLEHl 9PbbDK2V5llsEMIXRoMWfB3Cd+8= X-Google-Smtp-Source: AGHT+IEzjGXZVABQ32i5p+vZFykDnaa81vaSDBsjV2r1Wzr6KDTbrCwtouq/uOOtpQuocryLRtO1+A== X-Received: by 2002:a17:902:ecc5:b0:20c:c704:629e with SMTP id d9443c01a7336-2129f838c2emr139466555ad.56.1732471978561; Sun, 24 Nov 2024 10:12:58 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dba1890sm49207975ad.78.2024.11.24.10.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2024 10:12:58 -0800 (PST) Date: Sun, 24 Nov 2024 09:46:53 -0800 From: Stephen Hemminger To: Jiawen Wu Cc: "'Ferruh Yigit'" , Subject: Re: [PATCH] net/txgbe: fix a mass of interrupts Message-ID: <20241124094653.5c7250fe@hermes.local> In-Reply-To: <010301db3a27$130f31a0$392d94e0$@trustnetic.com> References: <20241115083336.1195101-1-jiawenwu@trustnetic.com> <010301db3a27$130f31a0$392d94e0$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 19 Nov 2024 10:02:23 +0800 Jiawen Wu wrote: > On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote: > > On 11/15/2024 8:33 AM, Jiawen Wu wrote: > > > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by > > > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity > > > is set to 0xd by default too, which means these interrupts are rising-edge > > > sensitive. > > > > > > So when unplug the SFP module, GPIO line 0 'tx_fault' is 0 -> 1 triggers > > > the interrupt. However, the interrupt is not cleared. And GPIO interrupt > > > mask is enabled and disabled to trigger the MISC interrupt repeatedly. > > > > > > Since this 'tx_fault' interrupt does not make much sense, simply clear it > > > to fix the issue. > > > > > > Signed-off-by: Jiawen Wu > > > > > > > Hi Jiawen, > > > > Can you please provide a fixes tag? > > Also I believe you would like to backport this fix, if so please add the > > stable tag as well. > > I have thought about it. But there are two changes based on two commits: > 1. d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification") > 2. 12011b11a3d6 ("net/txgbe: adapt to MNG veto bit setting") > > Should I split the patch and add fixes tags separately? > > It is ok, as is. I can add the fixes tag for you. The purpose of the fixes is to help with discovering patches that need to go into stable. Applied to next-net