[PATCH v1 0/3] Bugfixes

[PATCH v1 0/3] Bugfixes

[Serhii Iliushyk]

This patch set provides further fixes:

Feature DSCP:
  The issue with the modification of the DSCP field
  for IPV4 and IPV6 is fixed by adding
  copying the DSCP value to the flow handler.

Feature MTU:
  Supplement existing toggle-like macros
  with respective opposites for the correct enablement of the MTU

The header rte_pmd_ntnic.h was moved
to the root of ntnic PMD. The correct place for this header.

Danylo Vodopianov (1):
  net/ntnic: fix action modify field DSCP

Oleksandr Kolomeiets (2):
  net/ntnic: add supplementary macros
  net/ntnic: move headers to driver's root

 drivers/net/ntnic/meson.build                                 | 3 +++
 .../nthw/flow_api/profile_inline/flow_api_profile_inline.c    | 4 ++++
 .../nthw/flow_api/profile_inline/flow_api_profile_inline.h    | 3 +++
 drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h                  | 0
 4 files changed, 10 insertions(+)
 rename drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h (100%)

-- 
2.45.0

[PATCH v1 1/3] net/ntnic: fix action modify field DSCP

[Serhii Iliushyk]

From: Danylo Vodopianov <dvo-plv@napatech.com>

The issue with modification of the DSCP field
for IPV4 and IPV6 is fixed by adding
copying the DSCP value to the flow handler.

Fixes: 6fec9a9a12e1 ("net/ntnic: add infrastructure for flow actions and items")

Signed-off-by: Danylo Vodopianov <dvo-plv@napatech.com>
---
 .../nthw/flow_api/profile_inline/flow_api_profile_inline.c    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c
index a34839e00c..683610445d 100644
--- a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c
+++ b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c
@@ -3057,6 +3057,10 @@ static void copy_fd_to_fh_flm(struct flow_handle *fh, const struct nic_flow_def
 	for (unsigned int i = 0; i < fd->modify_field_count; ++i) {
 		switch (fd->modify_field[i].select) {
 		case CPY_SELECT_DSCP_IPV4:
+		case CPY_SELECT_DSCP_IPV6:
+			fh->flm_dscp = fd->modify_field[i].value8[0];
+			break;
+
 		case CPY_SELECT_RQI_QFI:
 			fh->flm_rqi = (fd->modify_field[i].value8[0] >> 6) & 0x1;
 			fh->flm_qfi = fd->modify_field[i].value8[0] & 0x3f;
-- 
2.45.0

[PATCH v1 2/3] net/ntnic: add supplementary macros

[Serhii Iliushyk]

From: Oleksandr Kolomeiets <okl-plv@napatech.com>

Supplement existing toggle-like macros with respective opposites:
* DISABLE_FRAGMENTATION -> ENABLE_FRAGMENTATION
* IPV4_DF_DROP          -> IPV4_DF_FORWARD
* IPV6_DROP             -> IPV6_FRAGMENT

Fixes: 6019656d6f68 ("net/ntnic: add MTU configuration")

Signed-off-by: Oleksandr Kolomeiets <okl-plv@napatech.com>
---
 .../nthw/flow_api/profile_inline/flow_api_profile_inline.h     | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.h b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.h
index ce1a0669ee..169f71ee68 100644
--- a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.h
+++ b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.h
@@ -11,9 +11,12 @@
 #include "flow_api.h"
 #include "stream_binary_flow_api.h"
 
+#define ENABLE_FRAGMENTATION 1
 #define DISABLE_FRAGMENTATION 0
 #define IPV4_DF_DROP 1
+#define IPV4_DF_FORWARD 0
 #define IPV6_DROP 1
+#define IPV6_FRAGMENT 0
 
 /*
  * Management
-- 
2.45.0

[PATCH v1 3/3] net/ntnic: move headers to driver's root

[Serhii Iliushyk]

From: Oleksandr Kolomeiets <okl-plv@napatech.com>

Move rte_pmd_ntnic.h to drivers/net/ntnic and specify it in meson file.

Fixes: e7e49ce6c760 ("net/ntnic: add flow statistics")

Signed-off-by: Oleksandr Kolomeiets <okl-plv@napatech.com>
---
 drivers/net/ntnic/meson.build                | 3 +++
 drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h | 0
 2 files changed, 3 insertions(+)
 rename drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h (100%)

diff --git a/drivers/net/ntnic/meson.build b/drivers/net/ntnic/meson.build
index ca46541ef3..3c05ad1d87 100644
--- a/drivers/net/ntnic/meson.build
+++ b/drivers/net/ntnic/meson.build
@@ -23,6 +23,9 @@ includes = [
         include_directories('nim/'),
 ]
 
+# headers
+headers = files('rte_pmd_ntnic.h')
+
 # all sources
 sources = files(
         'adapter/nt4ga_adapter.c',
diff --git a/drivers/net/ntnic/nthw/rte_pmd_ntnic.h b/drivers/net/ntnic/rte_pmd_ntnic.h
similarity index 100%
rename from drivers/net/ntnic/nthw/rte_pmd_ntnic.h
rename to drivers/net/ntnic/rte_pmd_ntnic.h
-- 
2.45.0

Re: [PATCH v1 0/3] Bugfixes

[Stephen Hemminger]

On Wed, 20 Nov 2024 19:02:54 +0100
Serhii Iliushyk <sil-plv@napatech.com> wrote:

> This patch set provides further fixes:
> 
> Feature DSCP:
>   The issue with the modification of the DSCP field
>   for IPV4 and IPV6 is fixed by adding
>   copying the DSCP value to the flow handler.
> 
> Feature MTU:
>   Supplement existing toggle-like macros
>   with respective opposites for the correct enablement of the MTU
> 
> The header rte_pmd_ntnic.h was moved
> to the root of ntnic PMD. The correct place for this header.
> 
> Danylo Vodopianov (1):
>   net/ntnic: fix action modify field DSCP
> 
> Oleksandr Kolomeiets (2):
>   net/ntnic: add supplementary macros
>   net/ntnic: move headers to driver's root
> 
>  drivers/net/ntnic/meson.build                                 | 3 +++
>  .../nthw/flow_api/profile_inline/flow_api_profile_inline.c    | 4 ++++
>  .../nthw/flow_api/profile_inline/flow_api_profile_inline.h    | 3 +++
>  drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h                  | 0
>  4 files changed, 10 insertions(+)
>  rename drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h (100%)
> 

Applied to next-net

Re: [PATCH v1 0/3] Bugfixes

[Serhii Iliushyk]

>On 24.11.2024, 20:13, "Stephen Hemminger" wrote:
>
>
>On Wed, 20 Nov 2024 19:02:54 +0100
>Serhii Iliushyk <sil-plv@napatech.com <mailto:sil-plv@napatech.com>> wrote:
>
>
>> This patch set provides further fixes:
>> 
>> Feature DSCP:
>> The issue with the modification of the DSCP field
>> for IPV4 and IPV6 is fixed by adding
>> copying the DSCP value to the flow handler.
>> 
>> Feature MTU:
>> Supplement existing toggle-like macros
>> with respective opposites for the correct enablement of the MTU
>> 
>> The header rte_pmd_ntnic.h was moved
>> to the root of ntnic PMD. The correct place for this header.
>> 
>> Danylo Vodopianov (1):
>> net/ntnic: fix action modify field DSCP
>> 
>> Oleksandr Kolomeiets (2):
>> net/ntnic: add supplementary macros
>> net/ntnic: move headers to driver's root
>> 
>> drivers/net/ntnic/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,KPLdWALh1y_hzTNAJ-J55jj5ck-Z4ano3LwTmgN8N-LYP4Z64ZnvMaYCxWcittpHHlIqOaUZJ7LdJ3eCxvocGIh_ND_7k1sv_6QlT0HMJxMZDQ,,&typo=1 <https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&amp;c=E,1,KPLdWALh1y_hzTNAJ-J55jj5ck-Z4ano3LwTmgN8N-LYP4Z64ZnvMaYCxWcittpHHlIqOaUZJ7LdJ3eCxvocGIh_ND_7k1sv_6QlT0HMJxMZDQ,,&amp;typo=1&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;> | 3 +++
>> .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 4 ++++
>> .../nthw/flow_api/profile_inline/flow_api_profile_inline.h | 3 +++
>> drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h | 0
>> 4 files changed, 10 insertions(+)
>> rename drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h (100%)
>> 
>
>
>Applied to next-net
>
>

Hi Stephen,

I would like to know if these patches will be included in the RC4 for DPDK 24.11. Their current state on the patchwork is "under review."
I want to know the exact state due to the coming code freeze date for RC4. Please let me know the details.

Also, I'm wondering about this patch set: https://patches.dpdk.org/project/dpdk/list/?series=34016
May It be included in the RC4?

It is essential for us to have these fixes included in the DPDK 24.11.

Thanks,
Serhii