From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E7845DA7; Tue, 26 Nov 2024 05:44:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B54454025F; Tue, 26 Nov 2024 05:44:20 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 16ED14025F for ; Tue, 26 Nov 2024 05:44:18 +0100 (CET) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AQ3MhE9014686; Mon, 25 Nov 2024 20:44:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=h QO7tJJfDB6Gqkkke+OcBT3vgFu6gtBbGjOH9KawN9k=; b=J5yEmLFEgr7ZEtPwG bgT43WJtknlBb6VDpiY1gtDtLPkixXgJVXSqux9cMIKLueYE/84PzM0hE8tpUTh3 AXJMn8hvl/Ws03+LkxVnlsD+eW5Nrqhw6Ly8VgB1F8Cj9LCxMoNYtrkJG84HHk2W ab5NkMIQCl5jzkYlBcyFy/UfeYr/yORyDxsSrtHVlFuNZUAI5m9JvQG84dgwi7Qs Bzqv6qz4jZ6ZGABz8mPri9wBirjBnBfLqp/TaVQiJTQuhN4rfjnIs81fR/nJM0+o Hs0N6yUV9ihI/AK3Sn7G7NRLNBUjcKgdqTiPcgFlPDfw26SWQxvglT2QwgINrK/w 4AXAw== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4356cc84cp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Nov 2024 20:44:15 -0800 (PST) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 25 Nov 2024 20:44:13 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 25 Nov 2024 20:44:13 -0800 Received: from cavium-System-Product-Name.. (unknown [10.28.37.22]) by maili.marvell.com (Postfix) with ESMTP id A95963F7093; Mon, 25 Nov 2024 20:44:11 -0800 (PST) From: To: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan CC: , , Subject: [PATCH v5 2/3] graph: add support for node free API Date: Tue, 26 Nov 2024 10:14:01 +0530 Message-ID: <20241126044402.1209998-2-kirankumark@marvell.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241126044402.1209998-1-kirankumark@marvell.com> References: <20241114070432.3152188-1-kirankumark@marvell.com> <20241126044402.1209998-1-kirankumark@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: grC_5VpqmM6G4VP9_hRW2VZLtfTdpz6A X-Proofpoint-GUID: grC_5VpqmM6G4VP9_hRW2VZLtfTdpz6A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kiran Kumar K Add support for rte_node_free API to free the node and its memory, if node is not part of any of the created graphs. Signed-off-by: Kiran Kumar K --- v5: - Fix review comments. lib/graph/graph.c | 16 ++++++++++++++++ lib/graph/graph_private.h | 13 +++++++++++++ lib/graph/node.c | 25 +++++++++++++++++++++++++ lib/graph/rte_graph.h | 15 +++++++++++++++ lib/graph/version.map | 3 +++ 5 files changed, 72 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/graph.c index dff8e690a8..bad00c8fc0 100644 --- a/lib/graph/graph.c +++ b/lib/graph/graph.c @@ -20,6 +20,22 @@ static struct graph_head graph_list = STAILQ_HEAD_INITIALIZER(graph_list); static rte_spinlock_t graph_lock = RTE_SPINLOCK_INITIALIZER; +bool +graph_is_node_active_in_graph(struct node *node) +{ + struct graph *graph; + + STAILQ_FOREACH(graph, &graph_list, next) { + struct graph_node *graph_node; + + STAILQ_FOREACH(graph_node, &graph->node_list, next) + if (graph_node->node == node) + return 1; + } + + return 0; +} + /* Private functions */ static struct graph * graph_from_id(rte_graph_t id) diff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h index fdaf5649b8..6eecba4f78 100644 --- a/lib/graph/graph_private.h +++ b/lib/graph/graph_private.h @@ -440,4 +440,17 @@ int graph_sched_wq_create(struct graph *_graph, struct graph *_parent_graph, */ void graph_sched_wq_destroy(struct graph *_graph); +/** + * @internal + * + * Check if given node present in any of the created graphs. + * + * @param node + * The node object + * + * @return + * 0 if not present in any graph, else return 1. + */ +bool graph_is_node_active_in_graph(struct node *_node); + #endif /* _RTE_GRAPH_PRIVATE_H_ */ diff --git a/lib/graph/node.c b/lib/graph/node.c index 5ff8dfcd55..5aaf787d5e 100644 --- a/lib/graph/node.c +++ b/lib/graph/node.c @@ -481,3 +481,28 @@ rte_node_max_count(void) } return node_id; } + +int +rte_node_free(rte_node_t id) +{ + struct node *node; + int rc = -1; + + if (node_from_id(id) == NULL) + goto fail; + + graph_spinlock_lock(); + STAILQ_FOREACH(node, &node_list, next) { + if (id == node->id) { + if (!graph_is_node_active_in_graph(node)) { + STAILQ_REMOVE(&node_list, node, node, next); + free(node); + rc = 0; + } + break; + } + } + graph_spinlock_unlock(); +fail: + return rc; +} diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h index f5e575dbed..097d0dc9d5 100644 --- a/lib/graph/rte_graph.h +++ b/lib/graph/rte_graph.h @@ -22,6 +22,7 @@ #include #include +#include #ifdef __cplusplus extern "C" { @@ -661,6 +662,20 @@ rte_node_is_invalid(rte_node_t id) return (id == RTE_NODE_ID_INVALID); } +/** + * Release the memory allocated for a node created using RTE_NODE_REGISTER or rte_node_clone, + * if it is not linked to any graphs. + * + * @param id + * Node id to check. + * + * @return + * - 0: Success. + * -<0: Failure. + */ +__rte_experimental +int rte_node_free(rte_node_t id); + /** * Test the validity of edge id. * diff --git a/lib/graph/version.map b/lib/graph/version.map index 44fadc00fd..a793ea1d8e 100644 --- a/lib/graph/version.map +++ b/lib/graph/version.map @@ -58,4 +58,7 @@ EXPERIMENTAL { # added in 24.11 rte_node_xstat_increment; + + # added in 25.03 + rte_node_free; }; -- 2.43.0