From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 576AE45DAF; Wed, 27 Nov 2024 00:51:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47B5240EE3; Wed, 27 Nov 2024 00:51:47 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 09379402A7 for ; Wed, 27 Nov 2024 00:51:45 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2edfd7b48b0so722476a91.1 for ; Tue, 26 Nov 2024 15:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732665105; x=1733269905; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=l5HLIKyX8cOrPOjLv5RQi5Bk7J6IGZOCPgVSLchpH54=; b=FQTjIF5r0npEiuwe2sRhpSoVBMGz5dp7cdHk5c+pIXMzWo00ZYZim09Hoe1BWw1pLU AbWhVB/YWNcNRvId/9hlhcaqE55ZcEKNHGhsVRixeZHmM/oMmNEzhuA9Rx6t6+ieGJns +u6EtTnSlp459gpIVw0weW5X7uDTkpOpCdmJXRzUJcLZwiZ+XhJeOHzM5Jmg8SY3F1tN AheRyJPswUMrbOnhkSP+S2eILBwes2PdEG99ENBeqoqO1YqDnkJDCy6zutFtnVHT8G4f 0ZNS8oWXbMhYk2WrjYlotvcUCUVQpnWoR5Kfnlwum4RXveoDy06alaf6X1D7MuBeZC9J fbow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732665105; x=1733269905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l5HLIKyX8cOrPOjLv5RQi5Bk7J6IGZOCPgVSLchpH54=; b=T7zDIGTCjXrFGOyWsCMLuE+eVxbJFMHjzXhuV4xTGSKQ34eNgrGKX76yPtiipNtKyK fTg9bYC4Pxzla62yciilpgq6unwG7UH9CwKfB3ZHZ8eLyZDTbI6cFte0GeWQtCPC4KZ2 G7Dlhdl8LMNuj7rNo0OjulR1puKqWtL85qzyY3QbVUDxuczJBbCDSIgAN8VpSbG1HrWP LG4HT/zvwhq8H2GHlQCyA9Qn/Gl9blhb3lfxOY0UDq+atsxSWdHg3ucJG3vsKta0vINb QxRac8vNs22GpSQgY/gX1DM58CIfV10gPbOztc1WYXShVzCz0zLls88x5i/eQF18vXf4 IGoA== X-Gm-Message-State: AOJu0YwEV3TmaF2dHWm7ZivUVfDithtjUfvJWroCnmEIxwaFbgBZqqEM 4ANj3yfTyqpZYIWAzQGgEWyINrqApIFB4eJQ1q90Zp+So7QbqfopIP80k1vucKc= X-Gm-Gg: ASbGnctgc9IipIujeEQTQqyjMzcFyOoIRfVkJVR5Hb/73bAmKLH9n7sXj/420oGsWLp y6qfD98hOfcDRKK62AcnmT5A6WMaZqK16luXXczeN0ZevdXnJfWT7VCiPOoVSad09AiTVIel698 AjU8B0R6UX327kwZhwnSDpCDDz2HlSC1+Mv4GLvt9yFjMtTDIpvH1+hntCs210qgsU49AcZL1mL kf5lE/3Lj2ceZtFwm1F5V1PLAArf/ZooXYQdqdf133dYwwYvcpNPobj8Ev62irmYzoHh5EBkVVj 5K8DbgL3TNw2lEPEN+n/0L2LSdU= X-Google-Smtp-Source: AGHT+IE6t9NUOMYy9tsBj8TFebiLwoZQVX9ClzEDLkPBBaRj8PpF2HtD/Wn+bSiJZSC6uF9B4X8C9g== X-Received: by 2002:a17:90b:1850:b0:2ea:b2d7:4a35 with SMTP id 98e67ed59e1d1-2ee08e5cc0cmr1489311a91.2.1732665104992; Tue, 26 Nov 2024 15:51:44 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee0fa4c8aesm132479a91.22.2024.11.26.15.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 15:51:44 -0800 (PST) Date: Tue, 26 Nov 2024 15:51:42 -0800 From: Stephen Hemminger To: Jie Hai Cc: , , , , Thomas Monjalon , Allain Legacy , , , Subject: Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload Message-ID: <20241126155142.626b5744@hermes.local> In-Reply-To: <240c5047-7f42-97f8-71ab-b0f78d434e59@huawei.com> References: <20240206011030.2007689-1-haijie1@huawei.com> <20240719090415.1513301-1-haijie1@huawei.com> <20240719090415.1513301-2-haijie1@huawei.com> <20241122091055.5e87f298@hermes.local> <240c5047-7f42-97f8-71ab-b0f78d434e59@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 26 Nov 2024 15:47:32 +0800 Jie Hai wrote: > Hi, Stephen Hemminger > > Thanks for your review. > I will add doc and fix on drivers in the next version. > The test will be done later. > > On 2024/11/23 1:10, Stephen Hemminger wrote: > > On Fri, 19 Jul 2024 17:04:13 +0800 > > Jie Hai wrote: > > > >> From: Dengdui Huang > >> > >> The data exceeds the pkt_len in mbuf is inavailable for user. > > unavailable > > > >> When KEEP CRC offload is enabled, CRC field length should be > >> included in the pkt_len in mbuf. However, almost of drivers > >> supported KEEP CRC feature didn't add the CRC data length to > >> pkt_len. So it is very necessary to add comments for this. > > > > All drivers must do the same thing, or this is a serious bug > > in the drivers. Just changing a comment is not going to be helpful. > > > > To fix this right: > > 1. Do a test with one of the original drivers in DPDK that has this > > feature. I would suggest ixgbe, mlx5 or bnxt. > > I can test it on ixgbe and mlx5. > > 2. Add a test to the PMD tests that validates this (if there is not > > one already). > > > Maybe later and not come with this patchset. > > 3. Put the documentation in a place where it shows up in user documentation. > > Either in doxygen comment or in doc/guides/nics > > > Will add in the next version. > > 4. Verify that all devices conform to the desired behavior > > > > I can help, but only have some old mlx5 cards to test here. > Thanks. > > Just putting comment in ethdev.h is not enough. > > > > Thanks, > Jie Hai > > > After more discussion, decided to not include this patch (only the two bugfixes). The proper place to put it is in the programmer's guide, and also you have discovered a messy place in the driver API. In 10 minutes, already found several issues in other drivers around this. Like checking wrong bits, dead code, etc.