From: Stephen Hemminger <stephen@networkplumber.org>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: <dev@dpdk.org>, <rasland@nvidia.com>, <matan@nvidia.com>,
<suanmingm@nvidia.com>
Subject: Re: [PATCH v2] doc: add mlx5 xstats send scheduling counters description
Date: Tue, 26 Nov 2024 16:36:58 -0800 [thread overview]
Message-ID: <20241126163658.12682008@hermes.local> (raw)
In-Reply-To: <20241031080438.1701634-1-viacheslavo@nvidia.com>
On Thu, 31 Oct 2024 10:04:38 +0200
Viacheslav Ovsiienko <viacheslavo@nvidia.com> wrote:
> The mlx5 provides the scheduling send on time capability.
> To check the operating status of this feature the extended statistics
> counters are provided. This patch adds the counter descriptions
> and provides some meaningful information how to interpret
> the counter values in runtime.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> doc/guides/nics/mlx5.rst | 59 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index b5522d50c5..5db4aeda1b 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -2662,3 +2662,62 @@ Destroy GENEVE TLV parser for specific port::
>
> This command doesn't destroy the global list,
> For releasing options, ``flush`` command should be used.
> +
> +
> +Extended Statistics Counters
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +Send Scheduling Extended Statistics Counters
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It is great to see description of counters, it would be good if all drivers did
this for xstats. There are some issues with the documentation that should be
addressed in later update.
The section number is wrong. It ends up as a subset of the "Testpmd driver specific
commands". It should be in the Statistics section.
The section headings overall for this NIC guide need to be reorganized/reworded.
Kind of mess now.
prev parent reply other threads:[~2024-11-27 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 14:27 [PATCH 1/1] " Viacheslav Ovsiienko
2024-10-28 15:57 ` Stephen Hemminger
2024-10-31 8:04 ` [PATCH v2] " Viacheslav Ovsiienko
2024-11-27 0:36 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126163658.12682008@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).