DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] fib: rename configuration flag
@ 2024-11-26 17:18 Vladimir Medvedkin
  2024-11-26 18:56 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Medvedkin @ 2024-11-26 17:18 UTC (permalink / raw)
  To: dev; +Cc: david.marchand, stephen, rjarry, mb, thomas

Rename RTE_FIB_F_NETWORK_ORDER with RTE_FIB_F_LOOKUP_NETWORK_ORDER to
explicitly indicate that it is only used in lookup.

Fixes: e194f3cd5685 ("fib: lookup IPv4 address in network order")

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 lib/fib/rte_fib.c | 4 ++--
 lib/fib/rte_fib.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c
index db79fc428e..49211fe3fa 100644
--- a/lib/fib/rte_fib.c
+++ b/lib/fib/rte_fib.c
@@ -111,7 +111,7 @@ init_dataplane(struct rte_fib *fib, __rte_unused int socket_id,
 		if (fib->dp == NULL)
 			return -rte_errno;
 		fib->lookup = dir24_8_get_lookup_fn(fib->dp,
-			RTE_FIB_LOOKUP_DEFAULT, !!(fib->flags & RTE_FIB_F_NETWORK_ORDER));
+			RTE_FIB_LOOKUP_DEFAULT, !!(fib->flags & RTE_FIB_F_LOOKUP_NETWORK_ORDER));
 		fib->modify = dir24_8_modify;
 		return 0;
 	default:
@@ -333,7 +333,7 @@ rte_fib_select_lookup(struct rte_fib *fib,
 	switch (fib->type) {
 	case RTE_FIB_DIR24_8:
 		fn = dir24_8_get_lookup_fn(fib->dp, type,
-			!!(fib->flags & RTE_FIB_F_NETWORK_ORDER));
+			!!(fib->flags & RTE_FIB_F_LOOKUP_NETWORK_ORDER));
 		if (fn == NULL)
 			return -EINVAL;
 		fib->lookup = fn;
diff --git a/lib/fib/rte_fib.h b/lib/fib/rte_fib.h
index 362bb8f08c..1eee79c955 100644
--- a/lib/fib/rte_fib.h
+++ b/lib/fib/rte_fib.h
@@ -88,8 +88,8 @@ enum rte_fib_lookup_type {
 };
 
 /** If set, fib lookup is expecting IPv4 address in network byte order */
-#define RTE_FIB_F_NETWORK_ORDER	1
-#define RTE_FIB_ALLOWED_FLAGS	(RTE_FIB_F_NETWORK_ORDER)
+#define RTE_FIB_F_LOOKUP_NETWORK_ORDER	1
+#define RTE_FIB_ALLOWED_FLAGS	(RTE_FIB_F_LOOKUP_NETWORK_ORDER)
 
 /** FIB configuration structure */
 struct rte_fib_conf {
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fib: rename configuration flag
  2024-11-26 17:18 [PATCH] fib: rename configuration flag Vladimir Medvedkin
@ 2024-11-26 18:56 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2024-11-26 18:56 UTC (permalink / raw)
  To: Vladimir Medvedkin; +Cc: david.marchand, stephen, rjarry, mb, dev

26/11/2024 18:18, Vladimir Medvedkin:
> Rename RTE_FIB_F_NETWORK_ORDER with RTE_FIB_F_LOOKUP_NETWORK_ORDER to
> explicitly indicate that it is only used in lookup.
> 
> Fixes: e194f3cd5685 ("fib: lookup IPv4 address in network order")
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-26 18:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-26 17:18 [PATCH] fib: rename configuration flag Vladimir Medvedkin
2024-11-26 18:56 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).