From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
Nicolas Chautru <nicolas.chautru@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Srikanth Yalavarthi <syalavarthi@marvell.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Ori Kam <orika@nvidia.com>, Akhil Goyal <gakhil@marvell.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: [RFC 2/6] drivers: drop export of driver headers
Date: Wed, 27 Nov 2024 12:26:12 +0100 [thread overview]
Message-ID: <20241127112617.1331125-3-david.marchand@redhat.com> (raw)
In-Reply-To: <20241127112617.1331125-1-david.marchand@redhat.com>
Many classes are exposing driver only headers as public headers.
Move them to the driver_sdk_headers list.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/bbdev/meson.build | 5 ++---
lib/ethdev/meson.build | 6 +++---
lib/mldev/meson.build | 5 +----
lib/rawdev/meson.build | 3 ++-
lib/regexdev/meson.build | 3 ++-
lib/security/meson.build | 3 ++-
6 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/lib/bbdev/meson.build b/lib/bbdev/meson.build
index 07685e7578..7d035065f1 100644
--- a/lib/bbdev/meson.build
+++ b/lib/bbdev/meson.build
@@ -8,7 +8,6 @@ if is_windows
endif
sources = files('rte_bbdev.c')
-headers = files('rte_bbdev.h',
- 'rte_bbdev_pmd.h',
- 'rte_bbdev_op.h')
+headers = files('rte_bbdev.h', 'rte_bbdev_op.h')
+driver_sdk_headers = files('rte_bbdev_pmd.h')
deps += ['mbuf']
diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build
index f1d2586591..8ba6c708a2 100644
--- a/lib/ethdev/meson.build
+++ b/lib/ethdev/meson.build
@@ -26,11 +26,8 @@ headers = files(
'rte_ethdev_trace_fp.h',
'rte_dev_info.h',
'rte_flow.h',
- 'rte_flow_driver.h',
'rte_mtr.h',
- 'rte_mtr_driver.h',
'rte_tm.h',
- 'rte_tm_driver.h',
)
indirect_headers += files(
@@ -42,6 +39,9 @@ driver_sdk_headers += files(
'ethdev_driver.h',
'ethdev_pci.h',
'ethdev_vdev.h',
+ 'rte_flow_driver.h',
+ 'rte_mtr_driver.h',
+ 'rte_tm_driver.h',
)
if is_linux
diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build
index 2c933baad6..efc3edd288 100644
--- a/lib/mldev/meson.build
+++ b/lib/mldev/meson.build
@@ -32,11 +32,8 @@ headers = files(
'rte_mldev.h',
)
-indirect_headers += files(
- 'rte_mldev_core.h',
-)
-
driver_sdk_headers += files(
+ 'rte_mldev_core.h',
'rte_mldev_pmd.h',
'mldev_utils.h',
)
diff --git a/lib/rawdev/meson.build b/lib/rawdev/meson.build
index 7dfc3d5cf9..ccfd922fda 100644
--- a/lib/rawdev/meson.build
+++ b/lib/rawdev/meson.build
@@ -8,6 +8,7 @@ if is_windows
endif
sources = files('rte_rawdev.c')
-headers = files('rte_rawdev.h', 'rte_rawdev_pmd.h')
+headers = files('rte_rawdev.h')
+driver_sdk_headers = files('rte_rawdev_pmd.h')
deps += ['telemetry']
diff --git a/lib/regexdev/meson.build b/lib/regexdev/meson.build
index 426e764ece..05040051c5 100644
--- a/lib/regexdev/meson.build
+++ b/lib/regexdev/meson.build
@@ -8,6 +8,7 @@ if is_windows
endif
sources = files('rte_regexdev.c')
-headers = files('rte_regexdev.h', 'rte_regexdev_driver.h')
+headers = files('rte_regexdev.h')
indirect_headers += files('rte_regexdev_core.h')
+driver_sdk_headers = files('rte_regexdev_driver.h')
deps += ['mbuf']
diff --git a/lib/security/meson.build b/lib/security/meson.build
index 1034a7a299..d5431d472c 100644
--- a/lib/security/meson.build
+++ b/lib/security/meson.build
@@ -2,5 +2,6 @@
# Copyright(c) 2017-2019 Intel Corporation
sources = files('rte_security.c')
-headers = files('rte_security.h', 'rte_security_driver.h')
+headers = files('rte_security.h')
+driver_sdk_headers = files('rte_security_driver.h')
deps += ['mempool', 'cryptodev', 'net']
--
2.47.0
next prev parent reply other threads:[~2024-11-27 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:26 [RFC 0/6] Add a stricter headers check David Marchand
2024-11-27 11:26 ` [RFC 1/6] baseband/acc: fix exported header David Marchand
2024-11-27 11:26 ` David Marchand [this message]
2024-11-27 11:26 ` [RFC 3/6] eventdev: do not include driver header in DMA adapter David Marchand
2024-11-27 13:49 ` [EXTERNAL] " Amit Prakash Shukla
2024-11-27 11:26 ` [RFC 4/6] drivers: fix exported headers David Marchand
2024-11-27 11:26 ` [RFC 5/6] build: install indirect headers to a dedicated directory David Marchand
2024-11-27 11:42 ` Bruce Richardson
2024-11-27 11:26 ` [RFC 6/6] buildtools: externally check exported headers David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127112617.1331125-3-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=nicolas.chautru@intel.com \
--cc=orika@nvidia.com \
--cc=sachin.saxena@nxp.com \
--cc=syalavarthi@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).