From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EEA345E0B; Mon, 2 Dec 2024 23:26:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEE5440270; Mon, 2 Dec 2024 23:26:57 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 54EC04025D for ; Mon, 2 Dec 2024 23:26:56 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2155312884fso31148515ad.0 for ; Mon, 02 Dec 2024 14:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733178415; x=1733783215; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WIwWGZSSdbhx/HQ0/5WHfGbt7HLnIH4IF92Lk6eKRns=; b=Pipb/mNEwqjtboAwEWQePq9Np6Zu69EJpHamxqnaPB0Ci8Y02T8eRiFts78XGxv9HF tvC1JO8nExHk2v/5DvTnb6LY0DPQ10NezxsRsYzWSBzUU5iVb1RaYhvsmvvM0ZDfti3K EoCkx03REG7BoSNGQ3kmiW72bdqO9VR1ukMnnO5QUegEk7Z4D62ILHU0Wqa6EOaEIIa1 krvB2v2apZyJ9rrf5z06saJmrFP9+Ye6fHuI45X9qn96SPizA3gQBPrwizn7WG0Rb/BL ez64pX+TmsrV++eCa4eATsRZb9F8lW/nyuflBFRpV97iHMRU2ZC5Q1GWAyDxWta46/hF AcAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733178415; x=1733783215; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WIwWGZSSdbhx/HQ0/5WHfGbt7HLnIH4IF92Lk6eKRns=; b=CovpAdP4yRdks4nuUrP3+PjBSbBOikPbAPkN3D9q8XCqeRBH2JKzCV3UyMlCtYzNsD BLUXzCeeStVo1Fq9bPQD/5b74EJnj/zrfQWJTaZxNFh1DMkc2TwmlkBX44Xn4tZv6JwY 8FMs4hslo5NcVxI8BTBDT8neAHAnRvH2yi+z/nhuO+RGLsk3f/ZjPnhrX/LJXvabI584 NETzIxGBPpA4dlbrexi9boiMvRNa0rfrgKHOru4C/bEETYzHvWWuautDlpPysmO/vsBU 0xXUJIXBE3gqYzktoTKVkhqeSDkDZe9rTpWyVqcBM/ZDB5DVFlh8YRKOHLO8EILTqrvG ZZNA== X-Gm-Message-State: AOJu0Yyn/XiDoyLgcWOvo+NpzxB0izC3gGtnzTxpp5nPBy+eOmun1f7H k7ARIAGAaL71BKGD1orUwMvl3M2grh1zNrg2udJhIhjjvcnA5APP7BNgX7Mq4ic= X-Gm-Gg: ASbGnctDtF74zR4wH9miUOksA1G98VSZUFh+pAjpbVIwv35pArhaCou4PR1U9D0dZGF Gaq0vPOy+9smdDyRfbX9tc4Lu2bxSWIiTeoY4y4cWn42KAYpmhSHfLyy3hoTsMlvCS5eiG9EE/R cxt89Eh9oefgOJOh7CAAhfzPIeY9YdE1Na/IRujdVws0jzh1YHJ73eiT3HF9H/GQZmJAdLww22c 1cfShODp94HRt0iJxifUUHVrbfqvqSNkzee5uCzbweIVll9P3ZVGg3WkmaXRZTKMg0K2zEAbFeA AZHBnnDN4nIskIP2YBkENAwEtTY= X-Google-Smtp-Source: AGHT+IGra1wgYJ6yHlCKkBkIp6eygzIwi4QQRf/tYjx5tjcPifS9btzq6LPiKK4zQ4yWPvMwOhmF4w== X-Received: by 2002:a17:902:d4cd:b0:210:fce4:11db with SMTP id d9443c01a7336-215bd200330mr2485075ad.22.1733178415329; Mon, 02 Dec 2024 14:26:55 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215218f47e4sm82271685ad.23.2024.12.02.14.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 14:26:55 -0800 (PST) Date: Mon, 2 Dec 2024 14:26:52 -0800 From: Stephen Hemminger To: vanshika.shukla@nxp.com Cc: dev@dpdk.org, Thomas Monjalon , Wathsala Vithanage , Bruce Richardson , Gagandeep Singh , Sachin Saxena , Anatoly Burakov , Apeksha Gupta Subject: Re: [v1 01/12] net/enetc: Add initial ENETC4 PMD driver support Message-ID: <20241202142652.6601a724@hermes.local> In-Reply-To: <20241018072644.2379012-2-vanshika.shukla@nxp.com> References: <20241018072644.2379012-1-vanshika.shukla@nxp.com> <20241018072644.2379012-2-vanshika.shukla@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Oct 2024 12:56:33 +0530 vanshika.shukla@nxp.com wrote: > +#. **Linux Kernel** > + > + It can be obtained from `NXP's Github hosting `_. > + IF the driver only exists for the DPDK then shouldn't it be in the DPDK kmods repo? I looked at the git hub version and the driver looks like it is not very polished. Mostly things that would be flagged during a code review. Lots of printk's like the developer was not sure. Lots of casts which hide potential bugs. Unsafe copy from user space. Module license and SPDX license mismatch.