Re: [RFC v3 1/2] pci: introduce the PCIe TLP Processing Hints API

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 21 Oct 2024 01:52:45 +0000
Wathsala Vithanage <wathsala.vithanage@arm.com> wrote:

> Extend the PCI driver and the library to extract the Steering Tag (ST)
> for a given Processor/Processor Container and Cache ID pair and validate
> a Processing Hint from a TPH _DSM associated with a root port device.
> The rte_pci_device structure passed into the rte_pci_extract_tph_st()
> function could be a device or a root port. If it's a device, the
> function should trace it back to the root port and use its TPH _DSM to
> extract STs. The implementation of rte_pci_extract_tph_st() is dependent
> on the operating system.
> 
> rte_pci_extract_tph_st() should also be supplied with a
> rte_tph_acpi__dsm_args, and a rte_tph_acpi__dsm_return structures.
> These two structures are defined in the PCI library and comply with the
> TPH _DSM argument and return encoding specified in the PCI firmware ECN
> titled "Revised _DSM for Cache Locality TPH Features.". Use of
> rte_init_tph_acpi__dsm_args() is recommended for initializing the
> rte_tph_acpi__dsm_args struct which is capable of converting lcore ID,
> the cache level into values understood by the ACPI _DSM function.
> rte_tph_acpi__dsm_return struct will be initialized with the values
> returned by the TPH _DSM; it is up to the caller to use these values per
> the device's capabilities.
> 
> Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Dhruv Tripathi <dhruv.tripathi@arm.com>

While doing review, noticed that patch has minor whitespace issue.

/home/shemminger/DPDK/main/.git/worktrees/stash/rebase-apply/patch:123: new blank line at EOF.
+
warning: 1 line adds whitespace errors.