From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD2BE45E21; Tue, 3 Dec 2024 22:14:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDFA140261; Tue, 3 Dec 2024 22:14:22 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id F34E24025D for ; Tue, 3 Dec 2024 22:14:20 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7fcf8406d8bso176489a12.0 for ; Tue, 03 Dec 2024 13:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733260460; x=1733865260; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JsJOV9Rr1CNQ72qYZnv8okqmQuqcr/9B4pxFof5VbJI=; b=ppx38rll3BjqXq7CC9D/2Q1ewR+OAGa25PLmf9Y4GQ8wC3ui7Dxi+E8dL6i8l31wOX un4WSCznC/HOdLn79xnLVFrVKcRTuZICzx7eFmLR0XjUxo4h2K92tJG/KK5WQ+Mx1kDy SUVCdI9oT45qaAEXF9Lk7xiGL2xX6mhPp5eWtzFYIA7Aj11Y8jWUVuZjafmFVfVYEC8z UL+siTN8JhEd3emQ9qhenegZqyHNGAZJIB8wefQFJaUUCJVbADh7zhQwJK4fl0QMF4Uc Tw69HEz6LPG4TSJqQXo2cTstPHf0CebDCH5JKw9PjhzzXifTRh7Vzum+Q0FdzvYhGXXq zfcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733260460; x=1733865260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JsJOV9Rr1CNQ72qYZnv8okqmQuqcr/9B4pxFof5VbJI=; b=j1QxKI51X2y4MrabAZi7+78ZChJHHo7a2XDYyjHvBbWrSi2r0UNIvblQ8EwLtTdsib fBaqUxjFniQdiDnESSYD7wpXSzgTpIJcqaCSssGHvigKOyDffdKNJJJlZAz8iK7OsVDo Kf7MVfhEIARSESCgb2oDC8M/gOCXNiIReJfj5uMrcFQy2NGzN/9Q4hz5VET7nfJQPdqe IChYZogkLf2k5tlqxXUBF7wm99U4/fXUGjW4iK12fKF/GJBH0QT8aMAl/+xsrXg66LVg EBoto7Lsez0EOHGG5HVKn2aZlgpYG1zDSPEr1kbZAp7kfdERA20t8jzY2YDQKl9cigK3 FBlg== X-Forwarded-Encrypted: i=1; AJvYcCVWGqZxx9f8ZmRGSUjpkYBynZVjR0DsfhVcuNTedytZ15CUr4npoI254yLgHBkFuO80CZI=@dpdk.org X-Gm-Message-State: AOJu0YyP+113qkf9TZBNBre4C6Xn7WNszV5UiNMkmEHCGitURAzWdfu3 vXX00O9KURU+QAUZcs6Z+AYd2Mr+o04zveF11Tb0RiqU7p8XC7YQH7ity0HRr6U= X-Gm-Gg: ASbGncuM1FpmFL5B2F5neor/cvUpBztYicI17aeu/qlBcb2QsQQYK4ExcP6Iva7DxX7 XUcSnjz5eaeto/dzWQJHQWxs4Zjwg33folcksUDxDk7bmxdDH8wIiKPXfZRZ9oHCq7pGmJdil14 fZQzhU5b1Lyjl8kk17oNCoIRTBMRtmopySMeYi4sKopMAJiMUKFwbJOhg9TX2Oc5AaRWdYyzUaz WuSg2yYSXKjji6u5BxsDHo2Wt2O1dWRj5eK9O8JrRjAqx0egJTdL/ef7Dr+GGH4Qblg1G2tXTY1 3rdmxkbcq+SKI8Y0bYxQuj6PFtE= X-Google-Smtp-Source: AGHT+IHdapxx/rn/a9RXBrPu4dxZXZ5hoywRtkk33WOAsriX16vBmIBavt/d9JJqVY1/9SDE+iQWRg== X-Received: by 2002:a05:6a21:33a1:b0:1d9:19bc:9085 with SMTP id adf61e73a8af0-1e165aac0e4mr6282348637.14.1733260460183; Tue, 03 Dec 2024 13:14:20 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72541761700sm11306435b3a.26.2024.12.03.13.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 13:14:19 -0800 (PST) Date: Tue, 3 Dec 2024 12:54:50 -0800 From: Stephen Hemminger To: Wathsala Vithanage Cc: Chenbo Xia , Nipun Gupta , Gaetan Rivet , dev@dpdk.org, nd@arm.com, Honnappa Nagarahalli , Dhruv Tripathi Subject: Re: [RFC v3 1/2] pci: introduce the PCIe TLP Processing Hints API Message-ID: <20241203125450.1bc1adb3@hermes.local> In-Reply-To: <20241021015246.304431-2-wathsala.vithanage@arm.com> References: <20240715221141.16153-1-wathsala.vithanage@arm.com> <20241021015246.304431-1-wathsala.vithanage@arm.com> <20241021015246.304431-2-wathsala.vithanage@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 21 Oct 2024 01:52:45 +0000 Wathsala Vithanage wrote: > Extend the PCI driver and the library to extract the Steering Tag (ST) > for a given Processor/Processor Container and Cache ID pair and validate > a Processing Hint from a TPH _DSM associated with a root port device. > The rte_pci_device structure passed into the rte_pci_extract_tph_st() > function could be a device or a root port. If it's a device, the > function should trace it back to the root port and use its TPH _DSM to > extract STs. The implementation of rte_pci_extract_tph_st() is dependent > on the operating system. > > rte_pci_extract_tph_st() should also be supplied with a > rte_tph_acpi__dsm_args, and a rte_tph_acpi__dsm_return structures. > These two structures are defined in the PCI library and comply with the > TPH _DSM argument and return encoding specified in the PCI firmware ECN > titled "Revised _DSM for Cache Locality TPH Features.". Use of > rte_init_tph_acpi__dsm_args() is recommended for initializing the > rte_tph_acpi__dsm_args struct which is capable of converting lcore ID, > the cache level into values understood by the ACPI _DSM function. > rte_tph_acpi__dsm_return struct will be initialized with the values > returned by the TPH _DSM; it is up to the caller to use these values per > the device's capabilities. > > Signed-off-by: Wathsala Vithanage > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Dhruv Tripathi While doing review, noticed that patch has minor whitespace issue. /home/shemminger/DPDK/main/.git/worktrees/stash/rebase-apply/patch:123: new blank line at EOF. + warning: 1 line adds whitespace errors.