From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF1B545E33; Wed, 4 Dec 2024 23:18:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E309402AF; Wed, 4 Dec 2024 23:18:24 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 58B294029B for ; Wed, 4 Dec 2024 23:18:23 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7258bce5289so251392b3a.0 for ; Wed, 04 Dec 2024 14:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733350702; x=1733955502; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hm+megEqLUvkD9LoUYEYhcMV3O9L2KjtwtK2fo7fe3I=; b=17nsSVXcTvLMAl1NgCK/ba9d1Fg7Taof/Vx7+BatPtvxVBUIZMRV7CawQF/BdhMmgD 8F8kcZzSx2Lv5stQQT7mCrfy/kVSWqCPIN3q55ZulLYRMs0SNXdWa/+qlLH3Oh7j0bjh OBjr6W7+AIo9sRZJgLWzMHQpz0+yZn9RGhIIDdvxMUJ2q3TBu91yo3eTTeBFdUB/nWsf 7GzFmfl3ckTVsU6G7+mgZ6EQ7vNOrY+AeTtiXn7gRNor3crtzb3oQr9xOD/wHYA/7FsE DqW/wzCtCfFRJGKYp57KgxwPz8uXKeOSDUgbdQi1LC8/qzwkM8ff18DcrqK0P9DMWBEh FFxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733350702; x=1733955502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hm+megEqLUvkD9LoUYEYhcMV3O9L2KjtwtK2fo7fe3I=; b=HS1TLjFyWpi7hBiRbKlnX+0InRcuFDyZ+aRHr/RJde2Raasm0oxyCbVPoL8rila6XK 4+arBSCCvwTkYz59t9aWav3vrPJ24EzQfB9XJonA1t/3XpoKoSk9tY4ty0KzRnlk58m7 xIFQ3xR/C27MOfT72dqop3zzGHuPiQP+Qx1bgglO/B1OnI2yi0pRqXLyFVDI25g7E9fH Oa4oN2k+nB6Szei5yv+nttvkc3EVqFUlFYsrWRzaKTS/YKh9G/q+z5mH2y9zFoaI1RWS moUwg7ceH5NPY4xXp3kXjCLVHdeNctrNutGJWqTB6PuwaG3jPLWtl2qvzzd+2Zq+bOdb XHPA== X-Gm-Message-State: AOJu0Yz3i4eHXv+yXm2lwmvUgKIgt21Guy/gS7LS69jeL1W4KarrJBbN ZHKB0ywvTDsndZUXcjSqzQem8srW7T1vEDKmNLz7uLj7HK5mCce92unMLHdYWi4hn5c6UIbgiPK S X-Gm-Gg: ASbGncupIQGVyIIfNvmRaato4F/ZjjQDke4cC7L0CbqFqTKf+9Qwj3anCk8ZYnxjVFU R8a5pxWh4NlsqXC4PMFuX4u1IXOr59QR7y+V/fzmDc7jbrLGcLSLSF5adfIVtak53C+V1f9b4at lRTanBURNd1kS/0LowZzWukmpI+90RdtUDWc8Jhqs53zEASRO7HirEoH+GRDbDXJ1v9UgvwNP9b 6m/5L0kF4l9facujgohx6xwyqFvtoT1OZb62R98/csghV0j0IzyMMe1tTeWdBCue3sSP8GzF/PK 7IvdE3MjCaC5zEOggkatWb/2YCw= X-Google-Smtp-Source: AGHT+IEwANibH5WHVdavr3T6zSqw5iLDYZk0Iu/s40vuuezk4fZHZUvDn9XVUp/JcqLwDcOM97HQLA== X-Received: by 2002:a17:903:41c8:b0:215:7f94:2d0 with SMTP id d9443c01a7336-215d0053d3emr101947855ad.29.1733350702432; Wed, 04 Dec 2024 14:18:22 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7254180fc80sm12864550b3a.151.2024.12.04.14.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 14:18:22 -0800 (PST) Date: Wed, 4 Dec 2024 14:18:19 -0800 From: Stephen Hemminger To: dev@dpdk.org Cc: ivan.ilchenko@oktetlabs.ru Subject: Re: [RFC 5/5] net/sfc: fix handling of xstats_get queries Message-ID: <20241204141819.289da66c@hermes.local> In-Reply-To: <20241008160209.68000-6-stephen@networkplumber.org> References: <20241008160209.68000-1-stephen@networkplumber.org> <20241008160209.68000-6-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 08:59:59 -0700 Stephen Hemminger wrote: > The xstats_get function in this driver did not act the same > as other drivers when queried. The correct check is to look > at the requested number of stats and compare it to the available > stats and if the request is too small, return the correct size. > > Fixes: fdd7719eb3c1 ("net/sfc: add xstats for Rx/Tx doorbells") > Cc: ivan.ilchenko@oktetlabs.ru > Signed-off-by: Stephen Hemminger Could someone with Solarflare hardware test this please?