From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C01CE45E33; Wed, 4 Dec 2024 23:19:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A274B402AF; Wed, 4 Dec 2024 23:19:07 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 6DC064029B for ; Wed, 4 Dec 2024 23:19:06 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21578cfad81so2033795ad.3 for ; Wed, 04 Dec 2024 14:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733350745; x=1733955545; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=u6gzBsGvzh/IkFfOlB3IVMvweUMSdDIZptxacjujqus=; b=CnzPTgmPoMr3423BTG+5aWFI0ZK4Ki7CMY8xlOtoRQLsZ30rJ19wivn0/X8FwW3NW2 XQWQMOFjNyFE+ppNRXKPSoOr8oSMYzpB4Wziwi/sEPdtUswPj4C8fqqCP8B6BWYNBZN0 +sn1LTD4YJINJdvKfMwXkEsWoWUd13r+yBoYtjYFTSUMwCaisvYsYuE0CV5QxX7GiD/T 7sCjgNbpzG8H/pNc9cah/x7hHvRRDCYvCq4ichgapEHbEdoJ8xrRUSx5gATVb4D3cGXJ T4s+dVq1V3LNxhkbm1M7zR7PAq8d2WCHvpPMUudLYANv+VmvQ0AnY+lWOOYWUGb4ihcS it8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733350745; x=1733955545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u6gzBsGvzh/IkFfOlB3IVMvweUMSdDIZptxacjujqus=; b=xUfjyWmxP2lnOU8g/EbbmOG/4tUuykC7uoSqRSJZ3AmPrPJYiHg8gONm7OQ1LhdK4v pl6Ifmg1wBreU0Va8KnQbQbbqrb9iZ4htVT8CFGSN0cJkpdZRXXwZV7IsMFQjjkjuPvr 8uLe1pPwMC+xsieCL080cDrGmX7dEPE8jg/wVSzTPd+H2Dx9CZHiuJnxwPqtOLO6VI/x zn5B1n3yg59LY714B14oItC4TTwE61r0DuHN6MdRJS/qtYhiC4czPZHAz9fDOe8/eEDW /5sgUMGDy5M7psaYQ3De2DQtjj4AECA6ZlNpJ+c9srkzNmFIIB3Hdj/ruforB9WjnJpG PtJQ== X-Gm-Message-State: AOJu0Yx7yBU/s0pPDRACJqldGpQJtCZ0V/mRfREzeDRkKR7Yo/sjyMEZ bKxRitiOcYufSn0x9aqBuTs8dBWmaQ26JKtS11I96kJvA0b2VX++NhuGanq9Qs9Gc8bA6zqS7Jf i X-Gm-Gg: ASbGncsBdaTgdq0YziQB4dPutb4pnl9KBDF7CCQ9MLXBHiU5SSE+uyeBpWMQ+jbAfEF 6pFWx+qvYpgpB8E8V13A5UjUvC6eNAeAbj3XLSoNPN1WAWBXE6aaZ63kmsVRGTSbB8rkbkyAYqa KegfWBuCUdXd+y1PKUesWWifKc9dFIeK8tGm7lpdwjegcKcH5/VbgjYgAC+P0IMocsttYo7oJMI LwQKGnPNeAyHOitAv5ynF28jcpzHGl8nmt3svcG6Kmd9H1EWMGyAUjXOnoCbRTS26cArWK87CAT 7QRgujpiM3IbC8hV75A0Q/H26Fg= X-Google-Smtp-Source: AGHT+IGg4/jA0KXmzn9zm085klmGKBRwdFomIqJDUWY5RyuRsAAkZPaqFq+Zt+05NGX3nCdwTd2J/w== X-Received: by 2002:a17:902:e881:b0:215:a434:b6ad with SMTP id d9443c01a7336-215bd20195emr97028045ad.33.1733350745546; Wed, 04 Dec 2024 14:19:05 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215f8ef9f66sm302745ad.115.2024.12.04.14.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 14:19:05 -0800 (PST) Date: Wed, 4 Dec 2024 14:19:03 -0800 From: Stephen Hemminger To: dev@dpdk.org Cc: jiawenwu@trustnetic.com Subject: Re: [RFC 2/5] net/ngbe: fix query handling in xstats_get Message-ID: <20241204141903.2a2c3f2d@hermes.local> In-Reply-To: <20241008160209.68000-3-stephen@networkplumber.org> References: <20241008160209.68000-1-stephen@networkplumber.org> <20241008160209.68000-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 08:59:56 -0700 Stephen Hemminger wrote: > The xstats_get function in this driver did not act the same > as other drivers when queried. The correct check is to look > at the requested number of stats and compare it to the available > stats and if the request is too small, return the correct size. > > Bugzilla ID: 1560 > Fixes: 8b433d04adc9 ("net/ngbe: support device xstats") > Cc: jiawenwu@trustnetic.com > > Signed-off-by: Stephen Hemminger This needs to be tested on this hardware before merging.