From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 22C5D45E33;
	Thu,  5 Dec 2024 01:51:06 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E5E8F41149;
	Thu,  5 Dec 2024 01:51:05 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 654D24111C
 for <dev@dpdk.org>; Thu,  5 Dec 2024 01:51:03 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 8C5D520CECB2; Wed,  4 Dec 2024 16:51:02 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8C5D520CECB2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1733359862;
 bh=KDuQE1DbMk7JkzryUFOH/1vwOCD/H9ACaM5Wc/Emo+8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=bMHie6D5JX1BIRoNOaCul6qX9gZs7SQ+zkQIdGNb67abAwiUf8V8c7/kj8879wT/5
 lVD8eGb8Og3/E4sy2ImeOmjFirlUz34Dnt6aCyJbnTCN2WsMCrYD7TzhA3BCfFjo9C
 rnCd9RYpfmpSj+cYuRQ60RcdbWDzU7z5TcTlRtsU=
Date: Wed, 4 Dec 2024 16:51:02 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com,
 bruce.richardson@intel.com, byron.marohn@intel.com,
 conor.walsh@intel.com, cristian.dumitrescu@intel.com,
 david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com,
 gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com,
 kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru,
 matan@nvidia.com, orika@nvidia.com, radu.nicolau@intel.com,
 ruifeng.wang@arm.com, sameh.gobriel@intel.com,
 sivaprasad.tummala@amd.com, skori@marvell.com,
 stephen@networkplumber.org, suanmingm@nvidia.com,
 vattunuru@marvell.com, viacheslavo@nvidia.com,
 vladimir.medvedkin@intel.com, yipeng1.wang@intel.com
Subject: Re: [PATCH v6 13/30] drivers/mempool: replace packed attributes
Message-ID: <20241205005102.GA8256@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
 <1732668761-5556-1-git-send-email-andremue@linux.microsoft.com>
 <1732668761-5556-14-git-send-email-andremue@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1732668761-5556-14-git-send-email-andremue@linux.microsoft.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Nov 26, 2024 at 04:52:24PM -0800, Andre Muezerie wrote:
> MSVC struct packing is not compatible with GCC. Replace macro
> __rte_packed with __rte_packed_begin to push existing pack value
> and set packing to 1-byte and macro __rte_packed_end to restore
> the pack value prior to the push.
> 
> Macro __rte_packed_end is deliberately utilized to trigger a
> MSVC compiler warning if no existing packing has been pushed allowing
> easy identification of locations where the __rte_packed_begin is
> missing.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>