DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Wencheng Li <liwencheng@phytium.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 5/6] net/macb: fix tab errors in meson.build file
Date: Tue, 10 Dec 2024 11:46:29 -0800	[thread overview]
Message-ID: <20241210114629.48ed048c@hermes.local> (raw)
In-Reply-To: <1733814515-412204-1-git-send-email-liwencheng@phytium.com.cn>

On Tue, 10 Dec 2024 07:08:35 +0000
Wencheng Li <liwencheng@phytium.com.cn> wrote:

> Replace tabs with spaces to resolve indentation
> issues in meson.build file.
> 
> Fixes: 97fd6a929cf8 ("net/macb: add new driver")
> Cc: liwencheng@phytium.com.cn
> 
> Signed-off-by: Wencheng Li <liwencheng@phytium.com.cn>

Since this is a new driver, please fix this in the earlier patch that
adds it rather than including a fixup patch. You can do this with
git rebase and squashing the patches.

Each patch in a new driver should be clean of basic stuff like
whitespace, bad flags, etc. And after each patch the build should
be clean.

  reply	other threads:[~2024-12-10 19:46 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01 10:07 [PATCH v1 1/2] net/macb: add new driver liwencheng
2024-11-01 10:07 ` [PATCH v1 2/2] /usertools/dpdk-devbind:add the binding and unbinding of platform device liwencheng
2024-11-05  8:43   ` [PATCH v2 3/3] usertools/dpdk-devbind: add platform device bind/unbind liwencheng
2024-11-06  3:34     ` [PATCH v2 3/3] usertools/dpdk-devbind: add bind/unbind for platform device liwencheng
2024-11-11  7:43       ` liwencheng
2024-12-03  8:15         ` [PATCH][v2, " Wencheng Li
2024-11-06  3:55   ` [PATCH v1 2/2] /usertools/dpdk-devbind:add the binding and unbinding of " Stephen Hemminger
2024-11-12  1:08     ` liwencheng
2024-11-01 16:13 ` [PATCH v1 1/2] net/macb: add new driver Stephen Hemminger
2024-11-01 17:42 ` Stephen Hemminger
2024-11-02  5:43 ` Stephen Hemminger
2024-11-05  8:41 ` [PATCH v2 1/3] " liwencheng
2024-11-05  8:41   ` [PATCH v2 2/3] net/macb: add NEON vectorized Rx/Tx liwencheng
2024-11-06  3:33     ` liwencheng
2024-11-11  7:42       ` liwencheng
2024-12-06  8:08         ` [PATCH v3 " Wencheng Li
2024-12-10  7:05         ` [PATCH v3 2/6] " Wencheng Li
2024-12-10  7:07         ` [PATCH v3 3/6] net/macb: fix logic error in macb_rxq_rearm function Wencheng Li
2024-11-06  3:32   ` [PATCH v2 1/3] net/macb: add new driver liwencheng
2024-11-11  7:42     ` liwencheng
2024-12-06  8:06       ` [PATCH v3 " Wencheng Li
2024-12-10  7:04       ` [PATCH v3 1/6] " Wencheng Li
2024-12-10  7:07       ` [PATCH v3 4/6] net/macb: zero ol_flags in each recv function Wencheng Li
2024-12-10  7:08       ` [PATCH v3 5/6] net/macb: fix tab errors in meson.build file Wencheng Li
2024-12-10 19:46         ` Stephen Hemminger [this message]
2024-12-02 20:31     ` [PATCH v2 1/3] net/macb: add new driver Stephen Hemminger
2024-11-22 17:55   ` Stephen Hemminger
2024-11-22 20:38   ` Stephen Hemminger
2024-11-22 20:44   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210114629.48ed048c@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=liwencheng@phytium.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).