From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD4BA45E6D; Tue, 10 Dec 2024 20:46:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68DA64026E; Tue, 10 Dec 2024 20:46:34 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id B00724026A for ; Tue, 10 Dec 2024 20:46:32 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ef714374c0so3391152a91.0 for ; Tue, 10 Dec 2024 11:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733859991; x=1734464791; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7XGPlrRnhsJyM4BT+/EKo1hNb+Yiho1aekTkF0nbD8c=; b=fTw9Tax+pNj7/O3bnICPBgE+G5doI//ZKhgEmlIxzS6D4JjKR36mecN9WX5TRoH3HI MNpENEE8sfN8RyaFt9W+aEVqRN+BGiy9YIAlorgkOkZcUkTSoDXlgzrRqJIoLDr6vxUD vNzDflK9B9RAkqPK0ed2lJOIas8J6wR7SrldpA4KNFC5Ntyaj3F2oU3ENJZyFJKPqHyl 6uDjVhu3XuVLs1ne8MlGKn02Txmgx/McMOp/P6vhOQHgUOUa5tiVEvQPFVKCvRc/WUdM ++TqN1G02ji8S4pdAuxyOgj0Om/pFHcS1kDtJv4J2t6ajyZqKUdyzIyiry6u1cAEpddW mljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733859991; x=1734464791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7XGPlrRnhsJyM4BT+/EKo1hNb+Yiho1aekTkF0nbD8c=; b=h3rpyqZ49sZBNT/WaCvvu+oxJQnu6H4RWBfzEJmPSrSH1eNLwvcxBzUpL3ONhK7DPS XjIZRawowm8bPmHJjmQNbnGqQQao4d0glGekqlL5Zyj99LR+zKkLPNlgekH0ZaykAz9B zs73cjMyU6NGVWAu08SY/NbDq/7PcHk7/JJs/UPEi0/nofIC6iS4KGY1pD4XBwS1I2Nb m7OP6rTp8P+y7MHwqWSrX30zQqT8xWvHiuIjG1aQxFEYniwjacasGNc78uISLDlepqIc BHXbzLJMJ6C3D/ruBEc3LT/RYXevmc7b1bXoLvxp9mzJLXj/LhhPwXR+ieslwG0CAlCs fpUQ== X-Gm-Message-State: AOJu0YwuH3291U1/ltbmj3d64wuZN++1VD/walBBWTOHuhIVA+MJ8xU4 TcjRw3AFgc3pILcwcxmwjPUWvGtO32dN/uL2mCkpy2CCCmyrqZHw1pWeuc1+C6ZD6KhnzhCq5Sp 2 X-Gm-Gg: ASbGncvov67+w62m4wr0QAPEY50ErylPCWMXbeeU0QoESJ4RZR/Yz/5RKIjxuX9Tp0J dqYo+Np94aVImOovuv4i1A8psezZBhObbF9WkeqrKQokxp+vGD5x1ngrlBe3/jbTL5oGO7NnTEP eP+z0n+JFrOmp9ThpD4QloitZMTYtZyzASMco6LJlYiGWxzc8okRTtRfpBkvHSmRbp+6vrrf1sx B2D/vSuknf1NBRAJRfo4iQWyQ0t3fJ/riZsAtSWhpL1987XnLPD5I09PPll4VcrGjosAFEqSpGg YDG5FEJ8jkCJoIuBe4F8UegpW+Sc26g= X-Google-Smtp-Source: AGHT+IFdY+YW7zvUUfMdGxDOfzoOZuZzrp65gR+iJVw4iQca5wmmJJTSiPS6yxvq/jyAar9ylJdkkQ== X-Received: by 2002:a17:90a:f990:b0:2ef:949c:6f6b with SMTP id 98e67ed59e1d1-2f12880e2f3mr485a91.13.1733859991538; Tue, 10 Dec 2024 11:46:31 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fd48c5216fsm4433247a12.77.2024.12.10.11.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 11:46:31 -0800 (PST) Date: Tue, 10 Dec 2024 11:46:29 -0800 From: Stephen Hemminger To: Wencheng Li Cc: dev@dpdk.org Subject: Re: [PATCH v3 5/6] net/macb: fix tab errors in meson.build file Message-ID: <20241210114629.48ed048c@hermes.local> In-Reply-To: <1733814515-412204-1-git-send-email-liwencheng@phytium.com.cn> References: <1731310932-1743343-1-git-send-email-liwencheng@phytium.com.cn> <1733814515-412204-1-git-send-email-liwencheng@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Dec 2024 07:08:35 +0000 Wencheng Li wrote: > Replace tabs with spaces to resolve indentation > issues in meson.build file. > > Fixes: 97fd6a929cf8 ("net/macb: add new driver") > Cc: liwencheng@phytium.com.cn > > Signed-off-by: Wencheng Li Since this is a new driver, please fix this in the earlier patch that adds it rather than including a fixup patch. You can do this with git rebase and squashing the patches. Each patch in a new driver should be clean of basic stuff like whitespace, bad flags, etc. And after each patch the build should be clean.