DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "lihuisong (C)" <lihuisong@huawei.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>, Chas Williams <chas3@att.com>,
	"Min Hu (Connor)" <humin29@huawei.com>,
	Chengwen Feng <fengchengwen@huawei.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>
Subject: Re: [PATCH] test/bonding: fix active backup rx test
Date: Fri, 13 Dec 2024 08:56:00 -0800	[thread overview]
Message-ID: <20241213085545.30b86af1@hermes.local> (raw)
In-Reply-To: <8e824f6a-b271-1b2d-9a27-aed5cd27cb8f@huawei.com>

On Fri, 13 Dec 2024 14:57:23 +0800
"lihuisong (C)" <lihuisong@huawei.com> wrote:

> Hi Stephen,
> 
> This patch looks good to me.
> 
> But this test case still runs failure when I run "link_bonding_autotest" 
> twice. like:
> -->  
> ...
> EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure 
> for port 7 failed
> EAL: Test assert initialize_bonding_device_with_members line 1138 
> failed: Failed to configure bonding port (7) in mode 3 with (4) members.
> EAL: Test assert 
> test_broadcast_verify_member_link_status_change_behaviour line 4060 
> failed: Failed to initialise bonding device
>   + TestCase [62] : 
> test_broadcast_verify_member_link_status_change_behaviour failed
> ETHDEV: Invalid port_id=7
> EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure 
> for port 7 failed
> EAL: Test assert test_reconfigure_bonding_device line 4162 failed: 
> failed to reconfigure bonding device
>   + TestCase [63] : test_reconfigure_bonding_device failed
> ETHDEV: Invalid port_id=7
>   + TestCase [64] : test_close_bonding_device succeeded
> ETHDEV: Invalid port_id=7
> EAL: Test assert remove_members_and_stop_bonding_device line 659 failed: 
> Failed to stop bonding port 7
>   + ------------------------------------------------------- +
>   + Test Suite Summary : Link Bonding Unit Test Suite
>   + ------------------------------------------------------- +
>   + Tests Total :       65
>   + Tests Skipped :      0
>   + Tests Executed :    65
>   + Tests Unsupported:   0
>   + Tests Passed :       5
>   + Tests Failed :      60
>   + ------------------------------------------------------- +
> Test Failed
> 
> 
> I guess the bonding use case needs to close all bonding devices.


The test has lots of issues that would make it bad to run twice.
Like leaking mbufs, etc.
But these always existed and will leave that to bonding maintainers to fix.

  reply	other threads:[~2024-12-13 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  1:51 Stephen Hemminger
2024-12-13  6:57 ` lihuisong (C)
2024-12-13 16:56   ` Stephen Hemminger [this message]
2024-12-16  1:50     ` lihuisong (C)
2024-12-13 17:17 ` [PATCH v2] " Stephen Hemminger
2024-12-16  1:53   ` lihuisong (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213085545.30b86af1@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=humin29@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).