From: Yang Ming <ming.1.yang@nokia-sbell.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org, Yang Ming <ming.1.yang@nokia-sbell.com>
Subject: [PATCH 2/2] net/mlx5: improve log file path
Date: Fri, 13 Dec 2024 17:24:43 +0800 [thread overview]
Message-ID: <20241213092444.2987-2-ming.1.yang@nokia-sbell.com> (raw)
In-Reply-To: <20241213092444.2987-1-ming.1.yang@nokia-sbell.com>
1. /var/log is hard code which is not a good coding style.
2. /var/log may be not allowed to be written via container's
read-only mode.
Signed-off-by: Yang Ming <ming.1.yang@nokia-sbell.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index eadadcdffb..a0da73c9c3 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -12,6 +12,7 @@
#include <rte_prefetch.h>
#include <rte_common.h>
#include <rte_branch_prediction.h>
+#include <rte_eal.h>
#include <rte_ether.h>
#include <rte_cycles.h>
#include <rte_flow.h>
@@ -311,7 +312,7 @@ mlx5_set_swp_types_table(void)
}
}
-#define MLX5_SYSTEM_LOG_DIR "/var/log"
+#define MLX5_SYSTEM_LOG_DIR rte_eal_get_runtime_dir()
/**
* Dump debug information to log file.
*
--
2.34.1
next prev parent reply other threads:[~2024-12-13 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:24 [PATCH 1/2] net/mlx5: improve socket " Yang Ming
2024-12-13 9:24 ` Yang Ming [this message]
2024-12-13 17:12 ` Stephen Hemminger
2024-12-13 17:16 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213092444.2987-2-ming.1.yang@nokia-sbell.com \
--to=ming.1.yang@nokia-sbell.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).