From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B0545E94; Fri, 13 Dec 2024 22:05:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1250B40E11; Fri, 13 Dec 2024 22:05:53 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 39E9840E0F for ; Fri, 13 Dec 2024 22:05:52 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-723f37dd76cso1806804b3a.0 for ; Fri, 13 Dec 2024 13:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734123951; x=1734728751; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=s5N4w3ClrBN7CWCrdY+Z/sGaIdb/BKdTtA8P9jF+FWk=; b=MM6BCaAg50WYMHzgSoNWmWbhne1DuGJlXRuOcWiuJWZujVNXCjOeDSdHfL4TrfKSCE 9shJOok4XU8l6AwXctf4YiLxAKa9s/LLqtgrf5/7RCkNUrvbQ+qT6iiMA55pvJO0HaXJ 5Glcit4U26CFtENnP7LxuOxhux4sfF5EqrHi6Hwx2g8/Zl3amRCDWexgvpufcS5q933t YnZrT8tq73BA7F2dmCD4/X5bdunDfu1Tu/NNd2d+FbbROgHaRUGKiGEtXGn/hA8mOO42 D1pcM+9de1ev0Lex3OTL7Q1C0KoyHjuJWICj0MH8DvZx0uzFvLnqbpeBsZMjZUCDyLPe jWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734123951; x=1734728751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s5N4w3ClrBN7CWCrdY+Z/sGaIdb/BKdTtA8P9jF+FWk=; b=O9VmCgjXM6zUa8q/scpWs541Cj72V7bc6otc0gjYOHCrZLtvctvluHbKGRsRnXcgi2 IWHz9SIfBfrNYu25q8XWJq/IRYAXOprIwr/nrghfoDPkn2RWR82Qo9qfEDFGHy9LNZXu qPVw7mXLAdQcssxXJoMflpZZI/tEmKE0yQW3xcWzBRlBIxMCtLURjXVTSI2gIYc8nQba 06jmfbZflG/1nOFC7GgAtnubPhq/0VsNZAsCGjSBZfqYjck12n0jygYfWMbni+camt5o 3UE3P/gxH3bK4McH67WDZyG8KwtbIHCeAF4K8uCPkLgw9wx0bTLH05f/2o2L6ZiZNMWK l31Q== X-Forwarded-Encrypted: i=1; AJvYcCU/BAwlWebthW1mPYlhsG47IWxTzUHLZPrz9EQ2zgnIhbB/9wfzH3sRErqdFMmaLLSVDjc=@dpdk.org X-Gm-Message-State: AOJu0YzPKMHgL3MhGLH/w2b57XCtqDFmwhZMncR7O8FYTDap9gnotytp 7HR3hGsgObfSu6XfebW2pkLN6EE/VN4gRZS7Gqsnw6QEwSNMeDjicT1794y77B8= X-Gm-Gg: ASbGnctd+8NgK00i64CY67DhyZ/o/NaPnzl7gIhKXGMACa39v4mGeBfcBtYs7jLtNHE AYDkSXyIeGHv7xXyCAO5eTom/3TJ6PP/bwiMwRg4FrRgnyaTBtmBNf1LlKEY/9iipDJ13SJEDcb LgfUWyPsQPakFDhmItZApML+1WmpmwM4//ZbWMn4YEvI+4YkvclYgFJXtKvQUYoLu/klNCb9ko1 RJGfgKncxafwlskhLn7D33OVWXcfwcoXpqkj3IWzi60VrjqyuWLVutUxTSj2Hw8Q938eavV7q3w wDc4puDuF7Yi38iC+J9pGITTJ4zsJXl/vQ== X-Google-Smtp-Source: AGHT+IGt7kXdlYKuqg4CZmbXJkQlLGCl20mAtdgDQOPUAtw8MS1PUrRi2lVALp4Ys1EY8aBlr7kWog== X-Received: by 2002:a05:6a00:ad0e:b0:729:643:744f with SMTP id d2e1a72fcca58-7290c27477emr6231372b3a.25.1734123951372; Fri, 13 Dec 2024 13:05:51 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72918bc020csm210583b3a.178.2024.12.13.13.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 13:05:51 -0800 (PST) Date: Fri, 13 Dec 2024 11:41:24 -0800 From: Stephen Hemminger To: Junlong Wang Cc: ferruh.yigit@amd.com, dev@dpdk.org Subject: Re: [PATCH v2 02/15] net/zxdh: zxdh np uninit implementation Message-ID: <20241213114124.1331bc14@hermes.local> In-Reply-To: <20241210055333.782901-3-wang.junlong1@zte.com.cn> References: <20241206055715.506961-2-wang.junlong1@zte.com.cn> <20241210055333.782901-1-wang.junlong1@zte.com.cn> <20241210055333.782901-3-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Dec 2024 13:53:20 +0800 Junlong Wang wrote: > diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c > index 9c50039fb1..454252cffc 100644 > --- a/drivers/net/zxdh/zxdh_np.c > +++ b/drivers/net/zxdh/zxdh_np.c > @@ -12,15 +12,26 @@ > #include "zxdh_logs.h" > > static uint64_t g_np_bar_offset; > -static ZXDH_DEV_MGR_T g_dev_mgr = {0}; > -static ZXDH_SDT_MGR_T g_sdt_mgr = {0}; > +static ZXDH_DEV_MGR_T g_dev_mgr; > +static ZXDH_SDT_MGR_T g_sdt_mgr; > ZXDH_PPU_CLS_BITMAP_T g_ppu_cls_bit_map[ZXDH_DEV_CHANNEL_MAX]; > ZXDH_DTB_MGR_T *p_dpp_dtb_mgr[ZXDH_DEV_CHANNEL_MAX] = {NULL}; > +ZXDH_RISCV_DTB_MGR *p_riscv_dtb_queue_mgr[ZXDH_DEV_CHANNEL_MAX] = {NULL}; > +ZXDH_TLB_MGR_T *g_p_dpp_tlb_mgr[ZXDH_DEV_CHANNEL_MAX] = {NULL} Don't think you to initialize these to NULL since in C global variables get initialized to 0 automatically.