Re: [PATCH] app/test: fix stack overflow in lpm6_perf_autotest

[Andre Muezerie <andremue@linux.microsoft.com>]

On Fri, Dec 13, 2024 at 10:22:20AM +0000, Medvedkin, Vladimir wrote:
> Hi Andre,
> 
> On 13/12/2024 02:39, Andre Muezerie wrote:
> >Test lpm6_perf_autotest was hitting a stack overflow on Windows
> >with both MSVC and Clang.
> >
> >The fix is to move some of the data from the stack to the heap.
> >
> >Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> >---
> >  app/test/test_lpm6_perf.c | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> >
> >diff --git a/app/test/test_lpm6_perf.c b/app/test/test_lpm6_perf.c
> >index 1860a99ed6..8231ad825d 100644
> >--- a/app/test/test_lpm6_perf.c
> >+++ b/app/test/test_lpm6_perf.c
> >@@ -117,8 +117,12 @@ test_lpm6_perf(void)
> >  	total_time = 0;
> >  	count = 0;
> >-	struct rte_ipv6_addr ip_batch[NUM_IPS_ENTRIES];
> >-	int32_t next_hops[NUM_IPS_ENTRIES];
> >+	struct rte_ipv6_addr *ip_batch = (struct rte_ipv6_addr *)malloc(
> why not rte_malloc?

For no good reason :-)
I'll update the patch.
Thanks for the suggestion.

Andre Muezerie

> >+			sizeof(struct rte_ipv6_addr) * NUM_IPS_ENTRIES);
> >+	TEST_LPM_ASSERT(ip_batch != NULL);
> >+
> >+	int32_t *next_hops = (int32_t *)malloc(sizeof(int32_t) * NUM_IPS_ENTRIES);
> >+	TEST_LPM_ASSERT(next_hops != NULL);
> >  	for (i = 0; i < NUM_IPS_ENTRIES; i++)
> >  		ip_batch[i] = large_ips_table[i].ip;
> >@@ -153,6 +157,9 @@ test_lpm6_perf(void)
> >  	printf("Average LPM Delete: %g cycles\n",
> >  			(double)total_time / NUM_ROUTE_ENTRIES);
> >+	free(next_hops);
> >+	free(ip_batch);
> >+
> >  	rte_lpm6_delete_all(lpm);
> >  	rte_lpm6_free(lpm);
> 
> -- 
> Regards,
> Vladimir