From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF1F945EC2; Mon, 16 Dec 2024 19:58:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A176D4025F; Mon, 16 Dec 2024 19:58:16 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 2C82640144 for ; Mon, 16 Dec 2024 19:58:15 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-8019338c2b2so2911815a12.3 for ; Mon, 16 Dec 2024 10:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734375494; x=1734980294; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yPhCsU0rMHV95J2c1FhwtpLrjvHd4VHiT7MptfMG2rA=; b=nUpV/nn4yt9obeaRB8lguVBgdnmN9rysmzBgNAU/cXsTDuh26MKgtAluiLNe3E9H+1 akAHYhLWgxPCkhK7vX2Ujtpt8ztK2Gd7CGY3bIsVM23q3c3YZ9EwAShPlDZ+NJE3oCJ3 2tO8Uusbgd/y/HFmUeaWD3AdyyGNOLIWnXwOv8h+/APUWicuOlmyJES6zQUz4OF9AgBg YEdzfZMKK6NwpuC6Mw74s1DkQacMuGdWHpbYE5rbzo3bhAGoNMfyECdMtpckVn7RESQn 6kEhNlrU6+bB3IoTax3cjsV/CyRIu8kGI1Hq1KkkmwnN9ZWxQxiJKTCOSwKuu+N7tbsA poDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734375494; x=1734980294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPhCsU0rMHV95J2c1FhwtpLrjvHd4VHiT7MptfMG2rA=; b=KdoRcDmm6+JI46NNLZ68lh/pZL/w/vwLPhRfsfRF+oSptfw5tz2g+gcZO5Q8AVqR6C mL5i6VYXW6pkL/2kK09zsHCsYmZIRrW59XBB/rVNjHxCd7+8AVRsBiSxF9OOsN32A0IV zridyxFC+ueFCxWEJDhAQnXmJaoIUm6ewdwcs76cVfVOXY/0qpXeWZ0J1DadvqBKRWUA pblKFpoCb1iLFJf6poJiX5JJ1mA/DYN/OxAPcHVoor3+aLq2y0wLdhIBnfGKMv+IsBko iwMi+wSgAa4Cw4pwI79fhHHvj1rtLt4yosJ4tbROXxdR8nnQ2bp+ank7GKU7mj11Z24X aclA== X-Gm-Message-State: AOJu0YxRuTMLb0OB4ZiRl2TnUqcgvRPNEeT9KXxlCG1hJa5MjqveOZXW FLsJwEXa3zApE5R9RwDXuiVwUtxFPCGrXXFRzLX2rvemN5reVmr32orcZnbA9KE= X-Gm-Gg: ASbGncuHWUSLzhNNmDMsk5V7WspzmTQyzaAhNzUzVyObHchWBPqqSXkRgtm2pDyL2a/ bEwySyznYl5HsdiaJi9Na65M6A8qm4wp/ib8ivIBMh/iCQ9FlBReRn1IZC7u5o6F1YxaSimkZZs lNE9UHChbnIK5g6v1crdPoJl769K00ceGHTKJ0Xe9cy+GokNhI0MSF++w5jctRQ8zpBK840/iue Usa7depMdHNDdPgd62PTQkp4fVbXCh1lA9uXTTWm5OQYd6K05aqr7JkQTxxn72DfRTBDf8WsqYi GBRwdQZytNMp2D5QKJGFX+AmSC24CrPiwA== X-Google-Smtp-Source: AGHT+IHtbvQRcir/2b07y8DVqlrAfuiMKlcVfDobGkb3gngmoQK/B7LDg1UasRq/KhExYbSRYSljEQ== X-Received: by 2002:a17:90b:2790:b0:2ee:f22a:61dd with SMTP id 98e67ed59e1d1-2f290dbce31mr18169144a91.32.1734375494241; Mon, 16 Dec 2024 10:58:14 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e6d5f4sm45797255ad.267.2024.12.16.10.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 10:58:14 -0800 (PST) Date: Mon, 16 Dec 2024 10:58:12 -0800 From: Stephen Hemminger To: Andrew Rybchenko Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit Subject: Re: [PATCH v2 1/5] ethdev: check that device supports deferred start Message-ID: <20241216105812.28dc5a9b@hermes.local> In-Reply-To: <9c5a3e1e-a1b7-4f3f-96f5-674031de6e15@oktetlabs.ru> References: <20241213214929.817688-1-stephen@networkplumber.org> <20241214180843.6662-1-stephen@networkplumber.org> <20241214180843.6662-2-stephen@networkplumber.org> <9c5a3e1e-a1b7-4f3f-96f5-674031de6e15@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 15 Dec 2024 11:56:55 +0300 Andrew Rybchenko wrote: > On 12/14/24 21:07, Stephen Hemminger wrote: > > The check for supporting deferred start should be handled at > > the ethdev level for all devices. > > It is a good idea to check it on ethdev level. > > Strictly speaking presence of queue start/stop callback does not mean > support for deferred start right now. It is possible to use stop/start > without deferred start feature. Right, there are drivers that define the callback but have no logic in place to do deferred start. They just ignore the flag. Drivers with this odditiy are: ark, atlantic, cxgbe, enic, hinic, ipn3ke, nfb, nfp, ntnic This patch set won't change that. There are also some drivers which claim to support queue start/stop in the documentation, but there is no functions: virtio, mana, netvsc, mlx4, vmxnet3 Will fix that in next version of this series. > > However, such check is much better than nothing since deferred start > definitely requires queue start callback. > > It would be good to clarify it in the documentation. > doc/guides/nics/features.rst does not mention deferred start at all. > In fact, I don't mind to couple deferred start to queue start/stop > features. It is a bug that the drivers that do queue start/stop and don't implement deferred start. There is no hardware reason to not support it, just missing feature during driver development. > > One nit below. > > Anyway: > Acked-by: Andrew Rybchenko