From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: dev@dpdk.org
Subject: [PATCH] net/sfc: avoid duplicate configuration restore
Date: Mon, 16 Dec 2024 14:11:41 +0300 [thread overview]
Message-ID: <20241216111141.1578426-1-andrew.rybchenko@oktetlabs.ru> (raw)
MAC address, promiscuous and all-multicast modes are restored correctly
upon device start by the PMD itself. ethdev layer should not duplicate it.
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
drivers/net/sfc/sfc_ethdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 89444f0b4a..82fbdbae9c 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -2722,6 +2722,14 @@ sfc_fec_set(struct rte_eth_dev *dev, uint32_t fec_capa)
return -rc;
}
+static uint64_t
+sfc_get_restore_flags(__rte_unused struct rte_eth_dev *dev,
+ __rte_unused enum rte_eth_dev_operation op)
+{
+ /* sfc PMD does not require any configuration restore */
+ return 0;
+}
+
static const struct eth_dev_ops sfc_eth_dev_ops = {
.dev_configure = sfc_dev_configure,
.dev_start = sfc_dev_start,
@@ -2774,6 +2782,7 @@ static const struct eth_dev_ops sfc_eth_dev_ops = {
.fec_get_capability = sfc_fec_get_capability,
.fec_get = sfc_fec_get,
.fec_set = sfc_fec_set,
+ .get_restore_flags = sfc_get_restore_flags,
};
struct sfc_ethdev_init_data {
--
2.39.5
reply other threads:[~2024-12-16 11:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216111141.1578426-1-andrew.rybchenko@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).