* [PATCH v1] event/dlb2: add port attribute for independent enqueue
@ 2024-12-13 4:33 pravin.pathak
2024-12-13 6:46 ` Mattias Rönnblom
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: pravin.pathak @ 2024-12-13 4:33 UTC (permalink / raw)
To: dev
Cc: jerinj, mike.ximing.chen, bruce.richardson, thomas,
david.marchand, tirthendu.sarkar, Pravin Pathak
From: Pravin Pathak <pravin.pathak@intel.com>
Independent Enqueue support is added to DPDK 24.11
Adding the attribute rte_event_port_attr_get() was missing
This commit adds it to retrieve port attributes
Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
---
lib/eventdev/rte_eventdev.c | 8 ++++++++
lib/eventdev/rte_eventdev.h | 6 ++++++
2 files changed, 14 insertions(+)
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index ca295c87c4..61cff87b63 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -880,6 +880,14 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id,
*attr_value = !!(config & RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);
break;
}
+ case RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ:
+ {
+ uint32_t config;
+
+ config = dev->data->ports_cfg[port_id].event_port_cfg;
+ *attr_value = !!(config & RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ);
+ break;
+ }
default:
return -EINVAL;
};
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index fabd1490db..4089c493a7 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1318,6 +1318,12 @@ rte_event_port_quiesce(uint8_t dev_id, uint8_t port_id,
* Port attribute id for the implicit release disable attribute of the port.
*/
#define RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE 3
+/**
+ * Port attribute indicating it supports independent enqueue. i.e. enqueue order
+ * is independent of dequeue order for all forwarded events.
+ *
+ */
+#define RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ 4
/**
* Get an attribute from a port.
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] event/dlb2: add port attribute for independent enqueue
2024-12-13 4:33 [PATCH v1] event/dlb2: add port attribute for independent enqueue pravin.pathak
@ 2024-12-13 6:46 ` Mattias Rönnblom
2024-12-13 7:19 ` Thomas Monjalon
2024-12-16 20:33 ` [PATCH v2] eventdev: " pravin.pathak
2 siblings, 0 replies; 4+ messages in thread
From: Mattias Rönnblom @ 2024-12-13 6:46 UTC (permalink / raw)
To: pravin.pathak, dev
Cc: jerinj, mike.ximing.chen, bruce.richardson, thomas,
david.marchand, tirthendu.sarkar
On 2024-12-13 05:33, pravin.pathak@intel.com wrote:
> From: Pravin Pathak <pravin.pathak@intel.com>
>
> Independent Enqueue support is added to DPDK 24.11
"."
> Adding the attribute rte_event_port_attr_get() was missing
There is something wrong with that sentence.
"Add the corresponding rte_event_port_attr_get() attribute, which was
missing."
> This commit adds it to retrieve port attributes
>
> Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
> ---
> lib/eventdev/rte_eventdev.c | 8 ++++++++
> lib/eventdev/rte_eventdev.h | 6 ++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index ca295c87c4..61cff87b63 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -880,6 +880,14 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id,
> *attr_value = !!(config & RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);
> break;
> }
> + case RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ:
> + {
> + uint32_t config;
> +
> + config = dev->data->ports_cfg[port_id].event_port_cfg;
> + *attr_value = !!(config & RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ);
> + break;
> + }
> default:
> return -EINVAL;
> };
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index fabd1490db..4089c493a7 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -1318,6 +1318,12 @@ rte_event_port_quiesce(uint8_t dev_id, uint8_t port_id,
> * Port attribute id for the implicit release disable attribute of the port.
> */
> #define RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE 3
> +/**
> + * Port attribute indicating it supports independent enqueue. i.e. enqueue order
> + * is independent of dequeue order for all forwarded events.
Maybe it's better not to make any attempts to explain what independent
enqueue is, here?
> + *
> + */
> +#define RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ 4
>
> /**
> * Get an attribute from a port.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] event/dlb2: add port attribute for independent enqueue
2024-12-13 4:33 [PATCH v1] event/dlb2: add port attribute for independent enqueue pravin.pathak
2024-12-13 6:46 ` Mattias Rönnblom
@ 2024-12-13 7:19 ` Thomas Monjalon
2024-12-16 20:33 ` [PATCH v2] eventdev: " pravin.pathak
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2024-12-13 7:19 UTC (permalink / raw)
To: pravin.pathak
Cc: dev, jerinj, mike.ximing.chen, bruce.richardson, david.marchand,
tirthendu.sarkar, Pravin Pathak
13/12/2024 05:33, pravin.pathak@intel.com:
> From: Pravin Pathak <pravin.pathak@intel.com>
>
> Independent Enqueue support is added to DPDK 24.11
> Adding the attribute rte_event_port_attr_get() was missing
> This commit adds it to retrieve port attributes
>
> Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
The title mentions dlb2 but the change is generic.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] eventdev: add port attribute for independent enqueue
2024-12-13 4:33 [PATCH v1] event/dlb2: add port attribute for independent enqueue pravin.pathak
2024-12-13 6:46 ` Mattias Rönnblom
2024-12-13 7:19 ` Thomas Monjalon
@ 2024-12-16 20:33 ` pravin.pathak
2 siblings, 0 replies; 4+ messages in thread
From: pravin.pathak @ 2024-12-16 20:33 UTC (permalink / raw)
To: dev
Cc: jerinj, mike.ximing.chen, bruce.richardson, thomas,
david.marchand, tirthendu.sarkar, pravin.pathak
From: Pravin Pathak <pravin.pathak@intel.com>
Independent Enqueue support is added to DPDK 24.11.
Adding support for RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ attribute
to rte_event_port_attr_get() which was missing
Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
---
lib/eventdev/rte_eventdev.c | 8 ++++++++
lib/eventdev/rte_eventdev.h | 4 ++++
2 files changed, 12 insertions(+)
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index ca295c87c4..61cff87b63 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -880,6 +880,14 @@ rte_event_port_attr_get(uint8_t dev_id, uint8_t port_id, uint32_t attr_id,
*attr_value = !!(config & RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL);
break;
}
+ case RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ:
+ {
+ uint32_t config;
+
+ config = dev->data->ports_cfg[port_id].event_port_cfg;
+ *attr_value = !!(config & RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ);
+ break;
+ }
default:
return -EINVAL;
};
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index fabd1490db..6400d6109f 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1318,6 +1318,10 @@ rte_event_port_quiesce(uint8_t dev_id, uint8_t port_id,
* Port attribute id for the implicit release disable attribute of the port.
*/
#define RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE 3
+/**
+ * Port attribute id for the Independent Enqueue feature.
+ */
+#define RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ 4
/**
* Get an attribute from a port.
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-16 20:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-13 4:33 [PATCH v1] event/dlb2: add port attribute for independent enqueue pravin.pathak
2024-12-13 6:46 ` Mattias Rönnblom
2024-12-13 7:19 ` Thomas Monjalon
2024-12-16 20:33 ` [PATCH v2] eventdev: " pravin.pathak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).