From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E734645ECD; Tue, 17 Dec 2024 10:00:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAD804064C; Tue, 17 Dec 2024 10:00:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BEFED402A3 for ; Tue, 17 Dec 2024 10:00:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734426015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bPu85FBB9BVfSPe8M1goL2fqf7HlKy5GNOjs/4Dy5ho=; b=Y++M4Taso0e1HIfEp7xV/GIv4WNyPzOwxf2tQAUrf5erViYXu/OfvRGcTfPDb8uEsI4o+W rP0ktqlrB3UHkyivw6fG0TKiGw5ft0/mXgaYYW5RHK/gaJmRGJHEBd7rXPhjO1wd1w6dQp iJC4BAvVNhnV5myqwdOSJmNXDggAdZI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-F0GB9hUYNc63sgFOxTGZTg-1; Tue, 17 Dec 2024 04:00:09 -0500 X-MC-Unique: F0GB9hUYNc63sgFOxTGZTg-1 X-Mimecast-MFC-AGG-ID: F0GB9hUYNc63sgFOxTGZTg Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 010291955F3B; Tue, 17 Dec 2024 09:00:08 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.167]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6D26D1955F41; Tue, 17 Dec 2024 09:00:05 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, frode.nordahl@canonical.com, mattias.ronnblom@ericsson.com, anatoly.burakov@intel.com, Tyler Retzlaff Subject: [PATCH v2 1/5] eal: check lcore variable handle Date: Tue, 17 Dec 2024 09:59:48 +0100 Message-ID: <20241217085954.3310414-2-david.marchand@redhat.com> In-Reply-To: <20241217085954.3310414-1-david.marchand@redhat.com> References: <20241205175754.1673888-1-david.marchand@redhat.com> <20241217085954.3310414-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g8n1OGZ9DvzV6gN59rj0ZPyQ1ZcdXc6vIzCKo1f6Yaw_1734426008 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add an assert to double check the passed handle is not NULL, as it points at an initialisation/allocation issue prior to accessing this lcore variable. Signed-off-by: David Marchand --- lib/eal/include/rte_lcore_var.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/rte_lcore_var.h b/lib/eal/include/rte_lcore_var.h index 0216a67cab..ca31dff6fd 100644 --- a/lib/eal/include/rte_lcore_var.h +++ b/lib/eal/include/rte_lcore_var.h @@ -24,6 +24,7 @@ #include #include +#include #include #ifdef __cplusplus @@ -125,6 +126,7 @@ extern "C" { static inline void * rte_lcore_var_lcore(unsigned int lcore_id, void *handle) { + RTE_ASSERT(handle != NULL); return RTE_PTR_ADD(handle, lcore_id * RTE_MAX_LCORE_VAR); } /* >8 end of access function */ -- 2.47.0