From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: bruce.richardson@intel.com, dev@dpdk.org, vladimir.medvedkin@intel.com
Subject: Re: [PATCH v2] app/test: fix stack overflow in lpm6_perf_autotest
Date: Wed, 18 Dec 2024 07:12:06 -0800 [thread overview]
Message-ID: <20241218151206.GA25758@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20241213091540.68294d17@hermes.local>
On Fri, Dec 13, 2024 at 09:15:40AM -0800, Stephen Hemminger wrote:
> On Fri, 13 Dec 2024 09:08:22 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
>
> > + struct rte_ipv6_addr *ip_batch =
> > + (struct rte_ipv6_addr *)rte_malloc("ip_batch",
> > + sizeof(struct rte_ipv6_addr) * NUM_IPS_ENTRIES, 0
>
> Cast is not needed here.
> If you are going to allocate an array, use calloc() or rte_calloc()
Thanks for the comments. I'll update the patch.
next prev parent reply other threads:[~2024-12-18 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 2:39 [PATCH] " Andre Muezerie
2024-12-13 10:22 ` Medvedkin, Vladimir
2024-12-13 17:05 ` Andre Muezerie
2024-12-13 17:08 ` Stephen Hemminger
2024-12-13 17:08 ` [PATCH v2] " Andre Muezerie
2024-12-13 17:15 ` Stephen Hemminger
2024-12-18 15:12 ` Andre Muezerie [this message]
2024-12-18 15:21 ` [PATCH v3] " Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218151206.GA25758@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).