From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E09AC45EE5; Thu, 19 Dec 2024 04:51:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F10D40144; Thu, 19 Dec 2024 04:51:45 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id CC99C400EF for ; Thu, 19 Dec 2024 04:51:43 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-725dbdf380aso258348b3a.3 for ; Wed, 18 Dec 2024 19:51:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734580303; x=1735185103; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ACDWQWiCh97/f9RkgFpRyfjhQ/JkkfLqs6l08flFhDo=; b=G21DXxMerg88xK1IjY5yXV7w0U41nvTCPANMaRElmjyTqHTJUVe4suv6DVtXyL7EAv IBeFYya5sfmcpTC05Fp/WNhUv7V7vQ83D6vlacogoeiT1kiyFKoFAZwPH/NjUhatN+jf vUhhpS72TJWMIqpCWwiVBL6+giCY2ncfGnMdTcDdet2v5EDhQnHb+VXAhmev0iAvD72z e/yicJp+2JPBo67dPWDus949V/nmD6XgweydTcm6/P3SxBZiGKhpxhU+7OXy8Gs9EA5G XqRDl7ppZgpVm/VEwmqG0w9ThzOKc78vUKFindBE9TEoY19o2arObBZt8/KamzOlvcc7 IhOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734580303; x=1735185103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ACDWQWiCh97/f9RkgFpRyfjhQ/JkkfLqs6l08flFhDo=; b=ehZL9VZOR4WCXzdqeG/CvncwOBxwacB1CrP9sIVAZ7aHT4sx6kS85XecqBdcQR7OPx VE4PpuiK0BuxvYneGLf8KYsmdNrGXz4jYKMXJUateBaHm/R41GGPPFcGC8pUJAPu+GX4 6G2m1WbdQTctF+oYqsoDeg4iO0R9qUl3n+xiJRSoO4iefuRm/9bbP1cxCovJRVDBoNEA PVw3x7MsrL1FrFmapfDYBHTLaSbJOrbyG/Px99HO6rXJrC9WfHRQWujDsKftJ8QwoT0O CdyjszepFCev1E0FB+Sm+rKlG0ED2OB1tpUlr22M1DwJbT3xBRluzrZ/mkSoSrsMtKOS erLw== X-Forwarded-Encrypted: i=1; AJvYcCW032bDUH4ZKn/sANxsjTU9hdX4EXm9xXSryCIpWU5C5szT3mRHYrJD3R0pCxs6RDhwp4o=@dpdk.org X-Gm-Message-State: AOJu0YzzBUqG6T/A9kJ9/QV2vQDFxw8Ja/buB6iasXpiVqkPsAV68LKH dYfGZbfAf/XM9bpdnY+Ju7z047jmqE1WMPRpYn38fqgd5yatRsb6lHqwRXU9eZ4= X-Gm-Gg: ASbGncu+fUvI0Gpc/H4RYBQ+ETup7AbkF5vhHxhgtqaHrT/z2H416bbFqwehk3g7nWV FlBnIB6CJnXGpzBo9N8hIxO8F+roxvOrtzvWaPLtD+pMXgKS7+ZvzFDN9yBE9wMsqOO1VL1DgdA cqLt7AszOP8FJch1IKF7uCwnrnyf5H2S4a5QfgBI1WBF/DMX3rZV1HbnNnn4Flk2D7qK4vFB0lW Jm2Z02adYmj1bYHp8S1znvr9txHxkvCHnSDQXuk3VboGyAvuRHAOlBOnX/yezXR+wnxQx1tXmIb StVU1x+bzoBS+Mq9YAbjZwzwypkauk3dCg== X-Google-Smtp-Source: AGHT+IEbIyhaomlaWC+biUYH12lkzRRT0ntKge+ormCQClS7leDlCvXWKc2cNZKn4W9K+aeNm8+p2w== X-Received: by 2002:a05:6a21:7884:b0:1e1:f281:8cfd with SMTP id adf61e73a8af0-1e5c762fb55mr2789422637.15.1734580302803; Wed, 18 Dec 2024 19:51:42 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b8e87deasm213515a12.45.2024.12.18.19.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 19:51:42 -0800 (PST) Date: Wed, 18 Dec 2024 19:51:40 -0800 From: Stephen Hemminger To: Joshua Washington Cc: Jeroen de Borst , Rushil Gupta , dev@dpdk.org, Ferruh Yigit , Praveen Kaligineedi , Praveen Kaligineedi Subject: Re: [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails Message-ID: <20241218195140.60a1f58b@hermes.local> In-Reply-To: <20241218234635.2009033-1-joshwash@google.com> References: <20241218234635.2009033-1-joshwash@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 18 Dec 2024 15:46:35 -0800 Joshua Washington wrote: > From: Praveen Kaligineedi > > Allocating QPL for an RX queue might fail if enough contiguous IOVA > memory cannot be allocated. However, the only requirement for QPL > for RX is that each 4K buffer be IOVA contiguous, not the entire > QPL. Therefore, use malloc to allocate 4K buffers if the allocation > using memzone fails. > > Signed-off-by: Praveen Kaligineedi > Reviewed-by: Joshua Washington > --- Why keep the memzone code? rte_malloc and memzone are both coming from huge pages. Is there any advantage to memzone for what you are doing? Better to not have two potential allocation paths to test.