From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E89EB45EF0; Thu, 19 Dec 2024 23:34:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8202940265; Thu, 19 Dec 2024 23:34:33 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 033D84025F for ; Thu, 19 Dec 2024 23:34:31 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-728eccf836bso1179209b3a.1 for ; Thu, 19 Dec 2024 14:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734647671; x=1735252471; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=n4v8I7paJ1Eiz65Z9uvBi38bscFRbXAPOggeeaZOaqU=; b=ZJRcxLOVhHYRvYlIE9XnWemQF6RUWPZq8G1cEOM50g+N6tYjEjgZNd/BPH2yi4v91B I+2dg4/ZrEGjOK+lvhvqhpJxcrBwidsf/O8zTGm4sj1LpTbuyKGjEdSJpdmva/9TE7UB RgaW7T7zRj0zPFKH8VniblR6estDcEZ2U32WKXLuGXMCXUb5EKa5H0YEs1y8nUvWa8kw wnJmln4k/+8lY2T8FrOe8zmWPpu35UxH0OPHTq0Z+J+GwuSKfNQi19u/uQJaA6GmGQ84 kQVyjpOWN7hX7AwDxQ1Whg806TOTJEAVWBS/QpkiLbeJqno5iTop3ybFAuSyydAFdWhb 4GQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734647671; x=1735252471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n4v8I7paJ1Eiz65Z9uvBi38bscFRbXAPOggeeaZOaqU=; b=U7lsyEmdaadz3T45sNLPjFPTCjYtrvJNPVDMMlZiNvnXwGOsyysA6rNr2OMoy3WzMd kA1/V8yj332y4Kx0NRxfmeowMtfgI0O4nY8h5+lxUI9EJoR4/Qo1BWKHttGHTAG/k0G0 +sbkTx5a7n2BBTVXGuIahGwRghyF0nzJCbYIA/DEDA1of3LOLmw8KPm9ZYHVKx2mVY3N XhKvTyuOdXedDaO5euQz8rqqVJUz6/7797XGcJDo10QECjtfdDSNu2WoU/fJkJPkpRp+ dvnsMRbqMoxN8dwnikXtXlPUTI3t3bPB4aI4hvTgv/VbZV3AV+Q4An7vsgkErzgj6I3q CFjQ== X-Forwarded-Encrypted: i=1; AJvYcCX0MTfcjAe73XqLODyODghJTh5f0XBLKfUdXaNv3TxsBALx/AJ71e4pCAHFcheRTgFbP2E=@dpdk.org X-Gm-Message-State: AOJu0YzMWHBfuUw4Cb6KQhJYpTmQBpNBtf9d+0VaXxK6TGHjlSAPhFLC a7Z3dPr/BD4Jq9bNhKZbBwrUJxm6OFTQLFuI0bvgzZXnfiMan6ptx3S/dSUIujo= X-Gm-Gg: ASbGncsvVIuejqHv56wngyXMcL+qpdlNVBytvlmyyXK9IGrAMGh5gmFHcHL0kO+eZDb hYr4f5YI4kTFEooIVwggKawQ8SszNjc7bLzmU1O0dnpUETp3gBFy348GGQilQ8YfcTW1DmKGVn1 /STS5xjFvATm++dn26QWEFN+pztQZ0PnxCO2KeON6EZ6bp2FgxVUGspHDqgqAsA4vwHLR03MIE3 0/h9QwJypDfvB2VpHXWSZ0GSCtQb0VClYGWwR8+c1oUvnLkzuhsT+JLb6zwkmlahYdg4d0jce4o 6CibgJI9sFCKkNLwtMAuW4yE0UPORD+a6w== X-Google-Smtp-Source: AGHT+IFCYXjGvRVnc3NP7Icp9NAjpTmsnN+sL1Oa6A2dYUxfdwMVfpN1piwcoDteAd560jZzx9gHjA== X-Received: by 2002:a05:6a21:3116:b0:1e1:abd6:ca66 with SMTP id adf61e73a8af0-1e5e049f46dmr1432391637.24.1734647670797; Thu, 19 Dec 2024 14:34:30 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dd1a8sm1892601b3a.106.2024.12.19.14.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 14:34:30 -0800 (PST) Date: Thu, 19 Dec 2024 14:34:28 -0800 From: Stephen Hemminger To: Praveen Kaligineedi Cc: Joshua Washington , Jeroen de Borst , Rushil Gupta , dev@dpdk.org, Ferruh Yigit , Praveen Kaligineedi Subject: Re: [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails Message-ID: <20241219143428.0c3e5b6f@hermes.local> In-Reply-To: References: <20241218234635.2009033-1-joshwash@google.com> <20241218195140.60a1f58b@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 19 Dec 2024 12:53:14 -0800 Praveen Kaligineedi wrote: > The TX queue requires IOVA contiguous QPL memory. So, we still need > memzone code for TX queues. >=20 > Regards, > Praveen >=20 > On Wed, Dec 18, 2024 at 7:51=E2=80=AFPM Stephen Hemminger > wrote: > > > > On Wed, 18 Dec 2024 15:46:35 -0800 > > Joshua Washington wrote: > > =20 > > > From: Praveen Kaligineedi > > > > > > Allocating QPL for an RX queue might fail if enough contiguous IOVA > > > memory cannot be allocated. However, the only requirement for QPL > > > for RX is that each 4K buffer be IOVA contiguous, not the entire > > > QPL. Therefore, use malloc to allocate 4K buffers if the allocation > > > using memzone fails. > > > > > > Signed-off-by: Praveen Kaligineedi > > > Reviewed-by: Joshua Washington > > > --- =20 > > > > Why keep the memzone code? rte_malloc and memzone are both coming from > > huge pages. Is there any advantage to memzone for what you are doing? > > > > Better to not have two potential allocation paths to test. =20 So then use rte_malloc for Rx queue and rte_memzone for Tx queue and document rationale.