From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 474D345EFA; Fri, 20 Dec 2024 17:19:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB12D40156; Fri, 20 Dec 2024 17:19:38 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 1B5E34003C for ; Fri, 20 Dec 2024 17:19:37 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-8019338c2b2so1341943a12.3 for ; Fri, 20 Dec 2024 08:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734711576; x=1735316376; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=47eKzN68uuvfuWef/naZp39hmKqiSA9qYtAbvYM3Cwk=; b=L8aovbS+0iS9OV1tBMKk7IKWue4za32jCCiMskC7MzgU7wvWrlDSNybIUAuy7M9qiA NFdG63HeCUai+fzYyQJ8LveBkpbOkb2ZcgHcTlD4o4ItxPKi6YM6oYRriCIZbzFEodcS juQwGQDAoIJ3ZD6syuy8stIR9qwyvX63LziIYkHZRWKtP+ONp+0cdn/YxM8QeXoZzxLY 0SE94ClZ1pW0pm4pwl/z5Yrf2H8seS+QeW+P6nirM8OmyAFdBHpfq420w+PwuLdnaXPP YPoj1LWqmOugFMwCNSEWKYLGPI+R2yeuOZmYNNDuNIx+M35NDV6uSJyGyvAkNcG3UNsr VkIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734711576; x=1735316376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=47eKzN68uuvfuWef/naZp39hmKqiSA9qYtAbvYM3Cwk=; b=q3Sf3UOeIlibzUxL+CaddPgwkXEeRe5OnVzWfhSY+vwioHsKn8c4jAmxmeMVQSsCKw w0VeOT9IYtsKGZUO/7hhXn934jQH3uCY9XtNGR2FeV+OBzRxHOF+RUR6XcK/8JmAN1po 2Zy0ubVYgX0xz5ljB2gxy6OpMWQvw/w7rgUyhlSDUOYGb82m4x1QDBVO/SxN+2WGs8V/ zIaF6ISAZ2Jm0ciHKG7doybf/FlEeq7vMkoDoOs07nhhHhcwiUBNJl5k9c4ogfjmMrJD tSQptkDcsgmOpLniZFJEzlCJXFEFR4idaUefJLfcwPv7v7FrXd6PsXa+72oNYWrTzU/X Rn2Q== X-Forwarded-Encrypted: i=1; AJvYcCVLYsX93GhWzxHJE3ZbKt7+9D/mpALS8/PXWbFtWKwMzdVdgMiU5w2bJycN/r29KvL+g4E=@dpdk.org X-Gm-Message-State: AOJu0YxAR9AlDUzgJZxvrnb0v8I1iXHBrvr19lC+ayFHR375uNpU9UfH 7jFXKMN7/YHhkDzuHmZfelgM9Nkl+U/Rzp6p54tIwaCKD67UpZTJjlmyZTw5Kr8= X-Gm-Gg: ASbGncuprRUNfNhTLCMa7W7J+QKpHcg13GCHi9dv6oIEIZdb0MIzYf6Hk4MauMcasxH hKiMUJiJy9UMKsXVVKfGwjF/4QgnSy68IzFupABPB08Fp7/RtgkV+ec5EyRLSvDQ4ieNG/6t2S3 B2w/XMiJ56Uu4FidwI3g3FfwlNgNtD5xCbWm5UKE2HpdUufgg/DS2plFplMd+s5jo3vdyN8XNTP zZ0xL8OTjIM8TdMG3qYk8aWCj+iADrk6/c7MsL6AmSjtL2OdJSNKdM+txQxT9Un47JwwA26qIEd 8nTs4dzFCqyR5SeJmMShTt3nw7MNLFtfVg== X-Google-Smtp-Source: AGHT+IGWaE5QV8obM0EwvFCrp5RkuuYCbsP7vK/18xatUDyrgwjHLLSq1cII9lsItSdrJGRb6DJ76w== X-Received: by 2002:a17:90a:dfc7:b0:2ee:b6c5:1def with SMTP id 98e67ed59e1d1-2f452def71bmr6372898a91.8.1734711576075; Fri, 20 Dec 2024 08:19:36 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed62cd8asm5984265a91.18.2024.12.20.08.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 08:19:35 -0800 (PST) Date: Fri, 20 Dec 2024 08:19:31 -0800 From: Stephen Hemminger To: Konstantin Ananyev Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= , "dev@dpdk.org" Subject: Re: [RFC 0/8] ioring: network driver Message-ID: <20241220081931.71ce2132@hermes.local> In-Reply-To: References: <20241210212757.83490-1-stephen@networkplumber.org> <20241211070352.6d32e332@hermes.local> <3426021bf73d4e42bbe35597976a2d85@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35E9F969@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 20 Dec 2024 14:34:27 +0000 Konstantin Ananyev wrote: > > > From: Konstantin Ananyev [mailto:konstantin.ananyev@huawei.com] > > > > > > > > > This is first draft of new simplified TAP device that uses > > > > > > the Linux kernel ioring API to provide a read/write ring > > > > > > with kernel. > > > > > > > > > > > > This is split from tap device because there are so many > > > > > > unnecessary things in existing tap, and supporting ioring is > > > > > > better without ifdefs etc. The default name of the tap > > > > > > device is different that other uses in DPDK but the driver > > > > > > tries to keep the same relevant devargs as before. > > > > > > > > > > > > This driver will only provide features that match what kernel > > > > > > does, so no flow support etc. The next version will add checksum > > > > > > and multi-segment packets. Some of the doc files may need update > > > > > > as well. > > > > > > > > > > Makes sense to me, though didn't properly look inside. > > > > > One thing - probably add a 'tap' into the name, > > > > > 'tap_ioiring' or so, otherwise 'ioring' is a bit too generic > > > > > and might be confusing. > > > > Konstantin is referring to the name of the driver and the source code file names, "net/ioring" -> "net/tap_ioring". > > Yep, that what I meant. My thoughts, are shorter name is better, and avoids confusion. There are already multiple drivers that create tap devices: tap and virtio_user. > > > > > > > > > > There are some userspaces that look for "e*" in name for some setups. > > > > Stephen is referring to the device name of an instantiated interface, e.g. "eth0". > > > > And yes, assuming devices named "e*" are Ethernet devices is a common hack in Linux applications. I've done it myself. :-) > > Ok... and why such practice should prevent us to name PMD itself in a way we think is appropriate? > I am more leaning towards not having a default name at all. The policy should be done by Linux (udev) not DPDK. If user wants a name they can add it via devargs.