DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Vizzarro <luca.vizzarro@arm.com>
To: dev@dpdk.org
Cc: Paul Szczepanek <paul.szczepanek@arm.com>,
	Patrick Robb <probb@iol.unh.edu>,
	Luca Vizzarro <luca.vizzarro@arm.com>
Subject: [RFC PATCH 0/2] dts: add basic scope to improve shell handling
Date: Fri, 20 Dec 2024 17:23:37 +0000	[thread overview]
Message-ID: <20241220172337.2194523-1-luca.vizzarro@arm.com> (raw)

Hi there,

To try to improve the ease of use of the framework for the test
developer, I have been trying to come up with a decent solution to
improve shell handling and consistency. At the moment we have 2 patterns
to do this, which could be confusing to the user.

It probably is that a good approach, which is what I am proposing, is to
introduce a scoping mechanism in DTS. What this would mean is to
associate any shells or modification to different scopes: global test
suite and individual test cases.

Here's an RFC for this, please have a look. Looking forward to your
feedback!

This could be massively improved, but it'd require a lot more changes.
One idea that I think is worth pursuing is turning the execution into a
FSM.

Best,
Luca

Luca Vizzarro (2):
  dts: add scoping and shell registration to Node
  dts: revert back shell split

 dts/framework/remote_session/dpdk_shell.py    |   8 +-
 .../remote_session/interactive_shell.py       | 262 +++++++++++++++--
 .../single_active_interactive_shell.py        | 266 ------------------
 dts/framework/remote_session/testpmd_shell.py |   4 +-
 dts/framework/runner.py                       |  15 +-
 dts/framework/testbed_model/capability.py     |  35 ++-
 dts/framework/testbed_model/node.py           |  65 ++++-
 dts/framework/testbed_model/sut_node.py       |  14 +-
 dts/tests/TestSuite_blocklist.py              |  16 +-
 dts/tests/TestSuite_checksum_offload.py       | 168 +++++------
 dts/tests/TestSuite_dynamic_queue_conf.py     |  52 ++--
 dts/tests/TestSuite_l2fwd.py                  |  20 +-
 dts/tests/TestSuite_mac_filter.py             | 124 ++++----
 dts/tests/TestSuite_pmd_buffer_scatter.py     |  26 +-
 dts/tests/TestSuite_smoke_tests.py            |   4 +-
 dts/tests/TestSuite_vlan.py                   |  42 +--
 16 files changed, 575 insertions(+), 546 deletions(-)
 delete mode 100644 dts/framework/remote_session/single_active_interactive_shell.py

-- 
2.43.0


             reply	other threads:[~2024-12-20 17:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 17:23 Luca Vizzarro [this message]
2024-12-20 17:24 ` [RFC PATCH 1/2] dts: add scoping and shell registration to Node Luca Vizzarro
2024-12-20 17:24 ` [RFC PATCH 2/2] dts: revert back shell split Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241220172337.2194523-1-luca.vizzarro@arm.com \
    --to=luca.vizzarro@arm.com \
    --cc=dev@dpdk.org \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).