From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D72EB45EFC; Fri, 20 Dec 2024 18:23:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70F9540156; Fri, 20 Dec 2024 18:23:49 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 508434003C for ; Fri, 20 Dec 2024 18:23:48 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A63EF1480; Fri, 20 Dec 2024 09:24:15 -0800 (PST) Received: from localhost.localdomain (unknown [10.57.61.169]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B52153F720; Fri, 20 Dec 2024 09:23:46 -0800 (PST) From: Luca Vizzarro To: dev@dpdk.org Cc: Paul Szczepanek , Patrick Robb , Luca Vizzarro Subject: [RFC PATCH 0/2] dts: add basic scope to improve shell handling Date: Fri, 20 Dec 2024 17:23:37 +0000 Message-ID: <20241220172337.2194523-1-luca.vizzarro@arm.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi there, To try to improve the ease of use of the framework for the test developer, I have been trying to come up with a decent solution to improve shell handling and consistency. At the moment we have 2 patterns to do this, which could be confusing to the user. It probably is that a good approach, which is what I am proposing, is to introduce a scoping mechanism in DTS. What this would mean is to associate any shells or modification to different scopes: global test suite and individual test cases. Here's an RFC for this, please have a look. Looking forward to your feedback! This could be massively improved, but it'd require a lot more changes. One idea that I think is worth pursuing is turning the execution into a FSM. Best, Luca Luca Vizzarro (2): dts: add scoping and shell registration to Node dts: revert back shell split dts/framework/remote_session/dpdk_shell.py | 8 +- .../remote_session/interactive_shell.py | 262 +++++++++++++++-- .../single_active_interactive_shell.py | 266 ------------------ dts/framework/remote_session/testpmd_shell.py | 4 +- dts/framework/runner.py | 15 +- dts/framework/testbed_model/capability.py | 35 ++- dts/framework/testbed_model/node.py | 65 ++++- dts/framework/testbed_model/sut_node.py | 14 +- dts/tests/TestSuite_blocklist.py | 16 +- dts/tests/TestSuite_checksum_offload.py | 168 +++++------ dts/tests/TestSuite_dynamic_queue_conf.py | 52 ++-- dts/tests/TestSuite_l2fwd.py | 20 +- dts/tests/TestSuite_mac_filter.py | 124 ++++---- dts/tests/TestSuite_pmd_buffer_scatter.py | 26 +- dts/tests/TestSuite_smoke_tests.py | 4 +- dts/tests/TestSuite_vlan.py | 42 +-- 16 files changed, 575 insertions(+), 546 deletions(-) delete mode 100644 dts/framework/remote_session/single_active_interactive_shell.py -- 2.43.0