DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ariel Otilibili <otilibil@eurecom.fr>
To: dev@dpdk.org
Cc: stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	Ariel Otilibili <otilibil@eurecom.fr>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>
Subject: [PATCH v4 11/11] {common,net}/cnxk: remove unused plt_bitmap_free()
Date: Sun, 22 Dec 2024 13:49:31 +0100	[thread overview]
Message-ID: <20241222125725.1532157-12-otilibil@eurecom.fr> (raw)
In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr>

Depends on commits:
* 13844f8557 ("common/cnxk: remove unused plt_bitmap_free()")
* d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()").

Fixes: f752780f30 ("common/cnxk: add ROC MACsec initialization")
Fixes: bea5d990a9 ("net/cnxk: support outbound soft expiry notification")
Fixes: 05d727e8b1 ("common/cnxk: support NIX traffic management")
Fixes: 124ff1a4cb ("common/cnxk: support NPA device")
Fixes: 357f5ebc8a ("common/cnxk: support flow aging")
Fixes: 7eabd6c637 ("net/cnxk: support inline security setup for cn9k")
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
Cc: stable@dpdk.org
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Kiran Kumar K <kirankumark@marvell.com>
Cc: Sunil Kumar Kori <skori@marvell.com>
Cc: Satha Rao <skoteshwar@marvell.com>
Cc: Harman Kalra <hkalra@marvell.com>
---
 drivers/common/cnxk/roc_mcs.c         | 4 ----
 drivers/common/cnxk/roc_nix_inl_dev.c | 2 --
 drivers/common/cnxk/roc_nix_tm.c      | 5 -----
 drivers/common/cnxk/roc_npa.c         | 4 ----
 drivers/common/cnxk/roc_npc_aging.c   | 1 -
 drivers/net/cnxk/cnxk_ethdev.c        | 1 -
 6 files changed, 17 deletions(-)

diff --git a/drivers/common/cnxk/roc_mcs.c b/drivers/common/cnxk/roc_mcs.c
index f823f7f478..4df3b2ff92 100644
--- a/drivers/common/cnxk/roc_mcs.c
+++ b/drivers/common/cnxk/roc_mcs.c
@@ -719,13 +719,9 @@ mcs_alloc_bmap(uint16_t entries, void **mem, struct plt_bitmap **bmap)
 static void
 rsrc_bmap_free(struct mcs_rsrc *rsrc)
 {
-	plt_bitmap_free(rsrc->tcam_bmap);
 	plt_free(rsrc->tcam_bmap_mem);
-	plt_bitmap_free(rsrc->secy_bmap);
 	plt_free(rsrc->secy_bmap_mem);
-	plt_bitmap_free(rsrc->sc_bmap);
 	plt_free(rsrc->sc_bmap_mem);
-	plt_bitmap_free(rsrc->sa_bmap);
 	plt_free(rsrc->sa_bmap_mem);
 }
 
diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c
index ffe6eef81f..d2b5aa5bab 100644
--- a/drivers/common/cnxk/roc_nix_inl_dev.c
+++ b/drivers/common/cnxk/roc_nix_inl_dev.c
@@ -837,7 +837,6 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *inl_dev)
 	rc = plt_thread_create_control(&inl_dev->soft_exp_poll_thread,
 			"outb-poll", nix_inl_outb_poll_thread, inl_dev);
 	if (rc) {
-		plt_bitmap_free(inl_dev->soft_exp_ring_bmap);
 		plt_free(inl_dev->soft_exp_ring_bmap_mem);
 	}
 
@@ -1069,7 +1068,6 @@ roc_nix_inl_dev_fini(struct roc_nix_inl_dev *roc_inl_dev)
 	if (inl_dev->set_soft_exp_poll) {
 		soft_exp_poll_thread_exit = true;
 		plt_thread_join(inl_dev->soft_exp_poll_thread, NULL);
-		plt_bitmap_free(inl_dev->soft_exp_ring_bmap);
 		plt_free(inl_dev->soft_exp_ring_bmap_mem);
 		plt_free(inl_dev->sa_soft_exp_ring);
 	}
diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c
index abfe80978b..f8b14acb16 100644
--- a/drivers/common/cnxk/roc_nix_tm.c
+++ b/drivers/common/cnxk/roc_nix_tm.c
@@ -2030,11 +2030,6 @@ void
 nix_tm_conf_fini(struct roc_nix *roc_nix)
 {
 	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
-	uint16_t hw_lvl;
 
-	for (hw_lvl = 0; hw_lvl < NIX_TXSCH_LVL_CNT; hw_lvl++) {
-		plt_bitmap_free(nix->schq_bmp[hw_lvl]);
-		plt_bitmap_free(nix->schq_contig_bmp[hw_lvl]);
-	}
 	plt_free(nix->schq_bmp_mem);
 }
diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
index a33f9a8499..9ec010119b 100644
--- a/drivers/common/cnxk/roc_npa.c
+++ b/drivers/common/cnxk/roc_npa.c
@@ -1227,7 +1227,6 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox)
 	lf->npa_qint_mem = plt_zmalloc(sizeof(struct npa_qint) * nr_pools, 0);
 	if (lf->npa_qint_mem == NULL) {
 		rc = NPA_ERR_ALLOC;
-		goto bmap_free;
 	}
 
 	/* Allocate memory for nap_aura_lim memory */
@@ -1256,8 +1255,6 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox)
 	plt_free(lf->aura_lim);
 qint_free:
 	plt_free(lf->npa_qint_mem);
-bmap_free:
-	plt_bitmap_free(lf->npa_bmp);
 bmap_mem_free:
 	plt_free(lf->npa_bmp_mem);
 lf_free:
@@ -1274,7 +1271,6 @@ npa_dev_fini(struct npa_lf *lf)
 
 	plt_free(lf->aura_lim);
 	plt_free(lf->npa_qint_mem);
-	plt_bitmap_free(lf->npa_bmp);
 	plt_free(lf->npa_bmp_mem);
 	plt_free(lf->aura_attr);
 
diff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_npc_aging.c
index 258c15e341..93b1bf2a47 100644
--- a/drivers/common/cnxk/roc_npc_aging.c
+++ b/drivers/common/cnxk/roc_npc_aging.c
@@ -43,7 +43,6 @@ npc_aged_flows_bitmap_free(struct roc_npc *roc_npc)
 	struct roc_npc_flow_age *flow_age;
 
 	flow_age = &roc_npc->flow_age;
-	plt_bitmap_free(flow_age->aged_flows);
 	if (flow_age->age_mem)
 		plt_free(roc_npc->flow_age.age_mem);
 }
diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index ea980a6d5e..3d30c2939f 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -311,7 +311,6 @@ nix_security_release(struct cnxk_eth_dev *dev)
 			plt_err("Failed to cleanup nix inline outb, rc=%d", rc);
 		ret |= rc;
 
-		plt_bitmap_free(dev->outb.sa_bmap);
 		plt_free(dev->outb.sa_bmap_mem);
 		dev->outb.sa_bmap = NULL;
 		dev->outb.sa_bmap_mem = NULL;
-- 
2.47.1


      parent reply	other threads:[~2024-12-22 12:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-22 12:49 [PATCH v4 00/11] devtools, lib, test, net, common: remove unused rte_bitmap_free() and plt_bitmap_free() Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 01/11] devtools/cocci, lib/eal: remove unused rte_bitmap_free() Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 02/11] app/test: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 03/11] net/sfc: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 04/11] crypto/ionic: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 05/11] net/cxgbe: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 06/11] net/mlx4: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 07/11] common/mlx5: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 08/11] net/bonding: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 09/11] net/netvsc: " Ariel Otilibili
2024-12-22 12:49 ` [PATCH v4 10/11] common/cnxk: remove unused plt_bitmap_free() Ariel Otilibili
2024-12-22 12:49 ` Ariel Otilibili [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241222125725.1532157-12-otilibil@eurecom.fr \
    --to=otilibil@eurecom.fr \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).