From: Stephen Hemminger <stephen@networkplumber.org>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] app/test-cmdline: add test to Windows build
Date: Mon, 23 Dec 2024 13:30:48 -0800 [thread overview]
Message-ID: <20241223133048.195c275b@fedora> (raw)
In-Reply-To: <1734982541-8248-1-git-send-email-andremue@linux.microsoft.com>
On Mon, 23 Dec 2024 11:35:41 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:
> From: Andre Muezerie <andremue@linux.microsoft.com>
> To:
> Cc: dev@dpdk.org, Andre Muezerie <andremue@linux.microsoft.com>
> Subject: [PATCH] app/test-cmdline: add test to Windows build
> Date: Mon, 23 Dec 2024 11:35:41 -0800
> X-Mailer: git-send-email 1.8.3.1
>
> Header termios.h was not found on Windows, which was probably the
> reason this test was originally excluded from the Windows build.
> However, ir turns out this header is not needed for this test, so it
> can be removed and then test can be added to the Windows build
> without negative consequences.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2024-12-23 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 19:35 Andre Muezerie
2024-12-23 21:30 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223133048.195c275b@fedora \
--to=stephen@networkplumber.org \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).