From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 00/14] use portable variadic macros
Date: Mon, 23 Dec 2024 07:39:48 -0800 [thread overview]
Message-ID: <20241223153948.GA8982@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8xCAQk4C-f7b1=2o=6HKASQR+y30rCZ_HNU_r3CYOO39A@mail.gmail.com>
On Mon, Dec 23, 2024 at 10:28:18AM +0100, David Marchand wrote:
> On Wed, Dec 11, 2024 at 11:07 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > Many places are using a GCC extension related to variadic macros,
> > where a name prepends the ellipsis. This results in a warning like
> > the one below when compiling the code with MSVC:
> >
> > app\test-pmd\testpmd.h(1314): error C2608:
> > invalid token '...' in macro parameter list
> >
> > Variadic macros became a standard part of the C language with C99.
> > GCC, Clang and MSVC handle them properly.
> >
> > The fix is to remove the prefix name (args... becomes ...) and use
> > __VA_ARGS__.
> >
> > v2:
> > * Removed "do { } while (0)" that was added to macros in v1. As a
> > result, the patchset is now smaller.
> >
> > Andre Muezerie (14):
> > app/test-acl: use portable variadic macros
> > app/test-eventdev: use portable variadic macros
> > app/test-mldev: use portable variadic macros
> > app/test-pmd: use portable variadic macros
> > drivers/bus: use portable variadic macros
> > drivers/common: use portable variadic macros
> > drivers/compress: use portable variadic macros
> > drivers/crypto: use portable variadic macros
> > drivers/dma: use portable variadic macros
> > drivers/event: use portable variadic macros
> > drivers/mempool: use portable variadic macros
> > drivers/net: use portable variadic macros
> > drivers/raw: use portable variadic macros
> > drivers/vdpa: use portable variadic macros
> >
> > app/test-acl/main.c | 4 +-
> > app/test-eventdev/evt_common.h | 12 ++--
> > app/test-mldev/ml_common.h | 7 ++-
> > app/test-pmd/testpmd.h | 4 +-
> > drivers/bus/cdx/cdx_logs.h | 12 ++--
> > drivers/bus/dpaa/include/fman.h | 4 +-
> > drivers/bus/dpaa/rte_dpaa_logs.h | 18 +++---
> > drivers/bus/fslmc/fslmc_logs.h | 12 ++--
> > drivers/bus/fslmc/qbman/include/compat.h | 14 ++---
> > drivers/bus/ifpga/ifpga_logs.h | 16 ++---
> > drivers/bus/uacce/uacce.c | 8 +--
> > drivers/common/dpaax/compat.h | 16 ++---
> > drivers/common/dpaax/dpaax_logs.h | 18 +++---
> > drivers/common/idpf/base/idpf_osdep.h | 8 ++-
> > drivers/compress/octeontx/otx_zip.h | 8 +--
> > drivers/compress/zlib/zlib_pmd_private.h | 12 ++--
> > drivers/crypto/caam_jr/caam_jr_log.h | 28 ++++-----
> > drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 28 ++++-----
> > drivers/crypto/dpaa_sec/dpaa_sec_log.h | 28 ++++-----
> > drivers/crypto/virtio/virtio_logs.h | 60 +++++++++----------
> > drivers/dma/dpaa/dpaa_qdma_logs.h | 24 ++++----
> > drivers/dma/dpaa2/dpaa2_qdma_logs.h | 24 ++++----
> > drivers/dma/idxd/idxd_internal.h | 8 +--
> > drivers/dma/ioat/ioat_internal.h | 8 +--
> > drivers/event/dlb2/dlb2_log.h | 8 +--
> > drivers/event/dlb2/pf/base/dlb2_osdep.h | 12 ++--
> > drivers/event/dpaa/dpaa_eventdev.h | 16 ++---
> > drivers/event/dpaa2/dpaa2_eventdev_logs.h | 12 ++--
> > drivers/event/dsw/dsw_evdev.h | 8 +--
> > drivers/event/sw/sw_evdev_log.h | 12 ++--
> > drivers/mempool/dpaa/dpaa_mempool.h | 20 +++----
> > drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 30 +++++-----
> > drivers/net/ark/ark_logs.h | 4 +-
> > drivers/net/bnxt/tf_core/cfa_tcam_mgr.h | 12 ++--
> > drivers/net/bnxt/tf_core/tfp.h | 8 +--
> > drivers/net/bnxt/tf_ulp/bnxt_tf_common.h | 4 +-
> > drivers/net/dpaa/dpaa_ethdev.h | 16 ++---
> > drivers/net/dpaa/fmlib/fm_ext.h | 4 +-
> > drivers/net/dpaa2/dpaa2_pmd_logs.h | 28 ++++-----
> > drivers/net/e1000/base/e1000_osdep.h | 10 ++--
> > drivers/net/ena/base/ena_plat_dpdk.h | 14 ++---
> > drivers/net/enetc/enetc_logs.h | 32 +++++-----
> > drivers/net/enetfec/enet_pmd_logs.h | 18 +++---
> > drivers/net/enic/enic_compat.h | 16 ++---
> > drivers/net/fm10k/base/fm10k_osdep.h | 10 ++--
> > drivers/net/hns3/hns3_logs.h | 20 +++----
> > drivers/net/i40e/base/i40e_osdep.h | 2 +-
> > drivers/net/ice/base/ice_osdep.h | 4 +-
> > drivers/net/igc/base/igc_osdep.h | 10 ++--
> > drivers/net/ipn3ke/ipn3ke_logs.h | 16 ++---
> > drivers/net/ixgbe/base/ixgbe_osdep.h | 30 +++++-----
> > drivers/net/ngbe/base/ngbe_osdep.h | 2 +-
> > drivers/net/ngbe/ngbe_logs.h | 2 +-
> > drivers/net/pfe/pfe_logs.h | 18 +++---
> > drivers/net/qede/qede_ethdev.h | 4 +-
> > drivers/net/qede/qede_logs.h | 16 ++---
> > drivers/net/sfc/sfc_debug.h | 4 +-
> > drivers/net/txgbe/base/txgbe_osdep.h | 2 +-
> > drivers/net/txgbe/txgbe_logs.h | 2 +-
> > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 24 ++++----
> > drivers/raw/ifpga/base/opae_debug.h | 4 +-
> > drivers/raw/ifpga/base/opae_osdep.h | 20 +++----
> > .../raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +-
> > drivers/raw/ifpga/ifpga_rawdev.h | 16 ++---
> > drivers/raw/skeleton/skeleton_rawdev.h | 16 ++---
> > drivers/raw/skeleton/skeleton_rawdev_test.c | 8 +--
> > drivers/vdpa/ifc/base/ifcvf_osdep.h | 4 +-
> > 67 files changed, 453 insertions(+), 450 deletions(-)
>
> Thanks for the cleanup André, the series lgtm.
> Applied, thanks.
>
>
> --
> David Marchand
Thanks!
prev parent reply other threads:[~2024-12-23 15:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 2:05 [PATCH 00/21] " Andre Muezerie
2024-12-11 2:05 ` [PATCH 01/21] app/test-acl: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 02/21] app/test-eventdev: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 03/21] app/test-mldev: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 04/21] app/test-pmd: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 05/21] drivers/baseband: ensure code structure does not change Andre Muezerie
2024-12-11 2:05 ` [PATCH 06/21] drivers/bus: use portable variadic macros Andre Muezerie
2024-12-11 2:05 ` [PATCH 07/21] drivers/common: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 08/21] drivers/compress: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 09/21] drivers/crypto: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 10/21] drivers/dma: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 11/21] drivers/event: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 12/21] drivers/mempool: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 13/21] drivers/net: " Andre Muezerie
2024-12-16 9:02 ` Andrew Rybchenko
2024-12-11 2:05 ` [PATCH 14/21] drivers/raw: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 15/21] drivers/vdpa: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 16/21] lib/log: ensure code structure does not change Andre Muezerie
2024-12-11 3:13 ` Stephen Hemminger
2024-12-11 16:16 ` Andre Muezerie
2024-12-11 2:05 ` [PATCH 17/21] lib/pipeline: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 18/21] lib/port: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 19/21] lib/power: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 20/21] lib/rcu: " Andre Muezerie
2024-12-11 2:05 ` [PATCH 21/21] lib/vhost: " Andre Muezerie
2024-12-11 3:14 ` [PATCH 00/21] use portable variadic macros Stephen Hemminger
2024-12-11 21:35 ` Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 00/14] " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 01/14] app/test-acl: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 02/14] app/test-eventdev: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 03/14] app/test-mldev: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 04/14] app/test-pmd: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 05/14] drivers/bus: " Andre Muezerie
2024-12-23 8:43 ` David Marchand
2024-12-11 22:07 ` [PATCH v2 06/14] drivers/common: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 07/14] drivers/compress: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 08/14] drivers/crypto: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 09/14] drivers/dma: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 10/14] drivers/event: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 11/14] drivers/mempool: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 12/14] drivers/net: " Andre Muezerie
2024-12-11 22:07 ` [PATCH v2 13/14] drivers/raw: " Andre Muezerie
2024-12-23 8:45 ` David Marchand
2024-12-11 22:07 ` [PATCH v2 14/14] drivers/vdpa: " Andre Muezerie
2024-12-23 9:28 ` [PATCH v2 00/14] " David Marchand
2024-12-23 15:39 ` Andre Muezerie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223153948.GA8982@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=andremue@linux.microsoft.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).