From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7EA7F45F23;
Mon, 23 Dec 2024 16:39:51 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 686A54026C;
Mon, 23 Dec 2024 16:39:51 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id A7C7D40263
for <dev@dpdk.org>; Mon, 23 Dec 2024 16:39:49 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id BE763206ADC0; Mon, 23 Dec 2024 07:39:48 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BE763206ADC0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1734968388;
bh=uCdDkp7U4FgYHqZX0X+j6ilFy0z8XOwmvpTuCw1j+5w=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=VX9nlbs+qtqCq1Wr17RamZfUjMby3j24eDFDX32S4qP9i2hiwNxSKiToAM8dEJzSP
QS8y4aTyarHjfojPV1xuptvNkIWq4NmE2JfA8kW4nrI/FEELjD9KTKa/FFSu0xclQW
mYE1QIWvd8Ir3adoidEb9CZtQMwk1/cG5QdK5fn0=
Date: Mon, 23 Dec 2024 07:39:48 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 00/14] use portable variadic macros
Message-ID: <20241223153948.GA8982@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com>
<1733954844-24397-1-git-send-email-andremue@linux.microsoft.com>
<CAJFAV8xCAQk4C-f7b1=2o=6HKASQR+y30rCZ_HNU_r3CYOO39A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8xCAQk4C-f7b1=2o=6HKASQR+y30rCZ_HNU_r3CYOO39A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Dec 23, 2024 at 10:28:18AM +0100, David Marchand wrote:
> On Wed, Dec 11, 2024 at 11:07 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > Many places are using a GCC extension related to variadic macros,
> > where a name prepends the ellipsis. This results in a warning like
> > the one below when compiling the code with MSVC:
> >
> > app\test-pmd\testpmd.h(1314): error C2608:
> > invalid token '...' in macro parameter list
> >
> > Variadic macros became a standard part of the C language with C99.
> > GCC, Clang and MSVC handle them properly.
> >
> > The fix is to remove the prefix name (args... becomes ...) and use
> > __VA_ARGS__.
> >
> > v2:
> > * Removed "do { } while (0)" that was added to macros in v1. As a
> > result, the patchset is now smaller.
> >
> > Andre Muezerie (14):
> > app/test-acl: use portable variadic macros
> > app/test-eventdev: use portable variadic macros
> > app/test-mldev: use portable variadic macros
> > app/test-pmd: use portable variadic macros
> > drivers/bus: use portable variadic macros
> > drivers/common: use portable variadic macros
> > drivers/compress: use portable variadic macros
> > drivers/crypto: use portable variadic macros
> > drivers/dma: use portable variadic macros
> > drivers/event: use portable variadic macros
> > drivers/mempool: use portable variadic macros
> > drivers/net: use portable variadic macros
> > drivers/raw: use portable variadic macros
> > drivers/vdpa: use portable variadic macros
> >
> > app/test-acl/main.c | 4 +-
> > app/test-eventdev/evt_common.h | 12 ++--
> > app/test-mldev/ml_common.h | 7 ++-
> > app/test-pmd/testpmd.h | 4 +-
> > drivers/bus/cdx/cdx_logs.h | 12 ++--
> > drivers/bus/dpaa/include/fman.h | 4 +-
> > drivers/bus/dpaa/rte_dpaa_logs.h | 18 +++---
> > drivers/bus/fslmc/fslmc_logs.h | 12 ++--
> > drivers/bus/fslmc/qbman/include/compat.h | 14 ++---
> > drivers/bus/ifpga/ifpga_logs.h | 16 ++---
> > drivers/bus/uacce/uacce.c | 8 +--
> > drivers/common/dpaax/compat.h | 16 ++---
> > drivers/common/dpaax/dpaax_logs.h | 18 +++---
> > drivers/common/idpf/base/idpf_osdep.h | 8 ++-
> > drivers/compress/octeontx/otx_zip.h | 8 +--
> > drivers/compress/zlib/zlib_pmd_private.h | 12 ++--
> > drivers/crypto/caam_jr/caam_jr_log.h | 28 ++++-----
> > drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 28 ++++-----
> > drivers/crypto/dpaa_sec/dpaa_sec_log.h | 28 ++++-----
> > drivers/crypto/virtio/virtio_logs.h | 60 +++++++++----------
> > drivers/dma/dpaa/dpaa_qdma_logs.h | 24 ++++----
> > drivers/dma/dpaa2/dpaa2_qdma_logs.h | 24 ++++----
> > drivers/dma/idxd/idxd_internal.h | 8 +--
> > drivers/dma/ioat/ioat_internal.h | 8 +--
> > drivers/event/dlb2/dlb2_log.h | 8 +--
> > drivers/event/dlb2/pf/base/dlb2_osdep.h | 12 ++--
> > drivers/event/dpaa/dpaa_eventdev.h | 16 ++---
> > drivers/event/dpaa2/dpaa2_eventdev_logs.h | 12 ++--
> > drivers/event/dsw/dsw_evdev.h | 8 +--
> > drivers/event/sw/sw_evdev_log.h | 12 ++--
> > drivers/mempool/dpaa/dpaa_mempool.h | 20 +++----
> > drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 30 +++++-----
> > drivers/net/ark/ark_logs.h | 4 +-
> > drivers/net/bnxt/tf_core/cfa_tcam_mgr.h | 12 ++--
> > drivers/net/bnxt/tf_core/tfp.h | 8 +--
> > drivers/net/bnxt/tf_ulp/bnxt_tf_common.h | 4 +-
> > drivers/net/dpaa/dpaa_ethdev.h | 16 ++---
> > drivers/net/dpaa/fmlib/fm_ext.h | 4 +-
> > drivers/net/dpaa2/dpaa2_pmd_logs.h | 28 ++++-----
> > drivers/net/e1000/base/e1000_osdep.h | 10 ++--
> > drivers/net/ena/base/ena_plat_dpdk.h | 14 ++---
> > drivers/net/enetc/enetc_logs.h | 32 +++++-----
> > drivers/net/enetfec/enet_pmd_logs.h | 18 +++---
> > drivers/net/enic/enic_compat.h | 16 ++---
> > drivers/net/fm10k/base/fm10k_osdep.h | 10 ++--
> > drivers/net/hns3/hns3_logs.h | 20 +++----
> > drivers/net/i40e/base/i40e_osdep.h | 2 +-
> > drivers/net/ice/base/ice_osdep.h | 4 +-
> > drivers/net/igc/base/igc_osdep.h | 10 ++--
> > drivers/net/ipn3ke/ipn3ke_logs.h | 16 ++---
> > drivers/net/ixgbe/base/ixgbe_osdep.h | 30 +++++-----
> > drivers/net/ngbe/base/ngbe_osdep.h | 2 +-
> > drivers/net/ngbe/ngbe_logs.h | 2 +-
> > drivers/net/pfe/pfe_logs.h | 18 +++---
> > drivers/net/qede/qede_ethdev.h | 4 +-
> > drivers/net/qede/qede_logs.h | 16 ++---
> > drivers/net/sfc/sfc_debug.h | 4 +-
> > drivers/net/txgbe/base/txgbe_osdep.h | 2 +-
> > drivers/net/txgbe/txgbe_logs.h | 2 +-
> > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 24 ++++----
> > drivers/raw/ifpga/base/opae_debug.h | 4 +-
> > drivers/raw/ifpga/base/opae_osdep.h | 20 +++----
> > .../raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +-
> > drivers/raw/ifpga/ifpga_rawdev.h | 16 ++---
> > drivers/raw/skeleton/skeleton_rawdev.h | 16 ++---
> > drivers/raw/skeleton/skeleton_rawdev_test.c | 8 +--
> > drivers/vdpa/ifc/base/ifcvf_osdep.h | 4 +-
> > 67 files changed, 453 insertions(+), 450 deletions(-)
>
> Thanks for the cleanup André, the series lgtm.
> Applied, thanks.
>
>
> --
> David Marchand
Thanks!