From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 261AB45F24; Mon, 23 Dec 2024 18:37:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B72864026C; Mon, 23 Dec 2024 18:37:48 +0100 (CET) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mails.dpdk.org (Postfix) with ESMTP id 8D4A540263 for ; Mon, 23 Dec 2024 18:37:46 +0100 (CET) Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7b1601e853eso369693185a.2 for ; Mon, 23 Dec 2024 09:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1734975466; x=1735580266; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VKggKhsNQsoq1gqwBBlfJ53YdbyUet2CyuMsf2V0nC0=; b=fIyoWV4tEVyzkud9i7dQ8VIuvMwaXgsuj+zuRQ1PgQdq3et2H8IQpQpo8w6g8ZE+OP 1GMOj/WYEihbTda4/6TJ8tlxSZWWebSIb3ktYySsfrzzTttQzXmWanrZvAMh7GdEwPPm 6yRuc6V0DMMIpW3f0x0eh6zcN9nvvQhGcZ7yw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734975466; x=1735580266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VKggKhsNQsoq1gqwBBlfJ53YdbyUet2CyuMsf2V0nC0=; b=owkXK+8O76eAj+gs2vlLYJQxLcES4QEKWSQDVScyVrugkCQE4hMWcoznGVlgSxO+BY IrKn89f4SIuXE9yr67pxbF0avKVg6EkarY6r+bGiOb7jFOE2thVDToBoXco+Z1nu76Ot iCP3bRb/TiNbzW7Zht1+1e3a/CHoYh0DMut1rtz6YWE0iiGO5lcewXAp4IVnCIWed1Y5 Y7WKVMSDGxSs1P8aZL4NwSfWBxfd03a4ENHxwCBT6hG2OuTcTMaTOjY7MQHIrPlfZ8q7 qrdtJ7ty//kldVVTH7UNVaMx87BJHNzi5qkiU4eW6kLKZu6jYY/4+c0IkbR1E0nRDraN jYFA== X-Gm-Message-State: AOJu0YwSLmwTRMu2GoqTtma6YSU7ReRu7ObAVfRT7hklFA2Jca7ySNlj 6Y2PVXUDjwmOvlshwg4+Y8CkIfZjrBkaKbDjY3edWSB7SgG8zVAGcHkgSLItOKc= X-Gm-Gg: ASbGncs31QHD1u96wWMqF4i8PRlhaYl7JDiQwNNrsLQxc/1IRklipen9r3pm36lqfb5 bM3Yjgzqazanli7wUmBy35pQH0MUC+gy2tIqG6h3f2qCGL3Jn0TpFSmjXFu4BR5cGrnUqHCkGvi 7uPHr2AnoRzAVm6efoa5aGbobyHufdp3eBjupvIcchP26OYGB7wZJQDLdCGAKXWmTLQ4ukQ4h+X M1B6gm8daf21/Ss6wRF2/XSMr6hUvATq0mm2CtpCJaCAzKx2EuAw6cs8MbOESl9qwQovlJrAyUA 5q7i6H3UGhY8EhE= X-Google-Smtp-Source: AGHT+IF32967WZMmKaqp90xKEosBaRaoxvqpg8zdh397/ZtF1fEeQPfjq5RHAEhlv1FIEIm+wAPDxw== X-Received: by 2002:a05:620a:1917:b0:7b6:edc1:3d9c with SMTP id af79cd13be357-7b9ba8379d7mr1976955185a.58.1734975465864; Mon, 23 Dec 2024 09:37:45 -0800 (PST) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac4cc3ffsm399165185a.109.2024.12.23.09.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2024 09:37:45 -0800 (PST) From: Dean Marx To: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org, Dean Marx , Jeremy Spewock Subject: [PATCH v13] dts: port over queue start/stop suite Date: Mon, 23 Dec 2024 13:39:01 -0500 Message-ID: <20241223183901.20107-1-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20241217230837.27594-1-dmarx@iol.unh.edu> References: <20241217230837.27594-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. The verify argument in the deferred start method has been excluded due to a bug in testpmd, which renders checking port queue info for deferred start status impossible within a single method. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/remote_session/testpmd_shell.py | 18 +++ dts/tests/TestSuite_queue_start_stop.py | 141 ++++++++++++++++++ 2 files changed, 159 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index d187eaea94..3c5372614b 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -2242,6 +2242,24 @@ def set_queue_ring_size( f"Failed to update ring size of queue {queue_id} on port {port_id}" ) + @requires_stopped_ports + def set_queue_deferred_start( + self, port_id: int, queue_id: int, is_rx_queue: bool, on: bool + ) -> None: + """Set the deferred start attribute of the specified queue on/off. + + Args: + port_id: The port that the queue resides on. + queue_id: The ID of the queue on the port. + is_rx_queue: Whether to modify an RX or TX queue. If :data:`True` an RX queue will be + updated, otherwise a TX queue will be updated. + on: Whether to set deferred start mode on or off. If :data:`True` deferred start will + be turned on, otherwise it will be turned off. + """ + queue_type = "rxq" if is_rx_queue else "txq" + action = "on" if on else "off" + self.send_command(f"port {port_id} {queue_type} {queue_id} deferred_start {action}") + def _update_capabilities_from_flag( self, supported_capabilities: MutableSet["NicCapability"], diff --git a/dts/tests/TestSuite_queue_start_stop.py b/dts/tests/TestSuite_queue_start_stop.py new file mode 100644 index 0000000000..c391edfc87 --- /dev/null +++ b/dts/tests/TestSuite_queue_start_stop.py @@ -0,0 +1,141 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2024 University of New Hampshire + +"""Rx/Tx queue start and stop functionality suite. + +This suite tests the ability of the poll mode driver to start and +stop either the Rx or Tx queue (depending on the port) during runtime, +and verify that packets are not received when one is disabled. + +Given a paired port topology, the Rx queue will be disabled on port 0, +and the Tx queue will be disabled on port 1. + +""" + +from scapy.layers.inet import IP # type: ignore[import-untyped] +from scapy.layers.l2 import Ether # type: ignore[import-untyped] +from scapy.packet import Raw # type: ignore[import-untyped] + +from framework.remote_session.testpmd_shell import SimpleForwardingModes, TestPmdShell +from framework.test_suite import TestSuite, func_test +from framework.testbed_model.capability import NicCapability, TopologyType, requires + + +@requires(topology_type=TopologyType.two_links) +@requires(NicCapability.RUNTIME_RX_QUEUE_SETUP) +@requires(NicCapability.RUNTIME_TX_QUEUE_SETUP) +class TestQueueStartStop(TestSuite): + """DPDK Queue start/stop test suite. + + Ensures Rx/Tx queue on a port can be disabled and enabled. + Verifies packets are not received when either queue is disabled. + The suite contains four test cases, two Rx queue start/stop and + two Tx queue start/stop, which each disable the corresponding + queue and verify that packets are not received/forwarded. There + are two cases that verify deferred start mode produces the expected + behavior in both the Rx and Tx queue. + """ + + def send_packet_and_verify(self, should_receive: bool = True) -> None: + """Generate a packet, send to the DUT, and verify it is forwarded back. + + Args: + should_receive: Indicate whether the packet should be received. + """ + packet = Ether() / IP() / Raw(load="xxxxx") + received = self.send_packet_and_capture(packet) + contains_packet = any( + packet.haslayer(Raw) and b"xxxxx" in packet.load for packet in received + ) + self.verify( + should_receive == contains_packet, + f"Packet was {'dropped' if should_receive else 'received'}", + ) + + @func_test + def test_rx_queue_start_stop(self) -> None: + """Rx queue start stop test. + + Steps: + Launch testpmd, stop Rx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + stats = testpmd.show_port_stats(port_id=0) + self.verify( + stats.rx_packets == 0, + "Packets were received on Rx queue when it should've been disabled", + ) + + @func_test + def test_tx_queue_start_stop(self) -> None: + """Tx queue start stop test. + + Steps: + Launch testpmd, stop Tx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not forwarded. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + stats = testpmd.show_port_stats(port_id=1) + self.verify( + stats.tx_packets == 0, + "Packets were forwarded on Tx queue when it should've been disabled", + ) + + @func_test + def test_rx_queue_deferred_start(self) -> None: + """Rx queue deferred start stop test. + + Steps: + Launch testpmd, enable deferred start on Rx queue 0 port 0. + Stop Rx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_all_ports() + testpmd.set_queue_deferred_start(0, 0, True, True) + testpmd.start_all_ports() + testpmd.stop_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + stats = testpmd.show_port_stats(port_id=0) + self.verify( + stats.rx_packets == 0, + "Packets were received on Rx queue while deferred start was enabled", + ) + + @func_test + def test_tx_queue_deferred_start(self) -> None: + """Tx queue start stop test. + + Steps: + Launch testpmd, enable deferred start on Tx queue 0 port 0. + Stop Tx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not forwarded. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_all_ports() + testpmd.set_queue_deferred_start(0, 0, False, True) + testpmd.start_all_ports() + testpmd.stop_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + stats = testpmd.show_port_stats(port_id=1) + self.verify( + stats.tx_packets == 0, + "Packets were forwarded on Tx queue while deferred start was enabled", + ) -- 2.44.0