From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D90945F30; Tue, 24 Dec 2024 18:19:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A7BE4029D; Tue, 24 Dec 2024 18:19:07 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id A694540263 for ; Tue, 24 Dec 2024 18:19:06 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2164b1f05caso54610225ad.3 for ; Tue, 24 Dec 2024 09:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735060745; x=1735665545; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QvASjpuh6whqTtbzSbqMIctZYhqBy4tH+5Xk9WhoKoM=; b=ukOKvM3YJ3tuAM5FeKnTVA+kdX4WJRQu6u8MhyfyJ0GHHIoIHs2K1c8Ekq9JDWhUpO FfQPLzOe85IZqxoygOmEdm5aS77d+kWOLwYyKuXtF7NKJvBOcB6bojH/GIWtmOcrwPRi GGM5SI3X8xcjf1T80jw2tloLJVxakbXDimfHGfzxcZUR5koJ0+2aj3pD18PHJBBtcJZC y5O6OY8zHyyw6Zk0yTVxDUG1jzl6OZ7wtO6vKMeWG+AemwfwOkxIKCGREz0tHgm2eR8I f13NfwcUcb1wa/B5uK3/+vFf68CDqHdvROcTdHMnrpV1ugungUmdyvIca+qSvQ0bglMB l/Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735060745; x=1735665545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QvASjpuh6whqTtbzSbqMIctZYhqBy4tH+5Xk9WhoKoM=; b=cexZawZM5BuoVjnw4PhsPSoSaAOn9h7hEiWrivt/s+kNjPhR1jtSaC8QhoeFh+ee6X SrUYaV3AwJMDJRTL1K/BiXnrYrD8kSZGHR/jaZTUMMs9aD7NNdzzwhJB3fdFnCeJP9Vx fE0eaJlFtLRB1F1VMsNrOpJPpiNDI/B4gFkYJJsEflOveHyXCaluoDgRjw2NG9uyJxHZ 1wxSczfZoDT+mNIqfyDSvdtTzyQg0N9W8B594K/bDdtXxy6CnFlZIaCKWGIFKLtQrzZR c8LxolIhUPgxHxs7Vx35mtQe8s8/evSeb4UBxflPzczKFa81noXC438A1nKH3eiMwI+s EE5g== X-Gm-Message-State: AOJu0YwJOkYxpGuW7i4SI51kLZ2Hy85f3KjrW+lwx+lKlyFyoaki2pUo Bp/jrJ09kBvS3QDuCvTNs01+joucjhIPfupXlcBFpVEzbANfPou4iN7OeGzCZlI= X-Gm-Gg: ASbGncuOgSLqQcXn7sgXHbo8nMCyT8SdHoE1YxZa4bFwffBnXqjQ+aCa1Cx5+W5j4tP NF/AGAgNS+MDhj/y0n+h69zHS8zysWHiN+IoQPKFVoOYq4k+YKzUVuu9aCH0vu7zjhNZRjHQoVU fuW+AembPe6kIHAAKrJIKzRiAw2OlMSSKluefYN6el47Kzh8y8OPI7tAnyjJ3Jd2fBNZJ9HCKQl C2ZgeppgXwWvznHYEo68VkWW5JXEeFZYFBCm5wKGw9paQxcWEeS+WE05JdFglnhz0nspfzNgk3u K8vYKb7OmPnL X-Google-Smtp-Source: AGHT+IHajlc3WY9rZfwCBak4xTJIY9EjtHM2lz2mf8X+IHwp4NlQMxycSDJWI/TP/D7BVHhAWDNNPw== X-Received: by 2002:a17:903:24e:b0:216:7761:cc49 with SMTP id d9443c01a7336-219e6f26251mr246546355ad.47.1735060745640; Tue, 24 Dec 2024 09:19:05 -0800 (PST) Received: from fedora (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f7356sm92450225ad.193.2024.12.24.09.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 09:19:05 -0800 (PST) Date: Tue, 24 Dec 2024 09:19:02 -0800 From: Stephen Hemminger To: Shani Peretz Cc: "dev@dpdk.org" , Aman Singh , Dariusz Sosnowski , Slava Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , Anatoly Burakov Subject: Re: [RFC PATCH] ethdev: add new API for enable/disable xstat counters by ID Message-ID: <20241224091902.6c73340a@fedora> In-Reply-To: References: <20241222153819.62519-1-shperetz@nvidia.com> <20241222084600.7d020991@hermes.local> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 23 Dec 2024 10:46:59 +0000 Shani Peretz wrote: > Sorry if it wasn't clear, in mlx5 there is limited number of counters, so if there are X counters and 2X queues, there won't be enough counters to get statistics for all queues at the same time. > In this case we thought the best approach would be to allow the user to choose which queues they want statistics from. > If the counters are exceeded, the user would have the option to disable the counter, thereby freeing up the resource for reuse elsewhere. > Ok, other hardware may have same issue. Why not do it per-queue (not the id stuff). Kind of related to the existing queue stat counters that need rework. The ixgbe has similar mapping problem. Let's solve this once across multiple devices.