From: Stephen Hemminger <stephen@networkplumber.org>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Jingjing Wu <jingjing.wu@intel.com>,
Praveen Shetty <praveen.shetty@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable
Date: Fri, 27 Dec 2024 09:57:03 -0800 [thread overview]
Message-ID: <20241227095703.29fe0052@pi5> (raw)
In-Reply-To: <1735263196-2809-3-git-send-email-andremue@linux.microsoft.com>
On Thu, 26 Dec 2024 17:33:15 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:
> From: Andre Muezerie <andremue@linux.microsoft.com>
> To: Bruce Richardson <bruce.richardson@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Jingjing Wu <jingjing.wu@intel.com>, Praveen Shetty <praveen.shetty@intel.com>
> Cc: dev@dpdk.org, Andre Muezerie <andremue@linux.microsoft.com>
> Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable
> Date: Thu, 26 Dec 2024 17:33:15 -0800
> X-Mailer: git-send-email 1.8.3.1
>
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC’s pragma for
> compatibility with existing source code, so #pragma GCC diagnostic
> and #pragma clang diagnostic are synonyms for Clang
> (https://clang.llvm.org/docs/UsersManual.html).
As much as possible, these should be fixed. Disabling warnings hides too many
pre-existing bugs.
next prev parent reply other threads:[~2024-12-27 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 1:33 [PATCH 0/3] " Andre Muezerie
2024-12-27 1:33 ` [PATCH 1/3] lib/eal: " Andre Muezerie
2024-12-27 1:33 ` [PATCH 2/3] drivers/common: " Andre Muezerie
2024-12-27 17:57 ` Stephen Hemminger [this message]
2024-12-27 19:43 ` Andre Muezerie
2024-12-27 1:33 ` [PATCH 3/3] drivers/net: " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 0/3] " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 1/3] lib/eal: " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 2/3] drivers/common: " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 3/3] drivers/net: " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 0/3] " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 1/3] lib/eal: " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 2/3] drivers/common: " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 3/3] drivers/net: " Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241227095703.29fe0052@pi5 \
--to=stephen@networkplumber.org \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=praveen.shetty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).