From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E38B745F59; Fri, 27 Dec 2024 18:57:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C4134021F; Fri, 27 Dec 2024 18:57:08 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id E99FC40144 for ; Fri, 27 Dec 2024 18:57:06 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21636268e43so25583595ad.2 for ; Fri, 27 Dec 2024 09:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735322226; x=1735927026; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XrOrWAt8vA0RkvG5ZjDxQrPRJoEWzZUJF2T8oFH8nx0=; b=dpg1JVq2fN+n2GCpUL009lDswGwquJAWgjSJMSv/XYqejxt9EylZvK1rfyIeX+wLxW ubz9C53ehb/1lprsytjZhbSoFBEDx1HbYG0CbkZctMEeJ3oTgNEfPPt2pppNq3b+3EAG DjrLMgN+h5DWkQ04g77Rci/P5yfx8viUvf2kdgOXGsMWEMMGKY6eypFm4JNNl6xkocM6 pRZy/8d5JlAJsvfKBuraFhb8UnJYIDh64uBVaabKCH7SXXinlC69UBlYEX0BYRvMmqls cKrAxWQWcYkLbsoiKhk2KHwJiameSig482ehva6ZnwC9WvbEjlVKY+5X6tjRE7HNOAxN C0Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735322226; x=1735927026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XrOrWAt8vA0RkvG5ZjDxQrPRJoEWzZUJF2T8oFH8nx0=; b=wMY2nMAXMnPGrVnN6digLoPaCERbBs0sjZZMst8BchuUfD4/9Uznk4jOuuI0nGfYjb soGEqv+hQHU7+ag2pR48taT1adMFkvxrtqpwdk5n1OK6w4WPaO1hHQxKUIephGebaLQC uoWc7NPxzl/IzKTqQgQBKU/RfZOBEDTk+dULgxoHti1YzTFSWnxmB7OYmp0uUP8HAPk7 p5KHrpV8TB9CmdQw2xMtbdnaRR3ur3SNQeYE1RkzCUgU2NIGey6hIy2FvNYACHoRunoq 07ofLfewkC5rHj1SUdsAxAj5NCTw0xfrZFLuSPaNN8ICaDgyVfHKepXbcCYW9fxTlpwT jw5g== X-Forwarded-Encrypted: i=1; AJvYcCVvbCjC0jL8SwNT2YSSODbpJAwz7FQ3rve0xc8uGW5OVVlInfHByoKB7aVQHYQjStDI8eU=@dpdk.org X-Gm-Message-State: AOJu0Yw2Bh3ihK7nzoBuUVVa4bd58MdkfOwrs5SuVlKW/pKu31265LS/ Tp/F+UAT78Z5lbCv3xTp2XtosngA7cdjemph2GPVfTL5tcuwfLf1tpZxoAZwN4c= X-Gm-Gg: ASbGncvHw8xUZ6ypfATLXl7w5wYhmqsfmDr0T4FVNKMyWgJ6UcjfIOOJm5kQ9+LVZPE 8laTfXOIzkF/22StKbZh36rh4Vc4IGyhD89wZ6Tyq5Qf8q4Nrf6capLhSDmlzy+O5IjljkVTA9m rhtGYgkmVyBYCwI5X62Rtf4/e0WKuDcaD1KRIvV+KzOlQzmehEAvEKKIKctBYrLGeWALiM7kOPU rLBwdnN3OeFS3RNZ3N7tDbzYpLHKu+VsrAt+ShJ41h0/kS3Cml9zimTsWX5w7EieCDhaaGu+Kfe sfS2alZv X-Google-Smtp-Source: AGHT+IGomwl6Am3fzlp5qcHGScGK8ktfiTg6pq4bUexGSVdbY+bLuCgXJFBTeONXbWcdNYcREIL85w== X-Received: by 2002:a17:902:e5c7:b0:215:bf1b:a894 with SMTP id d9443c01a7336-219e6eb5bffmr385346525ad.24.1735322225941; Fri, 27 Dec 2024 09:57:05 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca01450sm137635325ad.230.2024.12.27.09.57.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 09:57:05 -0800 (PST) Date: Fri, 27 Dec 2024 09:57:03 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Praveen Shetty , dev@dpdk.org Subject: Re: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable Message-ID: <20241227095703.29fe0052@pi5> In-Reply-To: <1735263196-2809-3-git-send-email-andremue@linux.microsoft.com> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1735263196-2809-3-git-send-email-andremue@linux.microsoft.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 26 Dec 2024 17:33:15 -0800 Andre Muezerie wrote: > From: Andre Muezerie > To: Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Prav= een Shetty > Cc: dev@dpdk.org, Andre Muezerie > Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make code = portable > Date: Thu, 26 Dec 2024 17:33:15 -0800 > X-Mailer: git-send-email 1.8.3.1 >=20 > It was a common pattern to have "GCC diagnostic ignored" pragmas > sprinkled over the code and only activate these pragmas for certain > compilers (gcc and clang). Clang supports GCC=E2=80=99s pragma for > compatibility with existing source code, so #pragma GCC diagnostic > and #pragma clang diagnostic are synonyms for Clang > (https://clang.llvm.org/docs/UsersManual.html). As much as possible, these should be fixed. Disabling warnings hides too ma= ny pre-existing bugs.