From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7B80E45F5B;
	Fri, 27 Dec 2024 20:43:59 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 794DD4021F;
	Fri, 27 Dec 2024 20:43:57 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 7044040144
 for <dev@dpdk.org>; Fri, 27 Dec 2024 20:43:56 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 9C632203EC3A; Fri, 27 Dec 2024 11:43:55 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9C632203EC3A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1735328635;
 bh=zWwuCBqbuyMrR//d4zJpHgp7r475iFxFDuy/VKIauOc=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=b7PL4T7YkIxnIp2c0zb66Mt/NnOwvjb6eR9B3XatbXZzUxMm4iQHCichCfoxe9199
 HOpo9+XwbY5xh4SEv8A31dPjXlKb5ADmLiIPZLy0TlM41JYVm7s1Ub6qUJ2aNbPps/
 kDsj5FIbfrjE5+gY2OOC03ya7zoomEmmqIxqU+aI=
Date: Fri, 27 Dec 2024 11:43:55 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Praveen Shetty <praveen.shetty@intel.com>, dev@dpdk.org
Subject: Re: [PATCH 2/3] drivers/common: add diagnostics macros to make code
 portable
Message-ID: <20241227194355.GA9679@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com>
 <1735263196-2809-3-git-send-email-andremue@linux.microsoft.com>
 <20241227095703.29fe0052@pi5>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20241227095703.29fe0052@pi5>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Dec 27, 2024 at 09:57:03AM -0800, Stephen Hemminger wrote:
> On Thu, 26 Dec 2024 17:33:15 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > From: Andre Muezerie <andremue@linux.microsoft.com>
> > To: Bruce Richardson <bruce.richardson@intel.com>,  Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,  Jingjing Wu <jingjing.wu@intel.com>,  Praveen Shetty <praveen.shetty@intel.com>
> > Cc: dev@dpdk.org,  Andre Muezerie <andremue@linux.microsoft.com>
> > Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make code  portable
> > Date: Thu, 26 Dec 2024 17:33:15 -0800
> > X-Mailer: git-send-email 1.8.3.1
> > 
> > It was a common pattern to have "GCC diagnostic ignored" pragmas
> > sprinkled over the code and only activate these pragmas for certain
> > compilers (gcc and clang). Clang supports GCC’s pragma for
> > compatibility with existing source code, so #pragma GCC diagnostic
> > and #pragma clang diagnostic are synonyms for Clang
> > (https://clang.llvm.org/docs/UsersManual.html).
> 
> As much as possible, these should be fixed. Disabling warnings hides too many
> pre-existing bugs.

I'll take a closer look at these warnings and see what I can get fixed.

My main goal here was to get the code to compile with MSVC (without
disabling additional warnings), but I agree that it's not great to
see these warnings getting disabled in so many places.