From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBB9345F8A; Mon, 30 Dec 2024 18:44:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85DD840272; Mon, 30 Dec 2024 18:44:58 +0100 (CET) Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by mails.dpdk.org (Postfix) with ESMTP id C30A140263 for ; Mon, 30 Dec 2024 18:44:56 +0100 (CET) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-29fad34bb62so4708734fac.1 for ; Mon, 30 Dec 2024 09:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735580695; x=1736185495; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fvDe1ga4uur1vXLl3un+EysLrlV+sKNOXznx/teurSs=; b=Fv80fJee08aWPPkmp4CM/zgceM78b/XNC7Z/wKQlzLWss5qqBz9B4uEJDodBwRAp14 qnL38qFzHbHG/eqwuXYMxSmPHfcYDic25phttBrsu2mCRcMSmK9EfLqA9LRkQlcxy/vn xUgw3K3qceFfAZQ3jULZnEQQyqoI5sj7g++zIMa7ABgzdUtfCARRWoQxl6WgUNPd63Xu XdjK33PbGFPeNZap4nVxxTqbihgmj72diXVZFrn2QjF6tO4nY//Los3FkDO6C8r8oG8X OCF/4BXbVj3BvgijEGhzE45/XVSeGwE3S66nLZ18GFJbhMGJ3xblgwWFCYRNVUps+qfF JjlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735580695; x=1736185495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fvDe1ga4uur1vXLl3un+EysLrlV+sKNOXznx/teurSs=; b=XG3koXi43fUie4ApJNaNRP1QW05qJ86Hp6fCCLkHPJezQICAH0ErlfGemRg5c6TvAh mW58c0ITvCaEgIqxKWs29HNA3XnHFNYO/5c0492h5JslLnHKJ/dsd2JJxiA+v2X7jCNw NCXPxC3M7OQzD+fi6SwIrdySoA8xt28dVwgpbe0LzG+nDyz0V+FCE9MWjlBA5xtwOID5 xJr2kWzpvmkiG7w1xoXebo5FxnBp4+pFEUfd/aPvwS8nxVgcjGVFwGUgHDOLHunBZGj0 8Mc/E3fhU0tQze/1w+VRPbp088xMYp6YupfwvjJ7oL5ATveINWBRllWk27J75Brg7th5 QK7w== X-Gm-Message-State: AOJu0Yx0MvgeGj4UpGWMEyyQTIb/zNyo12Q6VHRZi+9036S4c2yw9gZX X8XeN9rbcerQZhPWzGOvutNoELqJQwcIqQE1fHZiRRAk09COEA4fOo32WUSu8Yb0sbLQi9XhPIt T X-Gm-Gg: ASbGncvKBh0WaQCvUb0r5weWhFOCpG/3pxyGCKloh89JmTT30I9xyxA8SEQz+7pL6GT uiOQiqWN+ovYe73cYRN5/f4UX2tZf6nKfV0BKx+NIC3UzSHhiYjbmtUuHKzOopOr41wPmPA4ZpU cAZqq/bWhxp5dWIyDhJ4XvwvZPpq9NH1XSfc6+AjUcChhKsSRKvjvhNjrcM1PpvMEair+BWnJ4a gRLgBPo9aanDS2PIxcj8vbZWBDNYztI5t94/nrbiEwJDKentABFAVnHMzYUYJ6vpeT4rfNW5cin H3phIjmm X-Google-Smtp-Source: AGHT+IHNa0geWkYgyfr6VGOvmAVK+0Wb9r+M2LAQUn7Ot+nQj70jPksoIzweB0HSiJktMxtcxkiHDw== X-Received: by 2002:a05:6871:8306:b0:29e:6096:c25f with SMTP id 586e51a60fabf-2a7fb2e94c5mr21136550fac.23.1735580695687; Mon, 30 Dec 2024 09:44:55 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5f4db5d8bfbsm5492523eaf.20.2024.12.30.09.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 09:44:55 -0800 (PST) Date: Mon, 30 Dec 2024 09:44:52 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH v4 0/3] add diagnostics macros to make code portable Message-ID: <20241230094452.1b92ba88@pi5> In-Reply-To: <1735574370-22090-1-git-send-email-andremue@linux.microsoft.com> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1735574370-22090-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 30 Dec 2024 07:59:27 -0800 Andre Muezerie wrote: > From: Andre Muezerie > To: andremue@linux.microsoft.com > Cc: dev@dpdk.org, stephen@networkplumber.org > Subject: [PATCH v4 0/3] add diagnostics macros to make code portable > Date: Mon, 30 Dec 2024 07:59:27 -0800 > X-Mailer: git-send-email 1.8.3.1 > > It was a common pattern to have "GCC diagnostic ignored" pragmas > sprinkled over the code and only activate these pragmas for certain > compilers (gcc and clang). Clang supports GCC's pragma for > compatibility with existing source code, so #pragma GCC diagnostic > and #pragma clang diagnostic are synonyms for Clang > (https://clang.llvm.org/docs/UsersManual.html). > > Now that effort is being made to make the code compatible with MSVC > these expressions would become more complex. It makes sense to hide > this complexity behind macros. This makes maintenance easier as these > macros are defined in a single place. As a plus the code becomes > more readable as well. Does anyone still use the Intel C compiler with DPDK? I really wonder if it is only maintained for legacy/sponsorship reasons.