From: Stephen Hemminger <stephen@networkplumber.org>
To: Jie Hai <haijie1@huawei.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<david.marchand@redhat.com>, <andrew.rybchenko@oktetlabs.ru>,
<lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<huangdengdui@huawei.com>
Subject: Re: [PATCH 0/3] net/hns3: bugfix on hns3
Date: Mon, 30 Dec 2024 09:51:54 -0800 [thread overview]
Message-ID: <20241230095154.36dc2fc5@pi5> (raw)
In-Reply-To: <20241230065405.18552-1-haijie1@huawei.com>
On Mon, 30 Dec 2024 14:54:02 +0800
Jie Hai <haijie1@huawei.com> wrote:
> From: Jie Hai <haijie1@huawei.com>
> To: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, <david.marchand@redhat.com>, <andrew.rybchenko@oktetlabs.ru>
> CC: <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <huangdengdui@huawei.com>
> Subject: [PATCH 0/3] net/hns3: bugfix on hns3
> Date: Mon, 30 Dec 2024 14:54:02 +0800
> X-Mailer: git-send-email 2.22.0
>
> The patchset fixes some codes.
>
> Dengdui Huang (1):
> net/hns3: fix simple Tx path incorrect free the mbuf
>
> Jie Hai (2):
> net/hns3: remove pvid info dump for VF
> net/hns3: rename RAS module
>
> drivers/net/hns3/hns3_dump.c | 4 ++++
> drivers/net/hns3/hns3_intr.c | 4 ++--
> drivers/net/hns3/hns3_intr.h | 2 +-
> drivers/net/hns3/hns3_rxtx.c | 2 +-
> 4 files changed, 8 insertions(+), 4 deletions(-)
While reviewing these, I noticed that hns3 driver is open coding its own version
of rte_pktmbuf_alloc(). That was a mistake, if a future changes to rte_mbuf.c change
the allocation logic, the driver will break.
prev parent reply other threads:[~2024-12-30 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 6:54 Jie Hai
2024-12-30 6:54 ` [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf Jie Hai
2024-12-30 17:55 ` Stephen Hemminger
2024-12-30 6:54 ` [PATCH 2/3] net/hns3: remove pvid info dump for VF Jie Hai
2024-12-30 6:54 ` [PATCH 3/3] net/hns3: rename RAS module Jie Hai
2024-12-30 17:51 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241230095154.36dc2fc5@pi5 \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=haijie1@huawei.com \
--cc=huangdengdui@huawei.com \
--cc=lihuisong@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).