From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8C1845F8A; Mon, 30 Dec 2024 18:51:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D1B840272; Mon, 30 Dec 2024 18:51:59 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id CF7B640263 for ; Mon, 30 Dec 2024 18:51:57 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2164b1f05caso120960065ad.3 for ; Mon, 30 Dec 2024 09:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735581117; x=1736185917; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2rPY4OF7nrqvUqzsN843shI+1t2aYFtj6rs/In2BYmA=; b=Cf1RvS5WzyD6RupVXW1FlyhiNP0QqA2h80eLR4T+A/AzK0F0JKI0/3RjnrOODIz6// 5dq0M+Q+RAizaHCYoS03M81HhyKvklRBgxUXIGExRixcitlNqMId/O+t4tIjdy53PpZ8 VMLxvTKxQmGkTb4KkdeQ337awnKbph0eabauX5//BsKesgusxqR6OIDq2Ma4X3uL38p/ nrTo/RGgsjUpMf4H+eG9n4WnkoaT/FpVS/y7bY/Ph/hXoutmpBBOQ1nD/8pjnRgIFFRi JsDiryNVSGgG1D6na2ZxcjZggdfke9kfg3Df/Gi62eFqMoJiPwFa56AaAAm2zzJYKOtr /TAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735581117; x=1736185917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2rPY4OF7nrqvUqzsN843shI+1t2aYFtj6rs/In2BYmA=; b=NFrJBruFu/iuKmpYOdpckRuThzW4PfVkhl8rByUN6KEpAdBz0/GIvdSmYTLpcAMZe4 FY9QV2FsDArQv3bK+ziVSmtVwCsnRuUnz1DIIxx+vbRj0NSE97FqJrNsM27us3B5duXe J91s+S9VxMKK7fzHKF7Td6JwlL5nOBvgGLUCDF+vMyOiXg0uXkZ3IMo7jSOLD82V18oK 1M9BLkOye2/Vfzq9s3HCPlybZHpjVOnUKLMelELsWxxlQq++0t9SzgQyb7HO/HR54v4K PkBwg3n67fqfgD0vyZAZp7m1Nz++uYeC6F3dPtFxd2mLdDKoe2o4qzbsRuqAPFntOHMb ktsA== X-Gm-Message-State: AOJu0Ywc/8t7CNPcw8BqiGt+rflEEnUc8GHM6nySqLr75suTQDMCW6Eg MQIRSUOHJ4yReNAI+GBNOB6m5icjSKpkuwf9gNGZBgXIFyU/AUCNxSXRhqW+TwY= X-Gm-Gg: ASbGncvY2jbCx0oiFGz5D0Tn44tfQ7qQNv/p5n+zaMn4YiE2J2D+rJJ0mAW7XAqXZqh oOVA/vy/josRBOJWGDamZ1vxaLrJObrBxUneUUBIMN2xmFla890jTjfkW7P/9OYO9S+Uok7mYhM kI4z9F3hs9OJyAdNQEXaM8dVHitaedJwdkGwPf/IUj13UlRHFR8PzvbzLW6erQc9O/uOzjnWlqS bgYbMi7TRwCoZF+My/00wCxQ6yFcPLYe9wsYcghny1u7t961EnNGrYoqd05UrgfvLIIueJ5jXgs lDSjU/wZ X-Google-Smtp-Source: AGHT+IH7IytHdtLX4fvtD6U8nb8Z5600cRT/rTJxLF0e+1AzfwIjSrvoQuMYqYrtmArk1NJGWupOWw== X-Received: by 2002:a17:902:ecd2:b0:215:89a0:416f with SMTP id d9443c01a7336-219e6ebd0a4mr466521245ad.30.1735581116925; Mon, 30 Dec 2024 09:51:56 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02544sm181629165ad.255.2024.12.30.09.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 09:51:56 -0800 (PST) Date: Mon, 30 Dec 2024 09:51:54 -0800 From: Stephen Hemminger To: Jie Hai Cc: , , , , , , , Subject: Re: [PATCH 0/3] net/hns3: bugfix on hns3 Message-ID: <20241230095154.36dc2fc5@pi5> In-Reply-To: <20241230065405.18552-1-haijie1@huawei.com> References: <20241230065405.18552-1-haijie1@huawei.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 30 Dec 2024 14:54:02 +0800 Jie Hai wrote: > From: Jie Hai > To: , , , , > CC: , , , > Subject: [PATCH 0/3] net/hns3: bugfix on hns3 > Date: Mon, 30 Dec 2024 14:54:02 +0800 > X-Mailer: git-send-email 2.22.0 > > The patchset fixes some codes. > > Dengdui Huang (1): > net/hns3: fix simple Tx path incorrect free the mbuf > > Jie Hai (2): > net/hns3: remove pvid info dump for VF > net/hns3: rename RAS module > > drivers/net/hns3/hns3_dump.c | 4 ++++ > drivers/net/hns3/hns3_intr.c | 4 ++-- > drivers/net/hns3/hns3_intr.h | 2 +- > drivers/net/hns3/hns3_rxtx.c | 2 +- > 4 files changed, 8 insertions(+), 4 deletions(-) While reviewing these, I noticed that hns3 driver is open coding its own version of rte_pktmbuf_alloc(). That was a mistake, if a future changes to rte_mbuf.c change the allocation logic, the driver will break.