From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB2F945F86; Tue, 31 Dec 2024 16:12:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 662394026E; Tue, 31 Dec 2024 16:12:22 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E3E6040263 for ; Tue, 31 Dec 2024 16:12:19 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id F16922046759; Tue, 31 Dec 2024 07:12:18 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F16922046759 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1735657939; bh=k+cWdYK1joRZJXaUs8zdNTZ2rGwXblhJBuaaapXR88E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fuGO4pCZVOZZ+HBSopLtlMN/4tpc5MON+jY3nsAPUryCYohvFqa1KJgNri9+9Z8Zq 9udinE55E6SPsXMQPQd7WuK6x/rsBZuGWtGWZAi5q75n6RxmL3sYq+ngjbG0vR4VGH jHkKg1EVYqucmxVMZO3c4LwPV6JXBhBZbNSfEAJs= Date: Tue, 31 Dec 2024 07:12:18 -0800 From: Andre Muezerie To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: roretzla@linux.microsoft.com, aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com Subject: Re: [PATCH v7 01/29] devtools: check packed attributes Message-ID: <20241231151218.GB28057@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1734981122-4729-1-git-send-email-andremue@linux.microsoft.com> <1734981122-4729-2-git-send-email-andremue@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F978@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F978@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Dec 28, 2024 at 04:13:28PM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andremue@linux.microsoft.com] > > Sent: Monday, 23 December 2024 20.12 > > > > Ensure __rte_packed_begin and __rte_packed_end show up in pairs > > when checking patches. > > > > Signed-off-by: Andre Muezerie > > Acked-by: Tyler Retzlaff > > --- > > With GCC, __rte_packed could also be used with enums [1], to reduce their size. > > The release notes coming with this patch series should mention that this is no longer possible. > > Suggest that this script also checks that __rte_packed_begin is not preceded by "enum" (and whitespace). > (A structure packed with __rte_packed_begin might also be __rte_aligned(), and these two attributes may come in any order, so checking for "struct"+whitespace would introduce an ordering requirement for these two attributes.) > > [1] https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-packed-type-attribute Thanks for the suggestions. I'll add some tests to the script.