From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94E43A0C41; Wed, 17 Nov 2021 12:48:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EB7D4068C; Wed, 17 Nov 2021 12:48:42 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 7510440040 for ; Wed, 17 Nov 2021 12:48:40 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="214650741" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="214650741" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 03:48:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="672349587" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 17 Nov 2021 03:48:39 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 03:48:38 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 03:48:38 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 17 Nov 2021 03:48:38 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 17 Nov 2021 03:48:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kGxl67e4skDyMVJmViM8lw0ILKWcbXxdxymQvna/XQHArb8G2MLlTptUMMLK5TU/20rbL7PV+8kyHcfxvRSe+ComlS0Tqn/lCFSGzobsf7TcIlePN0SROtr8HY3b9wWABDUsJjgVNP8Qc6lp5kJ78KtH6XXkqk0whIa0Ns9ueDRFERdx07+eHu58BQr5VCj/Omd8oQ6xhDSu5X/Q79E3JOB9tBdM+EkTCvPUUIgch9RR1Vn/RJLyVLqEwjAn9vU/WhHS1p/EoDPkgpjPgGAvFNNRKGizEZyA5M1kwx/m2A8nO2KZ9LUpPbSyF2aPesGDLi4FRZDvlETQ0HxiyhYfOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yGE0ZDRAG+QFtMDkyFstNldT9fSBCmeFskZyjyKt66o=; b=HXBeDGgQwcRbvBQacEknV/TJevNGLsCzQ0UzJ+rZ1enfg60yTjV0IiRvC9qExn1hr52WgbB08WkusaWCwD0RL3ufGtzv6CeKhG4UJaZcUUolh8uR4Qa9acNiAMx/BsHHrM418ev0ShVdsMHjLnRkn9lkDmvtuBQ6IV1E0ABnmhPYTJblKEDvq207I/WNxjdw7NLdPay2AK72iXMxBT7ktrBJOOtG1hP0yrydCvACbk6S+lM5qaBgcuebPI9VDIDsgh3zMHlhtaiIF596Nc/qz7y6l0am6x/0JFytSdaFtvGIkByMgHBDyAQxC/+VylGHFpZuVo/xPpoo3KOwHA4NSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yGE0ZDRAG+QFtMDkyFstNldT9fSBCmeFskZyjyKt66o=; b=iisH8QCIBJJBCuN2enAlLuODzk0kKehA9kQ2q7muHEECJlnm/PRGJtye+ccW9nBmG5lFTWUYnFwq/S+odn8fZ5FEnpjg5rK9TSRFMZhQSBHzhR2YhPWqSBRWvhfgPXpAqaTY4XfERCcQ1AS+YSXDEkEDBPqkZrp6E6rqgPz0bTU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5781.namprd11.prod.outlook.com (2603:10b6:510:14a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.25; Wed, 17 Nov 2021 11:48:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.028; Wed, 17 Nov 2021 11:48:36 +0000 Message-ID: <20243569-b7f0-53c5-02c5-ba29734e30c2@intel.com> Date: Wed, 17 Nov 2021 11:48:30 +0000 Subject: Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools Content-Language: en-US To: Jerin Jacob , Elena Agostini CC: "Richardson, Bruce" , Stephen Hemminger , "dev@dpdk.org" References: <20211029204909.21318-1-eagostini@nvidia.com> <20211117030459.8274-1-eagostini@nvidia.com> <20211117030459.8274-2-eagostini@nvidia.com> <20211116133449.7b7d21d1@hermes.local> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:10:36::45) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:10:36::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Wed, 17 Nov 2021 11:48:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 529353f0-b0e8-4457-60eb-08d9a9c03036 X-MS-TrafficTypeDiagnostic: PH0PR11MB5781: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KHasONQ9Fqi47z+S6A4HDv6WLuNDy1z1/dc8U1TJP4ssCYGxAFqUjM6VZiqUFnAW7aC9JOM9HjiN4d1fE51yAMIq1NgUl1z4A/GHXoJsMjwAuoUifuFvPVfPL1lZ9QmRt25ByqBZ9XcLQrWM99khUoIbV4oRH8ORvOom59RI20RPlcSqBTxb56J6rahm+VK7+9oUDEZswZ7lKSNmbsa2VnSVmrnxDQfZpWH/xhjnm0PPX0zpn6+pLFg+H92wfrxzPnlUa4U5wuas503Yy83pXWaItv+3vI/HgbsWtkzVCbgnh2FTCcThySZloqk+bfWVI1Q6F76Cm4c9v4XxQ1NE25Fsh/qQzgR2d8CCS2KdFghOUegRqgQ2r6z+AXhAWQ9vWtweUIzb51uMySbC9nnrl4lFOvqZiJA3i/OJdSh+0C5V1zzsTf7z1dd9yoozBGhM0cBNbFE01y8+iuZhp+8QNWSbXr1gTLMbx2+xtdW8q7oyzs2WG7dDlhpFWFbwmOWmBGpl71hYwtvt6JdxgNwfdaX4GVBMexT4D7bgPLRn1r44XvETfj9JS5vbg/siummMlhad9ZzMdEtysazWwdAPDDOgfXBxOUd+D4TOSINjc9ZHxHACST1BKsJ9C8qO8MGpg2z6MGJ4AW6ouGKRG2+mj3z60FWCa6Wi3rRHZrlzxDyKverniz5vhsu8hE89vOzzs0e5l/YqWrS1jylHO51p8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(5660300002)(83380400001)(186003)(44832011)(8676002)(82960400001)(16576012)(36756003)(2616005)(31696002)(31686004)(86362001)(66556008)(54906003)(956004)(66476007)(508600001)(110136005)(66946007)(316002)(6486002)(2906002)(6666004)(4326008)(38100700002)(26005)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHZuTjB1UDh3dVJxQVpZZmhuQ09vT0FMcTlpZE9oS0pBMkFEVXV6NEhKNUc0?= =?utf-8?B?aHJhTUFTbGVxeFd5T3dIZjFkZ0F4NExIZW9VeFhzd2JDVHBMRDQ5V3djUXBO?= =?utf-8?B?alV1Q2ZwWTVnSkg3SmtjZjlkTEFMaW9pNEwvY0piOStBakhqSjltZlVLOU1a?= =?utf-8?B?K09lYmo0aDVHRDkwNVlKTG1nUHZUQ0NpZkh4ZWhUbU1Sc0poMGNqWWVROGtE?= =?utf-8?B?NkJHdzArZUtNcWhGZG9BZllMWWVSUXpaNUpDNGtFZVZKdmltcnBiTml0dUwz?= =?utf-8?B?MkIxTjNlWWlQT3Z5VjdwTFgwQW05eGhrMzN2WmZPYkx1RFRUV0xxcmZzSDRO?= =?utf-8?B?dmVHdlMvVWV1N3pmRnFXUExYS0J3cWY2UmRiMmxPdjgzblI4QXF0QnFHdzk1?= =?utf-8?B?VWM4ZDF2M0tzb2hQakpEdVRiZDF2bzJGQmF5KzVJVkJlOE9iNERZeEUyeUl3?= =?utf-8?B?RjR1a1VoaWN1KzJaS1NIL1BkaGlSS05qaG9yQitGTW1BZzRBM1A2UzZEbDVW?= =?utf-8?B?dTllWVVXdlZLU0NpREJtMUloOXNYckl3anJFd1p3by9OQmVFVGhpSUltd0do?= =?utf-8?B?ZmhEbXZkWTFUN0F6N0NjYm9BckRjeTJQWmUrL0tIK1dSSXJOc1h0eHN6eTJ3?= =?utf-8?B?STBlRWY5SVVZMU94M2J2elc0a3dsampzVVZyRlhhdjEveEJPSStQYmR6NE1M?= =?utf-8?B?MDh1Y29tam9FRzUwblkrSmtVRXNmaVBIMFZRQTJWM2NYSHFQRXFjR1NuNkJ0?= =?utf-8?B?UG1BUEhaQnd1VTFlTDJ1ZStDZlNCN1cyakNDSTNNazNsdElWQnY5QUdqMElN?= =?utf-8?B?YkVubWdWWFRVZXBOcmdJTklwZUlyZDZjTjl1SU96aUI5eTkrbnhJQXFrQ0lv?= =?utf-8?B?dGhiNEV2bFlVQjJBME9RaUt2V0hpdEVlSTBSWUZpYmJwM0kzemd4aFhZVEVs?= =?utf-8?B?QVdqUFFjUXd1bWJLMEFMdVZGL0JIdmlNWWlyYXlIdHFWSlB2bnpvQjVLV0Zr?= =?utf-8?B?d2piVldPUXRuU0h4M0xpMmtKRTRZVDR6bFdiUXpTaHFXdW5Ja21FUHppL3Bs?= =?utf-8?B?akQvRElPamtQV203NThMbWlUdy94UjhKQ0YvOGppMndkbnBzeFZkSk9hcG5I?= =?utf-8?B?N3ZGb0JzZ0svMFkyS3kxRXMraWpXRVVkK2NSSk4rR3pSbGFsVUQrWHFGaDNh?= =?utf-8?B?cmNRNXI2SUFHalhRd20vTERzbmw2QU1nSTltVGEvRXVBazVRVHVtbTVBZXlS?= =?utf-8?B?Y1U5RGhiaXk5RVMvWGdJTm5PeDd3dno3WU45SWQ4UWJabTNNN0VMd3JMcGp2?= =?utf-8?B?cEJ1WThOKzcxUWNjK0swdU01bHFXNlJmYWxYZHJzUWNyTFJXV05MbTAwbHRP?= =?utf-8?B?OUd1WkVvQjVsNE5sbUtwY01XRWpRTUJpc2NiQzFXT1Y2eDVVRVhEOEJBaHUr?= =?utf-8?B?U3UrN2ZnUHZydUR0SkhlaWpLNjdLTVJuQ1BNaDVKNklYTmszYnZoOEM0aHlG?= =?utf-8?B?VEhCWFZqVnEzUDBtcHNoUWVGRWxtbVNNOVoreEVMcmdHdHdZR0VaaVR4dy9K?= =?utf-8?B?VUUyazRONzNpZXU1SHRrVFptdHo0eG1yTTFPK3VMdzg4L1krbExZYVUzN0Ny?= =?utf-8?B?WXlTY2JMY3ZaSUdMaGhSdStUUVVqZFlNdzVxU1ZUaDNXTitlajhDOFRJbU9t?= =?utf-8?B?bG10U1IxWU1oeEF1eUxJd1lJVG8wbXFaNVk1UWNnUlhXcGFmY2RXSDc2RDQr?= =?utf-8?B?T2IwdE90WDZpem41SzYvbkRnejdrRDF4SXltOGVIYlR4amtpZHVrdmZYSXNE?= =?utf-8?B?WUs3Mnd2VUQyU1l2ZFNNWW9QNmtaUFdGWlV4WTRpZG0rQXJzYzJiSHRrRnor?= =?utf-8?B?bGtyYkZxMTgxRE9kZDZpVTFJNHpnVG9vYUd0M1RTS1BmN055MlovQjRkZ2lB?= =?utf-8?B?RHl5S2tqZmNtYWR3eHFsUUo0dENvK0hwa2xYc2VzSXNpOGtrbDFISE5YQ0I2?= =?utf-8?B?N2UrTmhjZC9XdUhuZjY3RGx6b1daQURQRFN6UjRJQ0dLNDljRHh2cWkzSThv?= =?utf-8?B?MXlxY24vSVYyb05UTUxwZWhnUVlmc2RVWWZMQlluZG1lV1BkZ2hhR2ZkMmtK?= =?utf-8?B?OVlkemhQeXlJUEdtZkVOa3VmY2xOZmo5bU9MeXVIdHgxUjVPTkpLT1Bnd2FB?= =?utf-8?Q?xoAjncEBCAOGaF5FmvihfCI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 529353f0-b0e8-4457-60eb-08d9a9c03036 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 11:48:35.9471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4pgpXyWEKh8WuK5pBK4kb56p+/ncRlya+uh1GaZ9hDTA+HpILwPZDlkdaJ9c814+Cfcf6JzxcxH+hIOrH0noEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5781 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2021 11:31 AM, Jerin Jacob wrote: > On Wed, Nov 17, 2021 at 4:56 PM Elena Agostini wrote: >> >>> On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wrote: >> >>>> >> >>>>> External email: Use caution opening links or attachments >> >>>> >> >>>>> >> >>>> >> >>>>> >> >>>> >> >>>>> On Wed, 17 Nov 2021 03:04:59 +0000 >> >>>> >> >>>>> wrote: >> >>>> >> >>>>> >> >>>> >> >>>>>> From: Elena Agostini >> >>>> >> >>>>>> >> >>>> >> >>>>>> This patch introduces GPU memory in testpmd through the gpudev library. >> >>>> >> >>>>>> Testpmd can be used for network benchmarks when using GPU memory >> >>>> >> >>>>>> instead of regular CPU memory to send and receive packets. >> >>>> >> >>>>>> This option is currently limited to iofwd engine to ensure >> >>>> >> >>>>>> no workload is applied on packets not accessible from the CPU. >> >>>> >> >>>>>> >> >>>> >> >>>>>> The options chose is --mbuf-size so buffer split feature across >> >>>> >> >>>>>> different mempools can be enabled. >> >>>> >> >>>>>> >> >>>> >> >>>>>> Signed-off-by: Elena Agostini >> >>>> >> >>>>> >> >>>> >> >>>>> Won't this create a hard dependency of test-pmd on gpudev? >> >>>> >> >>>>> I thought gpudev was supposed to be optional >> >>>> >> >>>> >> >>>> >> >>>> Sure, let me submit another patch to make it optional >> >>> >> >>> Why to add yet another compile time macro everywhere in testpmd and >> >>> make hard to maintain? >> >>> Adding iofwd kind of code is very simple to add test/test-gpudev and >> >>> all GPU specific options >> >>> can be added in test-gpudev. It also helps to review the patches as >> >>> test cases focus on >> >>> each device class. >> >> >> >> Test-gpudev is standalone unit test to ensure gpudev functions work correctly. >> >> In testpmd instead, there is a connection between gpudev and the network. > > I understand that. We had the same case with eventdev, where it needs to > work with network. Testpmd is already complicated, IMO, we should > focus only ethdev > test cases on testpmd, test-gpudev can use ethdev API to enable > networking requirements for gpudev. > +1