DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] testpmd: limit port mask bits to RTE_MAX_ETHPORTS
Date: Wed, 17 Dec 2014 01:09:29 +0100	[thread overview]
Message-ID: <2024529.1MsobXgOel@xps13> (raw)
In-Reply-To: <20141216214343.GG13806@hmsreliant.think-freely.org>

2014-12-16 16:43, Neil Horman:
> On Tue, Dec 16, 2014 at 02:39:44PM +0000, Bruce Richardson wrote:
> > The port mask parsing in testpmd allowed up to 64 bits to be processed,
> > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only
> > processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > V2: changed to use RTE_MIN in comparison, instead of double "<".
> 
> I was thinking of assigning a new temp variable to the return of RTE_MIN so as
> to avoid the comparison within the for loop, but since both arguments are
> constant, I'm sure the compiler will avoid multiple comparisons.
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied

Thanks
-- 
Thomas

      reply	other threads:[~2014-12-17  0:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16 13:27 [dpdk-dev] [PATCH] " Bruce Richardson
2014-12-16 13:40 ` Thomas Monjalon
2014-12-16 13:50   ` Bruce Richardson
2014-12-16 14:09     ` Neil Horman
2014-12-16 14:39       ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2014-12-16 21:43         ` Neil Horman
2014-12-17  0:09           ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024529.1MsobXgOel@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).