From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A1A192904
 for <dev@dpdk.org>; Thu, 20 Apr 2017 23:20:14 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 25B08206CC;
 Thu, 20 Apr 2017 17:20:14 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Thu, 20 Apr 2017 17:20:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=S6y/yQWjMGuUBrD
 /sFTUgXWWoc4K05jzLwhTWj+bVaQ=; b=gA7mIUHgx5+avy98SeU1EkKiKb31Z8v
 wsYPmlAap6+NgHppSmkBLzDK0a3hMdf7brmE4QqHN6Z1ixdbdJqO4Kv9sjcmnfHJ
 YtNKTmot/ztLJbLGoccAot26O2BztuPkaokF1O3NkJ+7Z8LUVBupd5CSA58Efww2
 feGJnmS8pr80=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=S6y/yQWjMGuUBrD/sFTUgXWWoc4K05jzLwhTWj+bVaQ=; b=MPPyPDHQ
 1nmuxmCs7yM0AkyT/a5U3ZsSncRh2upgFnOVW7rLI/jo1cPNL08IG4vwZHYzo0wm
 EBdHWx3r4PtAp7QxJ5Vmya9NbrdsL+/+/519XjAk3jSAueNJheREQFS16UtCszfH
 f7lj4d9FAntRoQpXvfE9hgxXHJjbIRHsrO6IJr7h0DS+/itjRvjFxD3X6ZDY6+qM
 On7QI5J9U2sVakhziTqQQi9tBFHAR2ti14YbbStOdaRFHyMy0XxyUbXku8BBRsSk
 vz2Un9tSPoCXQ2LcJxZNUJHFJINMMT2dVGdTY1sa6Db+LE+ecCRn5Azbjjaju2q2
 mpJuEcbm8TKFyA==
X-ME-Sender: <xms:Dib5WFfmUtFY1fTXQgbn5JvsF17q_DsnfOMAWDeIfBHbx9vWrsYtDA>
X-Sasl-enc: GHo/LZt4/TaYGGXqfpJp8VNxEcXj4Ibts7sbWpbQ4pH+ 1492723213
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D3CDE240A5;
 Thu, 20 Apr 2017 17:20:13 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Wei Zhao <wei.zhao1@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Date: Thu, 20 Apr 2017 23:20:13 +0200
Message-ID: <2024625.2sU8lOsUIU@xps>
In-Reply-To: <1491793349-46840-3-git-send-email-wei.zhao1@intel.com>
References: <1491461483-39861-1-git-send-email-wei.zhao1@intel.com>
 <1491793349-46840-1-git-send-email-wei.zhao1@intel.com>
 <1491793349-46840-3-git-send-email-wei.zhao1@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on
	port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2017 21:20:14 -0000

10/04/2017 05:02, Wei Zhao:
> +	memset(dev->data->dev_private, 0,
> +	       (uint64_t)&adapter->reset_flag - (uint64_t)adapter);

It does not compile for 32-bit.
Should it be replaced by offsetof()?

Does it mean that new fields should be added before reset_flag?
There is no comment about position importance of this field in the struct.
By the way, there is a field ptype_tbl appeared recently. Where should it
be positionned after rebase?