From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC1B845F9F; Wed, 1 Jan 2025 18:21:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF3644021E; Wed, 1 Jan 2025 18:21:44 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id C39E640151 for ; Wed, 1 Jan 2025 18:21:42 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21a1e6fd923so98208895ad.1 for ; Wed, 01 Jan 2025 09:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735752102; x=1736356902; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LHWbvm5+aCkzaxAZO26YLnIpdZ504j20kRUE2Fak9v8=; b=Y2xtFHOQDa5a4PZjSgC73LsIj30wN5k47gncF5IbG/eS0NGXQvmPLJvPJXVtvrP/rv 2yWCcCjyjxkzPT5tCWAECl3w1GdZ+jV9KS0D+tkYA1xdhDL9e0LnTZk/G1F7EXKHFxRl gUlLEGDjFETmGsY6S5ZwYGM9WpYC8QHUF3xtBysE7Sxo+BQWmrMwzPAF0Pc/2mxZFkW+ EhqYmhydPNd5PVUM+symwRrB07TuO9Po6COkri/i/N6BgsIkFqh9bZfqAZYUCTqpYhAT vSkqoQ0UkdmpBpvE3Xj7U5x3D1jxfnxukSKNfIZfNf9N/8AwGZ/sOuu0rZFd7z92BAFL 8VPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735752102; x=1736356902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHWbvm5+aCkzaxAZO26YLnIpdZ504j20kRUE2Fak9v8=; b=o3NRoio1kO6sKiAXv/cspQ76+FVEIRCiLbzXLuU+tHA8cebgehMGyQ1nSDlmdVSSJe ESqX3hwzbWUKA+iN6EpbGRI1mq0xV85y9n6gtPpgM3WDlLqN5M1JM+ujea/bTqrcxJAy 0joCivqrAizi4GVQf9FxNuKT56CP39PESc9IXDJ3PbzgVsdP21Ud/L/43HlyGcn2fbIc uvD8jTUbfhVAyJKfhk0UZMXvUfNVAcH46GeWldGW8U0Vx5KEqz0hylTgrE/UBflHv6fo HnV2JYYKIylfS7hqwrJjOcMrZtaZ9oVms4cZMkfPfBiZ9tMDNFVDfkKcbGHAABmxoEwD 99Dw== X-Forwarded-Encrypted: i=1; AJvYcCWN6hzTOtWIpdVW4mGdiWhQEANbA5+WWOSPooS4vukGkeq6fk8Z+uMjElIb3OJ8PaCDEWs=@dpdk.org X-Gm-Message-State: AOJu0Yx9fhnwRdHIjyymgl2E+36W48JZuFq6pAFV+tuUKIUu5c574M9P +upN5cTTapcEQDELDJOzn1eKkkNqTFn+IDt8YK1Ilfk8uxiEo522s57PHsMr2jI= X-Gm-Gg: ASbGncsuUI31rsM9vo57flAoWwE3tyjZftbVqU8QwEvf/kg6Ly6K6yA7REX/OIQhloQ Wesav+1GwHHM2sr8W919razgYq8POQ+rZw1Uh4hPQ6Zxv/6/rW1K86qfxjwyBBX7apO/6buW6Fq VLi8az09jzvF95KpWNjvk8u56ADyyMtnMke5d72SsXdnKGzJb8BFkU4ScM2rBcIZ6TMJZbP6EsC IADlIJB3vPRZDh5ZbJ8dXrvIlYn3eGGYYdToVKcDLeqDQN6WaUlSFOCiTc5qt40SaJTT8mnAHKN bJZrnZ/O8vMf X-Google-Smtp-Source: AGHT+IFZHEN4do8NWUCuAuaw2PTJbTaQa3oQwF+4HxyXHDO8voCMzD2aFB7GXMCmzPGcB7+KhSRPpg== X-Received: by 2002:a17:902:ce92:b0:215:a179:14ca with SMTP id d9443c01a7336-219e6e8c35amr578578225ad.2.1735752101716; Wed, 01 Jan 2025 09:21:41 -0800 (PST) Received: from fedora (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc972ff1sm212336285ad.106.2025.01.01.09.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2025 09:21:41 -0800 (PST) Date: Wed, 1 Jan 2025 09:21:38 -0800 From: Stephen Hemminger To: Kumara Parameshwaran Cc: hujiayu.hu@foxmail.com, dev@dpdk.org Subject: Re: [PATCH] lib/gro: use hash function for flow lookup Message-ID: <20250101092138.4fb5fdee@fedora> In-Reply-To: <20250101093735.95271-1-kumaraparamesh92@gmail.com> References: <20250101093735.95271-1-kumaraparamesh92@gmail.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 1 Jan 2025 15:07:35 +0530 Kumara Parameshwaran wrote: > From: Kumara Parameshwaran > To: hujiayu.hu@foxmail.com > Cc: dev@dpdk.org, Kumara Parameshwaran > Subject: [PATCH] lib/gro: use hash function for flow lookup > Date: Wed, 1 Jan 2025 15:07:35 +0530 > X-Mailer: git-send-email 2.47.1 > > optimize the GRO lookup using hash based > implementation > > Signed-off-by: Kumara Parameshwaran Rather than open coding a hash table with collision chains, please use the existing DPDK cuckoo hash which is faster and you can also prevent hash DoS chain attacks. Alternatively, use a better hash function such as siphash which is resistent to DoS attacks.