From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1FFF45FCC; Fri, 3 Jan 2025 00:52:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47100402B1; Fri, 3 Jan 2025 00:52:01 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 8C80F40279 for ; Fri, 3 Jan 2025 00:51:59 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2f4448bf96fso12646301a91.0 for ; Thu, 02 Jan 2025 15:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735861918; x=1736466718; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=esADafnBa+ynGcSys0ZaJRzZMYe/6fqtBVZhnDQq6fA=; b=LWJor5QdbQQdVI3mee3mfCcdhIJOLufZujMYOBCIMpZHYF1qr3gsUWf2plneS/qAIx i+yPsclUbSYtSnlhXEQrN1+A15x2DzDv93HWppf67SZeACLbU3lRb6NB+8M0JaJWLe9h 4fhwLkeL0+osk9CEVPFxj9FHpOxewxy8rnNzgoD6MwnEZWJb3k9zXO0btA6meXy3HhJ1 MP37Zb5AUpHKcN1sH/FOo7/dhMCBFDoW2duxZeGiej+nAtpSqnMteZ1ZoMQGorp2LssA y/3astHValP99AW5UR9sY09D3iBy6N/4eSKCdbQ+8rGfnDH+IzSChtP+E9nwzenseSs5 Ni+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735861918; x=1736466718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=esADafnBa+ynGcSys0ZaJRzZMYe/6fqtBVZhnDQq6fA=; b=klJFTYKTrQo6MvZORzmjvHnqBjciJvSQrIhtVpVw8eMI3pQRNMdKF/a9B86Hd22n1B UDYJgUF21q+hwZRvZIulwUxXXz7be6SevAvtIFnXeoaL5C8hgyhQb/WlniwbYLWVCHSk jr+x8qC+djoK/RuO+uMiLYMoZOD4XpJYBAmFVPgZFhVW/2pWpA0CnNiFhpaixVO616uI gnojs8noJ4AoOJ89XrZCs4WLCtA5914xbtZWICUrbzuWREsG+QTLB/thA2yIaudiGx/L FEi0Necs3nq/mY86dT+fnPfV/h3rpqZ1XYQ4lcaAKQKNd7XFsNU8T1q8dgRPMDwXLc4D vTVg== X-Gm-Message-State: AOJu0YzZEHGKEg8xjCx+QqAHKX3Vzdqkd9izPj4D18cpLCjvSRNNf2W4 KObLvE7/pEe+b1/B+Uqg4bSR4aP8wuKaba84O5vaVrhzxLRd8mkXb0YldPpXZZ4= X-Gm-Gg: ASbGncuSFb975f6f0EFpykHNe85ASD2Kd+CHIwmXpGNkDl9/C+3ayuatQRjc9exosJZ 189cr99KScOevg2INacaX8tv+IgPEcJS8Fy9cWRszGn6E2/BeDM+E0aaaMetv+vR3nPOULyGkBw +aF4hkCMG2bNaPdGx0df0J0ivev0fL/rVNHcfeJPfWW6S86z92P3zOftuf/UOPCUuet+JCjB378 NOIJiRUXNFw2+iSLXloW3c5OXeFYvzH4PYhPjPHjspkR3agw8R60COlgQnZznO4B5XDpH6uMpCt Iq1sC8Dg X-Google-Smtp-Source: AGHT+IHtEcOWvAAF0t3MY5gVCxMQp4EwHcZM5Z48c6uMlcVpKwfqzr39YbFhe/wNAqHgji4ek2x4hQ== X-Received: by 2002:a17:90b:2649:b0:2ee:dd9b:e402 with SMTP id 98e67ed59e1d1-2f452e0e152mr86990483a91.12.1735861918597; Thu, 02 Jan 2025 15:51:58 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f68e4sm232888305ad.211.2025.01.02.15.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 15:51:58 -0800 (PST) Date: Thu, 2 Jan 2025 15:51:55 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH 0/5] add portable version of __builtin_add_overflow Message-ID: <20250102155155.3c7545f3@pi5> In-Reply-To: <1735857169-19131-1-git-send-email-andremue@linux.microsoft.com> References: <1735857169-19131-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 2 Jan 2025 14:32:43 -0800 Andre Muezerie wrote: > __builtin_add_overflow is gcc specific. There's a need for a portable > version that can also be used with other compilers. > > Andre Muezerie (5): > maintainers: add portable version of __builtin_add_overflow > lib/eal: add portable version of __builtin_add_overflow > doc/api: add portable version of __builtin_add_overflow > drivers/net: use portable version of __builtin_add_overflow > app/test: add tests for portable versions of __builtin_add_overflow > > MAINTAINERS | 1 + > app/test/meson.build | 1 + > app/test/test_math.c | 125 +++++++++++++++++++++++++++++++++ > doc/api/doxy-api-index.md | 1 + > drivers/net/ice/base/ice_nvm.c | 9 ++- > lib/eal/include/meson.build | 1 + > lib/eal/include/rte_math.h | 42 +++++++++++ > 7 files changed, 175 insertions(+), 5 deletions(-) > create mode 100644 app/test/test_math.c > create mode 100644 lib/eal/include/rte_math.h > > -- > 2.47.0.vfs.0.3 > You should add _builtin_add_overflow into the checkpatch naughty list. Or maybe all the _builtin_XXX functions?