From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D5BC45FCC;
	Fri,  3 Jan 2025 01:15:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 11312402D6;
	Fri,  3 Jan 2025 01:15:34 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 0D99A402B1
 for <dev@dpdk.org>; Fri,  3 Jan 2025 01:15:32 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 610882041A8B; Thu,  2 Jan 2025 16:15:31 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 610882041A8B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1735863331;
 bh=CurXeAiOnhm2qDtnVgaOu8LlyIZkR848csjQUb/LaT4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=KcPPxUq5s6fUqWoKkflQsPpDOuCZ8ohJekddNRjAaXmsr8a1uaeutQuJGDYs93Sui
 nNWvUvoS7Fp8lGIuElbdWJDqs9MfX6IAXYQQFeXXQZ34Y4H+HuymrcrQxs2+zAjV4R
 +2ITpYn/zw7TBTlt/2W/JNTk6NEtZDipTv3DyURA=
Date: Thu, 2 Jan 2025 16:15:31 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/5] add portable version of __builtin_add_overflow
Message-ID: <20250103001531.GA31773@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1735857169-19131-1-git-send-email-andremue@linux.microsoft.com>
 <20250102155155.3c7545f3@pi5>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250102155155.3c7545f3@pi5>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Jan 02, 2025 at 03:51:55PM -0800, Stephen Hemminger wrote:
> On Thu,  2 Jan 2025 14:32:43 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > __builtin_add_overflow is gcc specific. There's a need for a portable
> > version that can also be used with other compilers.
> > 
> > Andre Muezerie (5):
> >   maintainers: add portable version of __builtin_add_overflow
> >   lib/eal: add portable version of __builtin_add_overflow
> >   doc/api: add portable version of __builtin_add_overflow
> >   drivers/net: use portable version of __builtin_add_overflow
> >   app/test: add tests for portable versions of __builtin_add_overflow
> > 
> >  MAINTAINERS                    |   1 +
> >  app/test/meson.build           |   1 +
> >  app/test/test_math.c           | 125 +++++++++++++++++++++++++++++++++
> >  doc/api/doxy-api-index.md      |   1 +
> >  drivers/net/ice/base/ice_nvm.c |   9 ++-
> >  lib/eal/include/meson.build    |   1 +
> >  lib/eal/include/rte_math.h     |  42 +++++++++++
> >  7 files changed, 175 insertions(+), 5 deletions(-)
> >  create mode 100644 app/test/test_math.c
> >  create mode 100644 lib/eal/include/rte_math.h
> > 
> > --
> > 2.47.0.vfs.0.3
> > 
> 
> You should add _builtin_add_overflow into the checkpatch naughty list.
> Or maybe all the _builtin_XXX functions?

Absolutely! Let me add that for a v2 series.