From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50F545FCC; Fri, 3 Jan 2025 01:41:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D102402BD; Fri, 3 Jan 2025 01:41:51 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8B34D402B1 for ; Fri, 3 Jan 2025 01:41:49 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id A16D02041A8C; Thu, 2 Jan 2025 16:41:48 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A16D02041A8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1735864908; bh=bnBUV5MiWur7jgmO6b69PNKuZ58/xZ/97TgDVyq3Lak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lTBNZ0tQrgEEyXyRDKj+7Ir9NueZYaLNn8Na2n2XY5TVVZQRNhbdE5ZbEkFQ/IZ61 DaS+6UBAAoFR8ZjZ8IBduPQbTGc6YYwkCONbzUWTqkGf+6GpgYchH1E2JWwUFMBWUY qsTSODlAMn/YIFyoQHZUMpJN/0lHW0X5hXq9iyZU= Date: Thu, 2 Jan 2025 16:41:48 -0800 From: Andre Muezerie To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH 0/5] add portable version of __builtin_add_overflow Message-ID: <20250103004148.GA2731@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1735857169-19131-1-git-send-email-andremue@linux.microsoft.com> <20250102155155.3c7545f3@pi5> <20250103001531.GA31773@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250103001531.GA31773@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 02, 2025 at 04:15:31PM -0800, Andre Muezerie wrote: > On Thu, Jan 02, 2025 at 03:51:55PM -0800, Stephen Hemminger wrote: > > On Thu, 2 Jan 2025 14:32:43 -0800 > > Andre Muezerie wrote: > > > > > __builtin_add_overflow is gcc specific. There's a need for a portable > > > version that can also be used with other compilers. > > > > > > Andre Muezerie (5): > > > maintainers: add portable version of __builtin_add_overflow > > > lib/eal: add portable version of __builtin_add_overflow > > > doc/api: add portable version of __builtin_add_overflow > > > drivers/net: use portable version of __builtin_add_overflow > > > app/test: add tests for portable versions of __builtin_add_overflow > > > > > > MAINTAINERS | 1 + > > > app/test/meson.build | 1 + > > > app/test/test_math.c | 125 +++++++++++++++++++++++++++++++++ > > > doc/api/doxy-api-index.md | 1 + > > > drivers/net/ice/base/ice_nvm.c | 9 ++- > > > lib/eal/include/meson.build | 1 + > > > lib/eal/include/rte_math.h | 42 +++++++++++ > > > 7 files changed, 175 insertions(+), 5 deletions(-) > > > create mode 100644 app/test/test_math.c > > > create mode 100644 lib/eal/include/rte_math.h > > > > > > -- > > > 2.47.0.vfs.0.3 > > > > > > > You should add _builtin_add_overflow into the checkpatch naughty list. > > Or maybe all the _builtin_XXX functions? > > Absolutely! Let me add that for a v2 series. Turns out such check was already added recently (MESSAGE='Using __builtin helpers, prefer EAL macros'), so further changes needed at this point.