From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B03445FD9; Fri, 3 Jan 2025 20:22:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49D2F402DC; Fri, 3 Jan 2025 20:22:09 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 491EA402B1 for ; Fri, 3 Jan 2025 20:22:08 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21669fd5c7cso178104605ad.3 for ; Fri, 03 Jan 2025 11:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735932127; x=1736536927; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tspHQKZ3VrF/N5wEkB/1MAMMpxMZjUGnWapDmflYONo=; b=F3oxO+r92950F65qhamjZEnqblRP4x2oW1Aa4chHAVddg5R6er0YEwjt3wd2ZqyYJO ct+U8/QUE90SlLr0Pjjkf9gzIYos6ZSM/WwgBi7qQ/4IC5nme/KVHfAMNqd5vFmkQQ8p QWR24SkHqwvfvt5vtl1zxyYHdsHYvPlZD8n3QlSTg98IH/sKPISmp6WSW84A7XHqtc7v SSONwijWIrewgcatp037ttl4R3v55BQo/BJPa4HxGlfj/nxxMEWql3kWibwEodM5lWvx amUxXbAcVtdqg2QOB+/NkcidMgCeOBRT3ZNPPNaR+Watgqti2+LjxKZA8cUxq45PVi3+ yHwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735932127; x=1736536927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tspHQKZ3VrF/N5wEkB/1MAMMpxMZjUGnWapDmflYONo=; b=H3X5NMWZFuEzHXx2pnR2kS3Ev3zQgq70FhHWfpzAO95F74O2uOf1VR6shYfLLUV56L 9pMFLUaVEmSydGq/YQ0E2MNANyzGz25mCq6ShHvvxeDORhcPEbFUW07tZ9qLjuf1+VUW MdCZ7gjdTMx2P0ANS5AKXPT1+wKjtHZYFg3oE3aZi/Y3+LV7qGrWDsf4muGh0f8eWKEF mNmzyarsZHTKwwPu/4wbmetMAihc6JfozAZ6ysbqHccxEk2k3BysVBcXuBu5vNQS8hfh GWNuhnEfJ52AWkIzwGmy4oae8CgiLKswaZKJFOGuo/JndMD7LdbNsx79c4tgURnhhdUQ fJqQ== X-Gm-Message-State: AOJu0Yz+vtoccge5MbPWu5JtUYtsfHhOAbb96xrFwyu7q9v4hDI08uUa NcV1o2eCmneqYyWi52DyE9q6SqYgddnkGXcCQwKamPSDJoPjsoCruRCRA2ai0CA= X-Gm-Gg: ASbGncvYtbxrZuOIWb7gaJ2JuhNam2IiCoDCr1Dhhjx08SRjtCSa+Sd9MDT55AJYTvr B+sof7V4V0MDpUeb5L3bIjSg4gUVa+NvZbS0WfuSVQ4NEj+U88fLsr8deu/08NdAceFFstkeuD0 0YojZEEtjONSYvbr0/ySyY0hT33Oy10BYDDjZaqThI9CGa6zcCXpjaB9DWbKD4x1l5Ojhri61dt PvQK3LAK23cQda+/UtqTO4nZ6XiDgZAKddPoSbg8MaKMbRJAdGJkqadjUI+DI5MQNQ2aQyizU6E ALpugv/+ X-Google-Smtp-Source: AGHT+IEtQf5C5z2R84CQLbrUyFP36jaCFlvY1W5ejOSyXnM8aqVBAgdnXta6UW7yZXwq0oK5fmkWLQ== X-Received: by 2002:a17:902:d4cf:b0:216:60a5:ebfd with SMTP id d9443c01a7336-219e6f5472fmr543651365ad.55.1735932127223; Fri, 03 Jan 2025 11:22:07 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca0296bsm248542625ad.235.2025.01.03.11.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 11:22:07 -0800 (PST) Date: Fri, 3 Jan 2025 11:22:03 -0800 From: Stephen Hemminger To: "WanRenyong" Cc: , , , , , , , , , Subject: Re: [PATCH v4 14/15] net/xsc: add ethdev infos get Message-ID: <20250103112203.48955f38@pi5> In-Reply-To: <20250103150434.1529663-15-wanry@yunsilicon.com> References: <20250103150404.1529663-1-wanry@yunsilicon.com> <20250103150434.1529663-15-wanry@yunsilicon.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 03 Jan 2025 23:04:35 +0800 "WanRenyong" wrote: > + > +static int > +xsc_ethdev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > +{ > + struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev); > + > + info->min_rx_bufsize = 64; > + info->max_rx_pktlen = 65536; > + info->max_lro_pkt_size = 0; > + info->max_rx_queues = 256; > + info->max_tx_queues = 1024; > + info->rx_desc_lim.nb_max = 4096; > + info->rx_desc_lim.nb_min = 16; > + info->tx_desc_lim.nb_max = 8192; > + info->tx_desc_lim.nb_min = 128; > + > + info->rx_queue_offload_capa = xsc_get_rx_queue_offloads(dev); > + info->rx_offload_capa = info->rx_queue_offload_capa; > + info->tx_offload_capa = xsc_get_tx_port_offloads(dev); > + > + info->if_index = priv->ifindex; > + info->speed_capa = priv->xdev->link_speed_capa; > + info->hash_key_size = XSC_RSS_HASH_KEY_LEN; > + info->tx_desc_lim.nb_seg_max = 8; > + info->tx_desc_lim.nb_mtu_seg_max = 8; > + info->switch_info.name = dev->data->name; > + info->switch_info.port_id = priv->representor_id; > + return 0; > +} > + Note: that driver probably won't be at all functional without info_get but as long as each patch builds, it doesn't matter to me what order the patchset is in. Too hard to get a working driver at each step.